Skip to content

Fixed code owner for NRP #24889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weshaggard merged 1 commit into from
Jul 19, 2023
Merged

Fixed code owner for NRP #24889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
/specification/monitor/ @gucalder

# PRLabel: %Network
/specification/network/ @MikhailTryakhov
/specification/network/ @Joanna-Yang-Art

@weshaggard weshaggard Jul 18, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This user doesn't have write permissions to the repo so github will not add them as reviewers. They will need to get the correct permissions before this will be helpful.

@MikhailTryakhov MikhailTryakhov Jul 18, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weshaggard how to get these permissions for @Joanna-Yang-Art? The main idea from me - I definitely don't need to be an owner anymore...

@weshaggard weshaggard Jul 19, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK @MikhailTryakhov I'll go ahead and merge this to get you off the reviewer set.

@Joanna-Yang-Art please see https://aka.ms/azsdk/permission for the necessary permissions.


# PRLabel: %Notification Hub
/specification/notificationhubs/ @amolr @smithab
Expand Down