[EventGrid/ACR] Add schema of ACR events published to Event Grid#2487
[EventGrid/ACR] Add schema of ACR events published to Event Grid#2487lmazuel merged 3 commits intoAzure:masterfrom
Conversation
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-goWas unable to create SDK azure-sdk-for-go PR for this closed PR. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
| "description": "Schema of the Data property of an EventGridEvent for a Microsoft.ContainerRegistry.ImagePushed event.", | ||
| "allOf": [ | ||
| { | ||
| "$ref": "#/definitions/EventContent" |
There was a problem hiding this comment.
For all the types referenced here (EventContent, Actor, Target, etc.), it looks to me that they should be qualified with the prefix "ContainerRegistry" as all these types will get generated under the same namespace Microsoft.Azure.EventGrid.Models. @lmazuel, what do you think, is there a better approach?
There was a problem hiding this comment.
EventContent can be prefixed with ContainerRegistry for sure. We had a similar issue with the naming here in our own models that types such as Target, Request, and Source are from standard docker notification schema but they may conflict with other models in the same namespace.
Are you generating data-plane models into SDKs?
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger