[AZURE] Microsoft.AzureStack namespace specs#2484
Conversation
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-goEncountered a Subprocess error: (azure-sdk-for-go)
Command: dep ensure /bin/sh: 1: dep: not found |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: 💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡 File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
| "$ref": "#/definitions/CustomerSubscriptionList" | ||
| } | ||
| }, | ||
| "404": { |
There was a problem hiding this comment.
All the negative response status code descriptions MUST be defined in the description of the "default" status code (if the intention is for documentation purpose only). Example: "description": "'404' - 'Not found'.\n'400' - 'Bad request'.\n'500': 'Internal Server Error'."'
There was a problem hiding this comment.
This is not for documentation. This is so we don't throw an exception and instead return a null object. Is that okay? Please let me know if I understood correctly.
| "$ref": "#/definitions/CustomerSubscription" | ||
| } | ||
| }, | ||
| "404": { |
There was a problem hiding this comment.
Same here and elsewhere.
|
@jianghaolu I have responded to your requests. |
|
@jianghaolu Please merge. |
|
Looks good! |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger