Corrected API versions by mcardosos · Pull Request #2482 · Azure/azure-rest-api-specs

mcardosos · 2018-02-12T22:49:01Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

mcardosos · 2018-02-12T22:49:13Z

@darshanhs90 PTAL :)

AutorestCI · 2018-02-12T22:49:55Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#1967

AutorestCI · 2018-02-12T22:51:59Z

Automation for azure-sdk-for-go

Was unable to create SDK azure-sdk-for-go PR for this closed PR.

sarangan12 · 2018-02-12T22:53:41Z

Looks Good

darshanhs90 · 2018-02-12T22:55:11Z

  "swagger": "2.0",
  "info": {
    "title": "AuthorizationManagementClient",
-    "version": "2015-07-01",


"2015-07-01", [](start = 15, length = 13)

the earlier api version is correct,since we added new api-version support for roleassignment calls only

@mcardosos what about the above comment?

darshanhs90 · 2018-02-12T22:56:11Z

  "swagger": "2.0",
  "info": {
    "title": "AuthorizationManagementClient",
-    "version": "2015-07-01",


"2015-07-01", [](start = 15, length = 13)

classicadmin API is owned by ARM team,hence we didnt modify the api version here and modified only for the API calls which we own

darshanhs90

🕐

olydis

moved examples still have 2017-10-01-preview; not crucial but misleading, especially if docs are generated from this!

darshanhs90 · 2018-02-13T22:47:42Z

  "info": {
    "title": "AuthorizationManagementClient",
-    "version": "2017-10-01-preview",
+    "version": "2015-07-01",


"2015-07-01", [](start = 15, length = 13)

missed it in the review,this version shouldnt be changed

darshanhs90 · 2018-02-13T22:48:49Z

  "info": {
    "title": "AuthorizationManagementClient",
-    "version": "2015-07-01",
+    "version": "2017-10-01-preview",


version": "2017-10-01-preview", [](start = 5, length = 31)

this it the file ,in which the version can be changed to the 2015 version

darshanhs90

left some comments to change

mcardosos · 2018-02-14T00:05:28Z

@darshanhs90 Fixed :)

azuresdkciprbot · 2018-02-14T00:12:52Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/authorization/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

darshanhs90 · 2018-02-14T18:38:38Z

"api-version": "2017-04-19"

one minor thing,which i might have missed in my PR.
2015-07-01

Refers to: specification/authorization/resource-manager/Microsoft.Authorization/preview/2015-07-01/examples/DeleteRoleDefinition.json:5 in 032301c. [](commit_id = 032301c, deletion_comment = False)

darshanhs90

azuresdkciprbot · 2018-02-15T01:02:51Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/authorization/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

* changes to enable projected workspaces * Added example jsons for the shares * changes to add readme * changes after swagger errors * changes * Adding shareId to workspaceId * Adding shareId to workspaceId * Adding shareId to workspaceId * removing readme * changes to readme * changes to readme * changes to swagger validations errors * changes to swaggers * changes to swagger validations errors * shares.json * changes to swagger validations errors * changes to swagger validations errors * changes to swagger validations errors * changes to swagger validations errors * changes to swaggers * changes to swaggers * changes to swagger validations errors * changes to swagger validations errors * changes to swagger validations errors * changes to swagger validations errors * changes to swagger validations errors * changes to swagger validations errors * changes to swagger validations errors * changes to swagger validations errors * changes to swagger validations errors * changes to swagger validations errors * changes to swaggers * changes to swagger validations errors * changes to swagger validations errors * changes to swagger validations errors * custom words * custom words * adding formating changes * adding formating changes * adding formating changes * formatting changes * formatting changes * code review comments * code review comments * code review comments * code review comments * Adding share list * code review comments * code review commits * Shares * Shares * adding systemsdata to response * changes to shares json * adding systemsdata to response * changes to shares json * changes to shares * changes to share * code review comments * Update workspaces.json * code review comments fix for adding type to the jsons * code review comments fix for adding type to the jsons * Update workspaces.json removing description * Update workspaces.json * workspaces * chanegs to fix lint * chanegs to fix lint * chanegs to fix lint * changes to lint errors * chanegs to fix lint * chanegs to fix lint Co-authored-by: root <root@MININT-F8K8E41.fareast.corp.microsoft.com> Co-authored-by: Yamuna Ravichandran <yaravich@microsoft.com>

Corrected API versions

75de097

mcardosos requested a review from darshanhs90 February 12, 2018 22:49

azuresdkci assigned olydis Feb 12, 2018

AutorestCI mentioned this pull request Feb 12, 2018

[AutoPR authorization/resource-manager] Corrected API versions Azure/azure-sdk-for-python#1967

Closed

darshanhs90 reviewed Feb 12, 2018

View reviewed changes

darshanhs90 suggested changes Feb 13, 2018

View reviewed changes

Move to correct folder

56ba97e

darshanhs90 approved these changes Feb 13, 2018

View reviewed changes

olydis reviewed Feb 13, 2018

View reviewed changes

darshanhs90 reviewed Feb 13, 2018

View reviewed changes

darshanhs90 suggested changes Feb 13, 2018

View reviewed changes

mcardosos added 2 commits February 13, 2018 16:02

Fix version

824b8d4

Correct swagger version

032301c

darshanhs90 approved these changes Feb 14, 2018

View reviewed changes

Fixed example

b82905f

olydis approved these changes Feb 15, 2018

View reviewed changes

olydis merged commit 64683a5 into Azure:master Feb 15, 2018

Conversation

mcardosos commented Feb 12, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

mcardosos commented Feb 12, 2018

Uh oh!

AutorestCI commented Feb 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Feb 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

sarangan12 commented Feb 12, 2018

Uh oh!

darshanhs90 Feb 12, 2018

Choose a reason for hiding this comment

Uh oh!

olydis Feb 13, 2018

Choose a reason for hiding this comment

Uh oh!

darshanhs90 Feb 12, 2018

Choose a reason for hiding this comment

Uh oh!

darshanhs90 left a comment

Choose a reason for hiding this comment

Uh oh!

olydis left a comment

Choose a reason for hiding this comment

Uh oh!

darshanhs90 Feb 13, 2018

Choose a reason for hiding this comment

Uh oh!

darshanhs90 Feb 13, 2018

Choose a reason for hiding this comment

Uh oh!

darshanhs90 left a comment

Choose a reason for hiding this comment

Uh oh!

mcardosos commented Feb 14, 2018

Uh oh!

azuresdkciprbot commented Feb 14, 2018

Uh oh!

darshanhs90 commented Feb 14, 2018

Uh oh!

darshanhs90 left a comment

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Feb 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mcardosos commented Feb 12, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Feb 12, 2018 •

edited

Loading

AutorestCI commented Feb 12, 2018 •

edited

Loading