Skip to content

adding purge protection vault property #2478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schaabs merged 3 commits into from
Feb 21, 2018
Merged

adding purge protection vault property #2478

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e331ee2
adding purge protection vault property
Feb 12, 2018
3627cad
Expanding the description of the soft delete and purge protection pro…
Feb 13, 2018
cc21704
relocating the newly introduced property to the end of the schema
Feb 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ource-manager/Microsoft.KeyVault/stable/2016-10-01/examples/listVaultByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
"enabledForDiskEncryption":true,
"enabledForTemplateDeployment":true,
"enableSoftDelete":true,
"enablePurgeProtection":false,
"vaultUri":"https://sample-vault.vault.azure.net/"
}
}
Expand Down
1 change: 1 addition & 0 deletions ...source-manager/Microsoft.KeyVault/stable/2016-10-01/examples/listVaultBySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
"enabledForDiskEncryption":true,
"enabledForTemplateDeployment":true,
"enableSoftDelete":true,
"enablePurgeProtection":false,
"vaultUri":"https://sample-vault.vault.azure.net/"
}
}
Expand Down
12 changes: 10 additions & 2 deletions specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2016-10-01/keyvault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,11 @@
},
"enableSoftDelete": {
"type": "boolean",
"description": "Property to specify whether the 'soft delete' functionality is enabled for this key vault. It does not accept false value."
"description": "Property specifying whether recoverable deletion ('soft' delete) is enabled for this key vault. The property may not be set to false."
},
"enablePurgeProtection": {

@schaabs schaabs Feb 13, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be moved after create mode to avoid breaking changes in the sdk

"type": "boolean",
"description": "Property specifying whether protection against purge is enabled for this vault; it is only effective if soft delete is also enabled. Once activated, the property may no longer be reset to false."
},
"createMode": {
"type": "string",
Expand Down Expand Up @@ -922,7 +926,11 @@
},
"enableSoftDelete": {
"type": "boolean",
"description": "Property to specify whether the 'soft delete' functionality is enabled for this key vault. It does not accept false value."
"description": "Property specifying whether recoverable deletion ('soft' delete) is enabled for this key vault. The property may not be set to false."
},
"enablePurgeProtection": {

@schaabs schaabs Feb 13, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be moved after create mode to avoid breaking changes in the sdk

"type": "boolean",
"description": "Property specifying whether protection against purge is enabled for this vault; it is only effective if soft delete is also enabled. Once activated, the property may no longer be reset to false."
},
"createMode": {
"type": "string",
Expand Down