Skip to content

CVM TDX and Custom UEFI Keys#24686

Closed
tiregan wants to merge 8 commits into
Azure:feature/cplat-2022-08-03-2ndfrom
tiregan:feature/tiregan/tdxAndCustomUefi
Closed

CVM TDX and Custom UEFI Keys#24686
tiregan wants to merge 8 commits into
Azure:feature/cplat-2022-08-03-2ndfrom
tiregan:feature/tiregan/tdxAndCustomUefi

Conversation

@tiregan
Copy link
Copy Markdown
Contributor

@tiregan tiregan commented Jul 3, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification -- the branch I'm merging into is the new API version, so this is part of the change for new API version :)

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Jul 3, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 18 Warnings warning [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
gallery.json 2022-08-03(fa4f54f) 2022-03-03(main)
gallery.json 2022-08-03(fa4f54f) 2020-09-30(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule Message
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: GalleryRP/stable/2022-08-03/gallery.json#L1780:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L1736:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: GalleryRP/stable/2022-08-03/gallery.json#L2364:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L2106:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: GalleryRP/stable/2022-08-03/gallery.json#L2422:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L2251:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: GalleryRP/stable/2022-08-03/gallery.json#L2729:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L2439:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: GalleryRP/stable/2022-08-03/gallery.json#L2819:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: GalleryRP/stable/2022-08-03/gallery.json#L2819:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: GalleryRP/stable/2022-08-03/gallery.json#L2078:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L1917:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: GalleryRP/stable/2022-08-03/gallery.json#L2819:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: GalleryRP/stable/2022-08-03/gallery.json#L2729:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L2439:9
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: GalleryRP/stable/2022-08-03/gallery.json#L2819:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: GalleryRP/stable/2022-08-03/gallery.json#L2819:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: GalleryRP/stable/2022-08-03/gallery.json#L2819:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L2515:9
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'uri' renamed or removed?
New: GalleryRP/stable/2022-08-03/gallery.json#L2750:7
Old: GalleryRP/preview/2020-09-30/gallery.json#L2456:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'uri' renamed or removed?
New: GalleryRP/stable/2022-08-03/gallery.json#L2764:7
Old: GalleryRP/preview/2020-09-30/gallery.json#L2456:7
⚠️ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: GalleryRP/stable/2022-08-03/gallery.json#L1780:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L1736:9
⚠️ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: GalleryRP/stable/2022-08-03/gallery.json#L2364:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L2106:9
⚠️ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: GalleryRP/stable/2022-08-03/gallery.json#L2422:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L2251:9
⚠️ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: GalleryRP/stable/2022-08-03/gallery.json#L2078:9
Old: GalleryRP/preview/2020-09-30/gallery.json#L1917:9
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.4) new version base version
package-2022-08-03 package-2022-08-03(fa4f54f) package-2022-08-03(feature/cplat-2022-08-03-2nd)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'galleryName' should be defined with a 'pattern' restriction.
Location: GalleryRP/stable/2022-08-03/gallery.json#L37
PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
Location: GalleryRP/stable/2022-08-03/gallery.json#L71
LroLocationHeader A 202 response should include an Location response header.
Location: GalleryRP/stable/2022-08-03/gallery.json#L84
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: GalleryRP/stable/2022-08-03/gallery.json#L93
PatchResponseCode LRO PATCH must have 200 and 202 return codes.
Location: GalleryRP/stable/2022-08-03/gallery.json#L113
LroPatch202 The async patch operation should return 202.
Location: GalleryRP/stable/2022-08-03/gallery.json#L146
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: GalleryRP/stable/2022-08-03/gallery.json#L156
ParametersInPointGet Query parameter $select should be removed. Point Get's MUST not have query parameters other than api version.
Location: GalleryRP/stable/2022-08-03/gallery.json#L173
ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: GalleryRP/stable/2022-08-03/gallery.json#L173
LroLocationHeader A 202 response should include an Location response header.
Location: GalleryRP/stable/2022-08-03/gallery.json#L265
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: GalleryRP/stable/2022-08-03/gallery.json#L274
ResourceNameRestriction The resource name parameter 'galleryName' should be defined with a 'pattern' restriction.
Location: GalleryRP/stable/2022-08-03/gallery.json#L286
ResourceNameRestriction The resource name parameter 'galleryImageName' should be defined with a 'pattern' restriction.
Location: GalleryRP/stable/2022-08-03/gallery.json#L286
PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
Location: GalleryRP/stable/2022-08-03/gallery.json#L327
LroLocationHeader A 202 response should include an Location response header.
Location: GalleryRP/stable/2022-08-03/gallery.json#L340
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: GalleryRP/stable/2022-08-03/gallery.json#L349
PatchResponseCode LRO PATCH must have 200 and 202 return codes.
Location: GalleryRP/stable/2022-08-03/gallery.json#L360
LroPatch202 The async patch operation should return 202.
Location: GalleryRP/stable/2022-08-03/gallery.json#L400
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: GalleryRP/stable/2022-08-03/gallery.json#L410
LroLocationHeader A 202 response should include an Location response header.
Location: GalleryRP/stable/2022-08-03/gallery.json#L507
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: GalleryRP/stable/2022-08-03/gallery.json#L516
ResourceNameRestriction The resource name parameter 'galleryName' should be defined with a 'pattern' restriction.
Location: GalleryRP/stable/2022-08-03/gallery.json#L528
ResourceNameRestriction The resource name parameter 'galleryImageName' should be defined with a 'pattern' restriction.
Location: GalleryRP/stable/2022-08-03/gallery.json#L528
ResourceNameRestriction The resource name parameter 'galleryImageVersionName' should be defined with a 'pattern' restriction.
Location: GalleryRP/stable/2022-08-03/gallery.json#L528
PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
Location: GalleryRP/stable/2022-08-03/gallery.json#L576
LroLocationHeader A 202 response should include an Location response header.
Location: GalleryRP/stable/2022-08-03/gallery.json#L589
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: GalleryRP/stable/2022-08-03/gallery.json#L598
PatchResponseCode LRO PATCH must have 200 and 202 return codes.
Location: GalleryRP/stable/2022-08-03/gallery.json#L636
LroPatch202 The async patch operation should return 202.
Location: GalleryRP/stable/2022-08-03/gallery.json#L683
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: GalleryRP/stable/2022-08-03/gallery.json#L693
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/compute/resource-manager/readme.md
tag: specification/compute/resource-manager/readme.md#tag-package-2022-08-03
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link
Copy Markdown

Hi, @tiregan! Thank you for your pull request. To help get your PR merged:
- Ensure you reviewed the checklists in the PR description. - Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval. - For convenient view of the API changes made by this PR, refer to the URLs provided in the table in
the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Jul 3, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking




️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from f6a74ed22003152eeb9c22cf5ea4cfe21d954fb9. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.Compute [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from f6a74ed22003152eeb9c22cf5ea4cfe21d954fb9. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh] notice
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.8.1` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-compute [View full logs]  [Preview SDK Changes]
    info	[Changelog] change log generation failed!!!
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from f6a74ed22003152eeb9c22cf5ea4cfe21d954fb9. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-compute-generated [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from f6a74ed22003152eeb9c22cf5ea4cfe21d954fb9. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-compute [View full logs]  [Preview SDK Changes]
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added Interface GalleryImageVersionUefiSettings
    info	[Changelog]   - Added Interface ImageVersionSecurityProfile
    info	[Changelog]   - Added Interface UefiKey
    info	[Changelog]   - Added Interface UefiKeySignatures
    info	[Changelog]   - Added Type Alias UefiKeyType
    info	[Changelog]   - Added Type Alias UefiSignatureTemplateName
    info	[Changelog]   - Interface GalleryImageVersion has a new optional parameter securityProfile
    info	[Changelog]   - Interface GalleryImageVersionUpdate has a new optional parameter securityProfile
    info	[Changelog]   - Added Enum KnownUefiKeyType
    info	[Changelog]   - Added Enum KnownUefiSignatureTemplateName
    info	[Changelog]   - Enum KnownConfidentialVMEncryptionType has a new value NonPersistedTPM
    info	[Changelog]   - Enum KnownReplicationStatusTypes has a new value UefiSettings
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from f6a74ed22003152eeb9c22cf5ea4cfe21d954fb9. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/compute/armcompute [View full logs]  [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `ConfidentialVMEncryptionTypeNonPersistedTPM` added to enum type `ConfidentialVMEncryptionType`
    info	[Changelog] - New value `ReplicationStatusTypesUefiSettings` added to enum type `ReplicationStatusTypes`
    info	[Changelog] - New enum type `UefiKeyType` with values `UefiKeyTypeSHA256`, `UefiKeyTypeX509`
    info	[Changelog] - New enum type `UefiSignatureTemplateName` with values `UefiSignatureTemplateNameMicrosoftUefiCertificateAuthorityTemplate`, `UefiSignatureTemplateNameMicrosoftWindowsTemplate`, `UefiSignatureTemplateNameNoSignatureTemplate`
    info	[Changelog] - New struct `GalleryImageVersionUefiSettings`
    info	[Changelog] - New struct `ImageVersionSecurityProfile`
    info	[Changelog] - New struct `UefiKey`
    info	[Changelog] - New struct `UefiKeySignatures`
    info	[Changelog] - New field `SecurityProfile` in struct `GalleryImageVersionProperties`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 18 additive change(s).
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from f6a74ed22003152eeb9c22cf5ea4cfe21d954fb9. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️compute [View full logs]  [Preview Schema Changes]
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs] Generate from f6a74ed22003152eeb9c22cf5ea4cfe21d954fb9. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ⚠️Az.compute.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.compute.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Jul 3, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/compute/armcompute https://apiview.dev/Assemblies/Review/2d08ea50ee28480ab263d934333d0d15
Java azure-resourcemanager-compute-generated https://apiview.dev/Assemblies/Review/55a6e8ecda17423cb55361094f826645
JavaScript @azure/arm-compute https://apiview.dev/Assemblies/Review/202ac7284b4c4e33a1f394067ee2fc70
.Net Azure.ResourceManager.Compute https://apiview.dev/Assemblies/Review/0e0e6e2157bf4eefad556698119a7572
Swagger Microsoft.Compute https://apiview.dev/Assemblies/Review/19a9f087dfb946118b0b1aafd17f407c

@openapi-workflow-bot
Copy link
Copy Markdown

Hi @tiregan! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

TaskHow to fixPriority
AvocadoFix-AvocadoHigh
Semantic ValidationFix-SemanticValidation-ErrorHigh
Model ValidationFix-ModelValidation-ErrorHigh
LintDiffFix-LintDiffHigh

If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@openapi-pipeline-app
Copy link
Copy Markdown

Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

9 similar comments
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

13 similar comments
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Hi, @tiregan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview CI-FixRequiredOnFailure Compute DoNotMerge <valid label in PR review process> use to hold merge after approval resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants