Conversation
|
Hi, @konrad-jamrozik Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
|
Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
pull_request_assignment.yml: remove armapireview as it is misconfigured.
11 tasks
Author
|
@rkmanda we should either merge this PR ASAP, or an admin of |
rkmanda
reviewed
Jun 25, 2023
pull_request_assignment.yml: remove armapireview as it is misconfigured.pull_request_assignment.yml: remove armapireview and other reviewers for ARM paths, except rkmanda.
Removed all other assignees for mgmt. plane PR.
raych1
approved these changes
Jun 26, 2023
rkmanda
reviewed
Jun 26, 2023
rkmanda
reviewed
Jun 26, 2023
rkmanda
reviewed
Jun 26, 2023
Moved the default mgmt. PR assignment rule.
rkmanda
reviewed
Jun 27, 2023
harryli0108
pushed a commit
to harryli0108/azure-rest-api-specs
that referenced
this pull request
Jul 28, 2023
… reviewers for ARM paths, except `rkmanda`. (Azure#24566) * Update pull_request_assignment.yml: remove armapireview as it is misconfigured * Update pull_request_assignment.yml Removed all other assignees for mgmt. plane PR. * Update pull_request_assignment.yml Moved the default mgmt. PR assignment rule. --------- Co-authored-by: Ray Chen <raychen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR made by the Azure SDK Engineering System team.
Original description 6/24/2023
This PR removes
armapireviewfrom assignees as it appears to be misconfigured. Likely it doesn't have access. I.e. probably this user https://github.com/armapireview should be given permissions to be assignable to the repositories. This doc might be helpful here.For context, see this Teams discussion.
This Kusto query (from this doc) shows the affected PRs since 6/10/2023.
14 pull requests were affected. Even though our logs show the assignment was successful, it actually wasn't.
Here is the list of the PRs:
Update 6/25/2023
Per @rkmanda request, I removed all reviewers (not only
armapireview) for the ARM paths except him.Update 7/6/2023
Info from @weshaggard: