Skip to content

[typespec-next] React to azure/typespec-azure#3180 #24561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeharder merged 6 commits into from
Jun 23, 2023
Merged

[typespec-next] React to azure/typespec-azure#3180 #24561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
35b1df1
Merge branch 'main' into typespec-next-nullable-enum
mikeharder Jun 23, 2023
90ada80
Remove suppressions added as workaround for Azure/typespec-azure#3180
mikeharder Jun 23, 2023
baa786f
Update autorest with fix for azure/typespec-azure#3180
mikeharder Jun 23, 2023
9fd95b6
Merge branch 'typespec-next' into typespec-next-nullable-enum
mikeharder Jun 23, 2023
9b38932
Merge branch 'typespec-next' into typespec-next-nullable-enum
mikeharder Jun 23, 2023
480dccf
Merge remote-tracking branch 'upstream/typespec-next' into typespec-n…
mikeharder Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion specification/cognitiveservices/OpenAI.Inference/models/chat.completions.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ model ChatChoice {
index: int32;

#suppress "@azure-tools/typespec-azure-core/no-nullable" "The operation already returns nulls"
#suppress "@azure-tools/typespec-autorest/union-unsupported" "https://github.com/Azure/typespec-azure/issues/3180"
@doc("The reason that this chat completions choice completed its generated.")
@projectedName("json", "finish_reason")
finishReason: CompletionsFinishReason | null;
Expand Down
1 change: 0 additions & 1 deletion specification/cognitiveservices/OpenAI.Inference/models/completions.create.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ model Choice {
logprobs: CompletionsLogProbabilityModel | null;

#suppress "@azure-tools/typespec-azure-core/no-nullable" "The operation already returns nulls"
#suppress "@azure-tools/typespec-autorest/union-unsupported" "https://github.com/Azure/typespec-azure/issues/3180"
@doc("Reason for finishing")
@projectedName("json", "finish_reason")
finishReason: CompletionsFinishReason | null;
Expand Down
4 changes: 4 additions & 0 deletions ...nitiveservices/data-plane/AzureOpenAI/inference/preview/2023-06-01-preview/generated.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,8 @@
"description": "The ordered index associated with this chat completions choice."
},
"finish_reason": {
"$ref": "#/definitions/CompletionsFinishReason",
"x-nullable": true,
"x-typespec-name": "CompletionsFinishReason | null",
"description": "The reason that this chat completions choice completed its generated.",
"x-ms-client-name": "finishReason"
Expand Down Expand Up @@ -585,6 +587,8 @@
"description": "The log probabilities model for tokens associated with this completions choice."
},
"finish_reason": {
"$ref": "#/definitions/CompletionsFinishReason",
"x-nullable": true,
"x-typespec-name": "CompletionsFinishReason | null",
"description": "Reason for finishing",
"x-ms-client-name": "finishReason"
Expand Down
4 changes: 4 additions & 0 deletions ...ation/cognitiveservices/data-plane/AzureOpenAI/inference/stable/2022-12-01/generated.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,8 @@
"description": "The ordered index associated with this chat completions choice."
},
"finish_reason": {
"$ref": "#/definitions/CompletionsFinishReason",
"x-nullable": true,
"x-typespec-name": "CompletionsFinishReason | null",
"description": "The reason that this chat completions choice completed its generated.",
"x-ms-client-name": "finishReason"
Expand Down Expand Up @@ -440,6 +442,8 @@
"description": "The log probabilities model for tokens associated with this completions choice."
},
"finish_reason": {
"$ref": "#/definitions/CompletionsFinishReason",
"x-nullable": true,
"x-typespec-name": "CompletionsFinishReason | null",
"description": "Reason for finishing",
"x-ms-client-name": "finishReason"
Expand Down
4 changes: 4 additions & 0 deletions ...ation/cognitiveservices/data-plane/AzureOpenAI/inference/stable/2023-05-15/generated.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,8 @@
"description": "The ordered index associated with this chat completions choice."
},
"finish_reason": {
"$ref": "#/definitions/CompletionsFinishReason",
"x-nullable": true,
"x-typespec-name": "CompletionsFinishReason | null",
"description": "The reason that this chat completions choice completed its generated.",
"x-ms-client-name": "finishReason"
Expand Down Expand Up @@ -491,6 +493,8 @@
"description": "The log probabilities model for tokens associated with this completions choice."
},
"finish_reason": {
"$ref": "#/definitions/CompletionsFinishReason",
"x-nullable": true,
"x-typespec-name": "CompletionsFinishReason | null",
"description": "Reason for finishing",
"x-ms-client-name": "finishReason"
Expand Down