Azure OpenAI: Make startGenerateImage LRO internal for clients#24546
Merged
jhendrixMSFT merged 4 commits intoAzure:mainfrom Jun 22, 2023
Merged
Azure OpenAI: Make startGenerateImage LRO internal for clients#24546jhendrixMSFT merged 4 commits intoAzure:mainfrom
jhendrixMSFT merged 4 commits intoAzure:mainfrom
Conversation
|
Hi, @trrwilson Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
Swagger Generation Artifacts
|
Generated ApiView
|
m-nash
approved these changes
Jun 22, 2023
harryli0108
pushed a commit
to harryli0108/azure-rest-api-specs
that referenced
this pull request
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a
client.tsplayer for Azure OpenAI's TypeSpec code generation basis and adds an@internaldecorator to make its new image generation long-running operation separate from the public surface.Image generation is not a long-running operation on non-Azure OpenAI and there's limited utility in having a divergent representation that exposes operation polling; this is principally an implementation detail of how Azure achieves the same result.