Merged
Conversation
added 2 commits
May 28, 2023 13:37
|
Hi, @arieschwartzman Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| healthbot.json | 2023-05-01(c7c1dfa) | 2022-08-08(main) |
| healthbot.json | 2023-05-01(c7c1dfa) | 2020-12-08-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.2) | new version | base version |
|---|---|---|
| package-2023-05-01 | package-2023-05-01(c7c1dfa) | default(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
The parameter 'subscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.HealthBot/stable/2023-05-01/healthbot.json#L935 |
|
The parameter 'apiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.HealthBot/stable/2023-05-01/healthbot.json#L942 |
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.HealthBot/stable/2023-05-01/healthbot.json#L767 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.HealthBot/stable/2023-05-01/healthbot.json#L852 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"code: InvalidResourceType, message: The resource type 'Operations' could not be found in the namespace 'Microsoft.HealthBot' for api version '2023-05-01'. The supported api-versions are '2020-12-08, 2021-06-10, 2021-08-24, 2022-08-08'." |
️❌~[Staging] ServiceAPIReadinessTest: 10 Errors, 0 Warnings failed [Detail]
Tag package-2023-05-01; Prod region: Not deployed; Canary region: Deployed
Test run on region: eastus2euap; Operation coverage: total: 9, untested: 0, failed: 8, passed: 1
Service API Readiness Test failed. Check pipeline artifact for detail report.
| Rule | Message |
|---|---|
|
statusCode: 403, errorCode: MultipleErrorsOccurred, errorMessage: Multiple error occurred: Forbidden,Forbidden. Please see details. Source: runtime OperationId: Bots_Create |
|
Additional properties not allowed: code Source: response OperationId: Bots_Create |
|
Additional properties not allowed: message Source: response OperationId: Bots_Create |
|
statusCode: 404, errorCode: InvalidResourceType, errorMessage: The resource type 'healthBots' could not be found in the namespace 'Microsoft.HealthBot' for api version '2023-05-01'. The supported api-versions are '2020-12-08,2021-06-10,2021-08-24,2022-08-08'. Source: runtime OperationId: Bots_List |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.HealthBot/healthBots/botnameyn7qou' under resource group 'apiTest-waJhti-24201' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Bots_Get |
|
statusCode: 404, errorCode: InvalidResourceType, errorMessage: The resource type 'healthBots' could not be found in the namespace 'Microsoft.HealthBot' for api version '2023-05-01'. The supported api-versions are '2020-12-08,2021-06-10,2021-08-24,2022-08-08'. Source: runtime OperationId: Bots_ListByResourceGroup |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.HealthBot/healthBots/botnameyn7qou' under resource group 'apiTest-waJhti-24201' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Bots_Update |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.HealthBot/healthBots/botnameyn7qou' under resource group 'apiTest-waJhti-24201' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Bots_ListSecrets |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.HealthBot/healthBots/botnameyn7qou' under resource group 'apiTest-waJhti-24201' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Bots_RegenerateApiJwtSecret |
|
statusCode: 404, errorCode: InvalidResourceType, errorMessage: The resource type 'Operations' could not be found in the namespace 'Microsoft.HealthBot' for api version '2023-05-01'. The supported api-versions are '2020-12-08,2021-06-10,2021-08-24,2022-08-08'. Source: runtime OperationId: Operations_List |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @arieschwartzman your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Swagger Generation Artifacts
|
Generated ApiView
|
|
Hi @arieschwartzman, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hi, @arieschwartzman, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
AzureRestAPISpecReview
added
ReadyForApiTest
visingla-ms
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
Contributor
Author
|
@Wzb123456789 Hi. There are some Checks that failed. Is this blocking my PR? |
Contributor
|
@guy-microsoft Please check this PR so that I can check bugs with the SDK owner. |
Contributor
|
@Wzb123456789 This looks good to me. Please proceed. |
Contributor
Author
|
Hi @Wzb123456789 can you proceed to approve? |
Wzb123456789
approved these changes
Jun 5, 2023
raych1
added
the
Approved-SdkBreakingChange-Go
qiaozha
reviewed
Jun 5, 2023
specification/healthbot/resource-manager/Microsoft.HealthBot/stable/2023-05-01/healthbot.json
Show resolved
Hide resolved
qiaozha
reviewed
Jun 5, 2023
...bot/resource-manager/Microsoft.HealthBot/stable/2023-05-01/examples/ResourceUpdatePatch.json
Show resolved
Hide resolved
Contributor
Author
|
@raych1. Should I be able to merge the PR? It seems that I don't have authorization to merge. |
Contributor
Author
|
@Wzb123456789 Can you help me with merging? |
Member
@arieschwartzman , can you resolve the comment from @qiaozha ? |
Contributor
Author
|
@raych1. Comments resolved |
This was referenced Jun 9, 2023
harryli0108
pushed a commit
to harryli0108/azure-rest-api-specs
that referenced
this pull request
Jul 28, 2023
* create new api version * Add PES SKU name * update examples api-version versions reference * fix api version * Fix default version * add 201 response header example * fix example --------- Co-authored-by: Arie Schwartzman <ariesch.microsoft.com> Co-authored-by: Arie Schwartzman <ariesch@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.