[TypeSpec] Remove "./" from tspconfig.yaml by mikeharder · Pull Request #24199 · Azure/azure-rest-api-specs

mikeharder · 2023-05-26T23:37:03Z

Prefix is unnecessary and clutters config
Fixes [TypeSpec] Remove leading "./" from tspconfig.yaml values #24196

Passing CI: https://dev.azure.com/azure-sdk/public/_build/results?buildId=2805265&view=results

- Prefix is unnecessary and clutters config

openapi-pipeline-app · 2023-05-26T23:37:07Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2023-05-26T23:37:07Z

Hi, @mikeharder Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-05-26T23:37:07Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-python failed [Detail]

❌Code Generator Failed [Logs]Release - Generate from 9136b7a. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
warn		specification/cognitiveservices/HealthInsights/healthinsights.openapi/tspconfig.yaml skipped due to azure-sdk-for-python not found in tspconfig.yaml
warn		specification/servicenetworking/ServiceNetworking.Management/tspconfig.yaml skipped due to azure-sdk-for-python not found in tspconfig.yaml
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.7` to update!
cmderr	[automation_generate.sh] npm notice
cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️❌ azure-sdk-for-java failed [Detail]

❌Failed [Logs]Release - Generate from 9136b7a. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] npm notice
cmderr	[generate.py] npm notice New major version of npm available! 8.19.4 -> 9.6.7
cmderr	[generate.py] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
cmderr	[generate.py] npm notice Run `npm install -g npm@9.6.7` to update!
cmderr	[generate.py] npm notice
warn	No file changes detected after generation

❌azure-ai-anomalydetector [View full logs]
- pom.xml
️✔️azure-contoso-widgetmanager [View full logs] [Release SDK Changes]
️✔️azure-ai-translation-text [View full logs] [Release SDK Changes]

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 9136b7a. SDK Automation 14.0.0

Only show 24 items here, please refer to log for details.

cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:145
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 145 | �[0m         �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:145
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 145 | �[0m         �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:145
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 145 | �[0m         �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/template is already installed.
cmderr	[Invoke-GenerateAndBuildV2.ps1] To reinstall the same version of the template package, use '--force' option:
cmderr	[Invoke-GenerateAndBuildV2.ps1]    dotnet new install /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/template --force
cmderr	[Invoke-GenerateAndBuildV2.ps1] For details on the exit code, refer to https://aka.ms/templating-exit-codes#106

❌Azure.AI.AnomalyDetector [View full logs] [Release SDK Changes]
```
info	[Changelog]
```
️✔️Azure.AI.ContentSafety [View full logs] [Release SDK Changes]
- Azure.AI.ContentSafety.1.0.0-alpha.20230602.1.nupkg
```
info	[Changelog]
```
❌Azure.Contoso.WidgetManager [View full logs] [Release SDK Changes]
```
info	[Changelog]
```
️✔️Azure.Messaging.EventGrid.Namespaces [View full logs] [Release SDK Changes]
- Azure.Messaging.EventGrid.Namespaces.1.0.0-alpha.20230602.1.nupkg
```
info	[Changelog]
```
️✔️Azure.AI.Translation.Text [View full logs] [Release SDK Changes]
- Azure.AI.Translation.Text.1.0.0-alpha.20230602.1.nupkg
```
info	[Changelog]
```

️❌ azure-sdk-for-js failed [Detail]

❌Code Generator Failed [Logs]Release - Generate from 9136b7a. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Command failed: npx tsp compile client.tsp --emit @azure-tools/typespec-ts --arg "js-sdk-folder=/mnt/vss/_work/1/s/azure-sdk-for-js"
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-js]: sh .scripts/automation_generate.sh
warn	Skip package processing as generation is failed
warn		specification/cognitiveservices/ContentSafety/tspconfig.yaml skipped due to azure-sdk-for-js not found in tspconfig.yaml
warn		specification/cognitiveservices/HealthInsights/healthinsights.openapi/tspconfig.yaml skipped due to azure-sdk-for-js not found in tspconfig.yaml
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure-rest/contoso-widgetmanager-rest [View full logs] [Release SDK Changes]
- azure-rest-contoso-widgetmanager-rest-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```
️✔️@azure-rest/ai-translation-text [View full logs] [Release SDK Changes]
- azure-rest-ai-translation-text-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-26T23:37:08Z

Generated ApiView

Language	Package Name	ApiView Link
Java	azure-ai-translation-text	https://apiview.dev/Assemblies/Review/8f978c11e33d4ffcacaeef4abf5a66f9
Java	azure-contoso-widgetmanager	https://apiview.dev/Assemblies/Review/88b07ca21e154c1584d5abf73dd5c552
JavaScript	@azure-rest/ai-translation-text	https://apiview.dev/Assemblies/Review/ffcad99b217841ac979d13bbb8df6b8b
JavaScript	@azure-rest/contoso-widgetmanager-rest	https://apiview.dev/Assemblies/Review/4205bec7e74043ec8ecafe7e9c9cd0ec
.Net	Azure.AI.ContentSafety	There is no API change compared with the previous version
.Net	Azure.AI.Translation.Text	There is no API change compared with the previous version
.Net	Azure.Messaging.EventGrid.Namespaces	https://apiview.dev/Assemblies/Review/f43fa4d018114fd5b8e217223529cca0

v-xuto · 2023-05-29T03:11:45Z

Generated ApiView

Language Package Name ApiView Link
Java azure-ai-translation-text Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java azure-contoso-widgetmanager Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
.Net Azure.AI.Translation.Text Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript @azure-rest/ai-translation-text Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript @azure-rest/contoso-widgetmanager-rest Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

@mikeharder The ApiView link generation failed, please ensure your github account in Azure/Microsoft is public.

mikeharder · 2023-05-30T20:42:22Z

/azp run

azure-pipelines · 2023-05-30T20:42:32Z

Azure Pipelines successfully started running 1 pipeline(s).

weshaggard · 2023-05-30T21:22:43Z

specification/cognitiveservices/AnomalyDetector/tspconfig.yaml

  "@azure-tools/typespec-autorest":
-    azure-resource-provider-folder: "./data-plane"
+    azure-resource-provider-folder: "data-plane"
    examples-directory: ./examples


one more case here to remove ./

v-xuto · 2023-05-31T03:20:28Z

@qiaozha Please help review azure-sdk-for-js error.
@raych1 Please help review azure-sdk-for-go error.
@msyyc Please help review azure-sdk-for-python error.
@live1206 Please help review azure-sdk-for-net-track2 error.

raych1 · 2023-06-01T06:22:40Z

@v-xuto , GO isn't enabled for typespec DPG.

JS and python failed for same reason and isn't related to this PR change.

[automation_generate.sh] /mnt/vss/_work/1/s/azure-rest-api-specs/specification/cognitiveservices/AnomalyDetector/client.tsp:6:17 - error invalid-ref: Namespace AnomalyDetector.Univariate doesn't have member DetectUnivariateEntireSeries
08:49:00.522 cmdout 	[automation_generate.sh] > 6 | @@convenientAPI(AnomalyDetector.Univariate.DetectUnivariateEntireSeries, false)
08:49:00.522 cmdout 	[automation_generate.sh]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
08:49:00.522 cmdout 	[automation_generate.sh] Found 1 error, 4 warnings.
08:49:00.538 cmdout 	[automation_generate.sh] Traceback (most recent call last):
08:49:00.538 cmdout 	[automation_generate.sh]   File "/opt/hostedtoolcache/Python/3.10.11/x64/lib/python3.10/runpy.py", line 196, in _run_module_as_main

- Prefix is unnecessary and clutters config

[TypeSpec] Remove "./" from tspconfig.yaml

cf86d90

- Prefix is unnecessary and clutters config

mikeharder requested a review from yangyuan as a code owner May 26, 2023 23:37

openapi-assignment-bot bot assigned v-xuto May 26, 2023

ghost added the Cognitive Services label May 26, 2023

mikeharder requested review from markcowl, timotheeguerin and weshaggard May 26, 2023 23:37

weshaggard reviewed May 30, 2023

View reviewed changes

weshaggard approved these changes May 30, 2023

View reviewed changes

v-xuto self-requested a review June 1, 2023 06:26

v-xuto approved these changes Jun 1, 2023

View reviewed changes

v-xuto added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 1, 2023

Remove more "./"

5584f8e

mikeharder requested a review from Kishp01 as a code owner June 1, 2023 06:32

mikeharder requested a review from ahamad-MS as a code owner June 1, 2023 06:32

openapi-workflow-bot bot added commitAfterSignedOff and removed Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates labels Jun 1, 2023

Remove more "./"

30c109d

This was referenced Jun 1, 2023

[AutoPR Azure.AI.ContentSafety] [TypeSpec] Remove "./" from tspconfig.yaml azure-sdk/azure-sdk-for-net#4045

Closed

[AutoPR Azure.Messaging.EventGrid.Namespaces] [TypeSpec] Remove "./" from tspconfig.yaml azure-sdk/azure-sdk-for-net#4046

Closed

mikeharder merged commit 9136b7a into Azure:main Jun 2, 2023

mikeharder deleted the tspconfig-cleanup branch June 2, 2023 01:12

harryli0108 pushed a commit to harryli0108/azure-rest-api-specs that referenced this pull request Jul 28, 2023

[TypeSpec] Remove "./" from tspconfig.yaml (Azure#24199)

838efc6

- Prefix is unnecessary and clutters config

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TypeSpec] Remove "./" from tspconfig.yaml#24199

[TypeSpec] Remove "./" from tspconfig.yaml#24199
mikeharder merged 3 commits intoAzure:mainfrom
mikeharder:tspconfig-cleanup

mikeharder commented May 26, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented May 26, 2023 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented May 26, 2023

Uh oh!

openapi-pipeline-app bot commented May 26, 2023 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented May 26, 2023 •

edited

Loading

Uh oh!

v-xuto commented May 29, 2023

Generated ApiView

Uh oh!

mikeharder commented May 30, 2023

Uh oh!

azure-pipelines bot commented May 30, 2023

Uh oh!

weshaggard May 30, 2023

Uh oh!

v-xuto commented May 31, 2023

Uh oh!

raych1 commented Jun 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mikeharder commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openapi-pipeline-app bot commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-workflow-bot bot commented May 26, 2023

Uh oh!

openapi-pipeline-app bot commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

v-xuto commented May 29, 2023

Generated ApiView

Uh oh!

mikeharder commented May 30, 2023

Uh oh!

azure-pipelines bot commented May 30, 2023

Uh oh!

weshaggard May 30, 2023

Choose a reason for hiding this comment

Uh oh!

v-xuto commented May 31, 2023

Uh oh!

raych1 commented Jun 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mikeharder commented May 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 26, 2023 •

edited

Loading