Sentinel - SourceControls 2023-06-01-preview by oformaniuk · Pull Request #24151 · Azure/azure-rest-api-specs

oformaniuk · 2023-05-24T21:04:35Z

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
Service changes are ready and can be deployed as soon as Swagger changes are approved.
When do you expect to publish the swagger? Please provide date or, the date is not yet available, the month.
2023-06-01
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2023-05-24T21:04:38Z

Hi, @zjklee Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-05-24T21:04:39Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️Breaking Change(Cross-Version): 22 Warnings warning [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
SourceControls.json	2023-06-01-preview(0c353f1)	2023-05-01-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1019 - RemovedEnumValue	The new version is removing enum value(s) 'DevOps' from the old version. Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L49:9
⚠️ 1019 - RemovedEnumValue	The new version is removing enum value(s) 'DevOps' from the old version. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L380:9 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L374:9
⚠️ 1019 - RemovedEnumValue	The new version is removing enum value(s) 'DevOps' from the old version. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L673:5 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L588:5
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L549:9 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L470:9
⚠️ 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L472:7 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L410:7
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L362:9 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L357:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L367:9 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L361:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L485:9 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L423:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L539:9 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L462:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L544:9 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L466:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L549:9 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L470:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L523:9 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L446:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L528:9 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L451:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L412:9 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L394:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L561:5 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L480:5
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L572:5 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L490:5
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L587:5 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L504:5
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L717:5 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L608:5
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'pathMapping' renamed or removed? New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L472:7 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L410:7
⚠️ 1034 - AddedRequiredProperty	The new version has new required property 'url, branch' that was not found in the old version. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L392:9 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L386:9
⚠️ 1034 - AddedRequiredProperty	The new version has new required property 'url, branch' that was not found in the old version. New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L465:5 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L407:5
⚠️ 1035 - RemovedOperation	The new version is missing an operation that was found in the old version. Was operationId 'SourceControls_Delete' removed or restructured? New: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L130:5 Old: Microsoft.SecurityInsights/preview/2023-05-01-preview/SourceControls.json#L130:5

️⚠️LintDiff: 1 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.2)	new version	base version
package-preview-2023-06	package-preview-2023-06(0c353f1)	package-preview-2023-06(release-Sentinel-2023-06-01-preview)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ AllProxyResourcesShouldHaveDelete	The resource SourceControl does not have a corresponding delete operation. Location: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L343	RPC-Delete-V1-05

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ ListInOperationName	Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L38
⚠️ OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'SourceControlModel'. Consider using the plural form of 'SourceControl' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L48
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json#L555

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-24T21:04:39Z

Swagger Generation Artifacts

️🔄ApiDocPreview inProgress [Detail]

️⚠️SDK Breaking Change Tracking warning [Detail]

Breaking Changes Tracking

⚠️azure-sdk-for-js - @azure/arm-securityinsight - 1.0.0-beta.7

+	Enum KnownRepoType no longer has value DevOps
+	Interface MstiDataConnectorDataTypes no longer has parameter bingSafetyPhishingURL
+	Interface Repository no longer has parameter pathMapping
+	Operation Incidents.createTeam has a new signature
+	Parameter branch of interface Repository is now required
+	Parameter logicAppResourceId of interface PlaybookActionProperties is now required
+	Parameter url of interface Repository is now required
+	Removed Enum KnownEntityKind
+	Removed Enum KnownEnum13
+	Removed Enum KnownThreatIntelligenceResourceKindEnum
+	Removed Enum KnownThreatIntelligenceSortingCriteriaEnum
+	Type of parameter additionalData of interface AccountEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface AzureResourceEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface CloudApplicationEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface DnsEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface EntityCommonProperties is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface EntityEdges is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface FileEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface FileHashEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface HostEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface HuntingBookmark is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface IoTDeviceEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface IpEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MailClusterEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MailMessageEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MailboxEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MalwareEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface NicEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface ProcessEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface RegistryKeyEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface RegistryValueEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface SecurityAlert is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface SecurityGroupEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface SubmissionMailEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface ThreatIntelligenceIndicatorModel is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface UrlEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter dependencies of interface MetadataModel is changed from MetadataDependencies to MetadataDependenciesAutoGenerated
+	Type of parameter dependencies of interface MetadataPatch is changed from MetadataDependencies to MetadataDependenciesAutoGenerated
+	Type of parameter entityKind of interface ExpansionResultAggregation is changed from EntityKind to EntityKindEnum
+	Type of parameter entityKind of interface IncidentEntitiesResultsMetadata is changed from EntityKind to EntityKindEnum
+	Type of parameter kind of interface Entity is changed from EntityKind to EntityKindEnum
+	Type of parameter kind of interface EntityQueriesListOptionalParams is changed from Enum13 to Enum20
+	Type of parameter kind of interface MetadataModel is changed from Kind to string
+	Type of parameter kind of interface MetadataPatch is changed from Kind to string
+	Type of parameter kind of interface ThreatIntelligenceInformation is changed from ThreatIntelligenceResourceKindEnum to ThreatIntelligenceResourceInnerKind
+	Type of parameter sortOrder of interface ThreatIntelligenceSortingCriteria is changed from ThreatIntelligenceSortingCriteriaEnum to ThreatIntelligenceSortingOrder

⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-securityinsight - 2.0.0b2

+	Model MSTIDataConnectorDataTypes no longer has parameter bing_safety_phishing_url
+	Model Repository no longer has parameter path_mapping
+	Parameter branch of model Repository is now required
+	Parameter logic_app_resource_id of model PlaybookActionProperties is now required
+	Parameter url of model Repository is now required

️⌛ azure-sdk-for-net-track2 pending [Detail]

️⌛ azure-sdk-for-python-track2 pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2023-05-24T21:04:40Z

Hi, @zjklee your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

openapi-pipeline-app · 2023-05-24T21:04:40Z

Generated ApiView

Language	Package Name	ApiView Link
Java	azure-resourcemanager-securityinsights	https://apiview.dev/Assemblies/Review/eea85be7a0934c1d95dfc914801e0978
.Net	Azure.ResourceManager.SecurityInsights	https://apiview.dev/Assemblies/Review/a61067311fba435f8615a33fae442cb4
JavaScript	@azure/arm-securityinsight	https://apiview.dev/Assemblies/Review/5d0d7a70bd1045f3bfefdebb078edb7b

openapi-workflow-bot · 2023-05-24T21:11:53Z

Hi @zjklee, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

...s/resource-manager/Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json

openapi-pipeline-app · 2023-05-24T23:24:18Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️⚠️SDK Breaking Change Tracking warning [Detail]

Breaking Changes Tracking

⚠️azure-sdk-for-js - @azure/arm-securityinsight - Approved - 1.0.0-beta.7

+	Enum KnownRepoType no longer has value DevOps
+	Interface MstiDataConnectorDataTypes no longer has parameter bingSafetyPhishingURL
+	Interface Repository no longer has parameter pathMapping
+	Operation Incidents.createTeam has a new signature
+	Operation SourceControls.delete has a new signature
+	Parameter branch of interface Repository is now required
+	Parameter logicAppResourceId of interface PlaybookActionProperties is now required
+	Parameter url of interface Repository is now required
+	Removed Enum KnownEntityKind
+	Removed Enum KnownEnum13
+	Removed Enum KnownThreatIntelligenceResourceKindEnum
+	Removed Enum KnownThreatIntelligenceSortingCriteriaEnum
+	Type of parameter additionalData of interface AccountEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface AzureResourceEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface CloudApplicationEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface DnsEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface EntityCommonProperties is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface EntityEdges is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface FileEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface FileHashEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface HostEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface HuntingBookmark is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface IoTDeviceEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface IpEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MailClusterEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MailMessageEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MailboxEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MalwareEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface NicEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface ProcessEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface RegistryKeyEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface RegistryValueEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface SecurityAlert is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface SecurityGroupEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface SubmissionMailEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface ThreatIntelligenceIndicatorModel is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface UrlEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter dependencies of interface MetadataModel is changed from MetadataDependencies to MetadataDependenciesAutoGenerated
+	Type of parameter dependencies of interface MetadataPatch is changed from MetadataDependencies to MetadataDependenciesAutoGenerated
+	Type of parameter entityKind of interface ExpansionResultAggregation is changed from EntityKind to EntityKindEnum
+	Type of parameter entityKind of interface IncidentEntitiesResultsMetadata is changed from EntityKind to EntityKindEnum
+	Type of parameter kind of interface Entity is changed from EntityKind to EntityKindEnum
+	Type of parameter kind of interface EntityQueriesListOptionalParams is changed from Enum13 to Enum20
+	Type of parameter kind of interface MetadataModel is changed from Kind to string
+	Type of parameter kind of interface MetadataPatch is changed from Kind to string
+	Type of parameter kind of interface ThreatIntelligenceInformation is changed from ThreatIntelligenceResourceKindEnum to ThreatIntelligenceResourceInnerKind
+	Type of parameter sortOrder of interface ThreatIntelligenceSortingCriteria is changed from ThreatIntelligenceSortingCriteriaEnum to ThreatIntelligenceSortingOrder
+	Type of parameter webhookSecretUpdateTime of interface Webhook is changed from string to Date

⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-securityinsight - Approved - 2.0.0b2

+	Model MSTIDataConnectorDataTypes no longer has parameter bing_safety_phishing_url
+	Model Repository no longer has parameter path_mapping
+	Operation SourceControlsOperations.delete has a new required parameter repository_access
+	Parameter branch of model Repository is now required
+	Parameter logic_app_resource_id of model PlaybookActionProperties is now required
+	Parameter url of model Repository is now required

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 3f207a723dc2ce13b39b0d17b73f1cc95065f26f. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.SecurityInsights [View full logs] [Preview SDK Changes]
- Azure.ResourceManager.SecurityInsights.1.1.0-alpha.20230529.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 3f207a723dc2ce13b39b0d17b73f1cc95065f26f. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-securityinsight [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation EntitiesOperations.run_playbook
info	[Changelog]   - Added operation group AlertRuleOperations
info	[Changelog]   - Added operation group BillingStatisticsOperations
info	[Changelog]   - Added operation group ContentPackageOperations
info	[Changelog]   - Added operation group ContentPackagesOperations
info	[Changelog]   - Added operation group ContentTemplateOperations
info	[Changelog]   - Added operation group ContentTemplatesOperations
info	[Changelog]   - Added operation group GetTriggeredAnalyticsRuleRunsOperations
info	[Changelog]   - Added operation group HuntCommentsOperations
info	[Changelog]   - Added operation group HuntRelationsOperations
info	[Changelog]   - Added operation group HuntsOperations
info	[Changelog]   - Added operation group ProductPackageOperations
info	[Changelog]   - Added operation group ProductPackagesOperations
info	[Changelog]   - Added operation group ProductTemplateOperations
info	[Changelog]   - Added operation group ProductTemplatesOperations
info	[Changelog]   - Added operation group TriggeredAnalyticsRuleRunOperations
info	[Changelog]   - Added operation group WorkspaceManagerAssignmentJobsOperations
info	[Changelog]   - Added operation group WorkspaceManagerAssignmentsOperations
info	[Changelog]   - Added operation group WorkspaceManagerConfigurationsOperations
info	[Changelog]   - Added operation group WorkspaceManagerGroupsOperations
info	[Changelog]   - Added operation group WorkspaceManagerMembersOperations
info	[Changelog]   - Model MTPDataConnector has a new parameter filtered_providers
info	[Changelog]   - Model MTPDataConnectorDataTypes has a new parameter alerts
info	[Changelog]   - Model MTPDataConnectorProperties has a new parameter filtered_providers
info	[Changelog]   - Model SourceControl has a new parameter pull_request
info	[Changelog]   - Model SourceControl has a new parameter repository_access
info	[Changelog]   - Model SourceControl has a new parameter service_principal
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model MSTIDataConnectorDataTypes no longer has parameter bing_safety_phishing_url
info	[Changelog]   - Model Repository no longer has parameter path_mapping
info	[Changelog]   - Operation SourceControlsOperations.delete has a new required parameter repository_access
info	[Changelog]   - Parameter branch of model Repository is now required
info	[Changelog]   - Parameter logic_app_resource_id of model PlaybookActionProperties is now required
info	[Changelog]   - Parameter url of model Repository is now required

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 3f207a723dc2ce13b39b0d17b73f1cc95065f26f. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-securityinsight [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-securityinsight-1.0.0-beta.7.tgz

Only show 120 items here, please refer to log for details.

info	[Changelog]   - Type of parameter additionalData of interface EntityCommonProperties is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface EntityEdges is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter kind of interface EntityQueriesListOptionalParams is changed from Enum13 to Enum20
info	[Changelog]   - Type of parameter entityKind of interface ExpansionResultAggregation is changed from EntityKind to EntityKindEnum
info	[Changelog]   - Type of parameter additionalData of interface FileEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface FileHashEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface HostEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface HuntingBookmark is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter entityKind of interface IncidentEntitiesResultsMetadata is changed from EntityKind to EntityKindEnum
info	[Changelog]   - Type of parameter additionalData of interface IoTDeviceEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface IpEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface MailboxEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface MailClusterEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface MailMessageEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface MalwareEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter dependencies of interface MetadataModel is changed from MetadataDependencies to MetadataDependenciesAutoGenerated
info	[Changelog]   - Type of parameter kind of interface MetadataModel is changed from Kind to string
info	[Changelog]   - Type of parameter dependencies of interface MetadataPatch is changed from MetadataDependencies to MetadataDependenciesAutoGenerated
info	[Changelog]   - Type of parameter kind of interface MetadataPatch is changed from Kind to string
info	[Changelog]   - Type of parameter additionalData of interface NicEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface ProcessEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface RegistryKeyEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface RegistryValueEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface SecurityAlert is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface SecurityGroupEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface SubmissionMailEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter additionalData of interface ThreatIntelligenceIndicatorModel is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter kind of interface ThreatIntelligenceInformation is changed from ThreatIntelligenceResourceKindEnum to ThreatIntelligenceResourceInnerKind
info	[Changelog]   - Type of parameter sortOrder of interface ThreatIntelligenceSortingCriteria is changed from ThreatIntelligenceSortingCriteriaEnum to ThreatIntelligenceSortingOrder
info	[Changelog]   - Type of parameter additionalData of interface UrlEntity is changed from {
info	[Changelog]         [propertyName: string]: Record<string, unknown>;
info	[Changelog]     } to {
info	[Changelog]         [propertyName: string]: any;
info	[Changelog]     }
info	[Changelog]   - Type of parameter webhookSecretUpdateTime of interface Webhook is changed from string to Date
info	[Changelog]   - Removed Enum KnownEntityKind
info	[Changelog]   - Removed Enum KnownEnum13
info	[Changelog]   - Removed Enum KnownThreatIntelligenceResourceKindEnum
info	[Changelog]   - Removed Enum KnownThreatIntelligenceSortingCriteriaEnum
info	[Changelog]   - Enum KnownRepoType no longer has value DevOps

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 3f207a723dc2ce13b39b0d17b73f1cc95065f26f. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-securityinsights [View full logs] [Preview SDK Changes]

️❌ azure-resource-manager-schemas failed [Detail]

❌Failed [Logs] Generate from 3f207a723dc2ce13b39b0d17b73f1cc95065f26f. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

❌securityinsights/resource-manager [View full logs]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 3f207a723dc2ce13b39b0d17b73f1cc95065f26f. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

❌Az.securityinsights.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.securityinsights.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

...s/resource-manager/Microsoft.SecurityInsights/preview/2023-06-01-preview/SourceControls.json

ankhyk · 2023-06-01T04:48:18Z

@qiaozha please review the JS breaking change
@msyyc please review the Python breaking change

oformaniuk · 2023-06-05T17:18:06Z

@qiaozha, can you please have a look?

oformaniuk · 2023-06-07T17:12:29Z

@keryul , can it be merged now?

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-05-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * Sentinel - SourceControls 2023-06-01-preview (#24151) Co-authored-by: Oleh Formaniuk <oformaniuk@microsoft.com> * Fix creds scan error, remove real object id from sample file. (#24410) --------- Co-authored-by: Oleh Formaniuk <zjklee@gmail.com> Co-authored-by: Oleh Formaniuk <oformaniuk@microsoft.com>

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-05-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * Sentinel - SourceControls 2023-06-01-preview (Azure#24151) Co-authored-by: Oleh Formaniuk <oformaniuk@microsoft.com> * Fix creds scan error, remove real object id from sample file. (Azure#24410) --------- Co-authored-by: Oleh Formaniuk <zjklee@gmail.com> Co-authored-by: Oleh Formaniuk <oformaniuk@microsoft.com>

SourceControls 2023-06-01-preview

691a088

openapi-assignment-bot bot assigned ankhyk May 24, 2023

openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 24, 2023

AzureRestAPISpecReview added CI-FixRequiredOnFailure resource-manager labels May 24, 2023

openapi-pipeline-app bot added CI-BreakingChange-JavaScript CI-BreakingChange-Python-Track2 labels May 24, 2023

Fix linter complains

4c0f20e

azure-sdk mentioned this pull request May 24, 2023

[AutoPR azure-resourcemanager-securityinsights] Sentinel - SourceControls 2023-06-01-preview azure-sdk/azure-sdk-for-java#5590

Closed