Align Microsoft.ServiceNetworking with repo conventions#24060
Closed
mikeharder wants to merge 5 commits intoAzure:mainfrom
Closed
Align Microsoft.ServiceNetworking with repo conventions#24060mikeharder wants to merge 5 commits intoAzure:mainfrom
mikeharder wants to merge 5 commits intoAzure:mainfrom
Conversation
|
Hi, @mikeharder Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Generation Artifacts
|
Generated ApiView
|
mikeharder
changed the title
weshaggard
reviewed
May 19, 2023
eng/pipelines/typespec-ci.yml
Outdated
|
|
||
| - template: templates/steps/typespec-ci.yml | ||
| parameters: | ||
| Folder: specification/servicenetworking/resource-manager/Microsoft.ServiceNetworking/cadl |
Member
There was a problem hiding this comment.
We need to get the "cadl" name out of the folder structure when as we fix this project.
Member
Author
|
@markcowl: I gave this my best shot, but I'm stuck at this point. I think the next issue to fix is the examples: There may be more issues, for example the Feel free to push changes to this PR, or create a new PR if you prefer. |
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @mikeharder, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Member
Author
|
Closing in favor of #24082 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.