Skip to content

Adding put and delete BMI operations to baremetalinfrastructure.json spec#24059

Closed
8Gitbrix wants to merge 9 commits intomainfrom
8Gitbrix-baremetalinfrastructure-Microsoft.BareMetalInfrastructure-2023-04-06
Closed

Adding put and delete BMI operations to baremetalinfrastructure.json spec#24059
8Gitbrix wants to merge 9 commits intomainfrom
8Gitbrix-baremetalinfrastructure-Microsoft.BareMetalInfrastructure-2023-04-06

Conversation

@8Gitbrix
Copy link
Copy Markdown
Member

@8Gitbrix 8Gitbrix commented May 18, 2023

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link
Copy Markdown

Hi, @8Gitbrix Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented May 18, 2023

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    baremetalinfrastructure.json 2023-04-06(07d4d97) 2023-04-06(main)
    Rule Message
    1039 - AddedOperation The new version is adding an operation that was not found in the old version.
    New: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L201:7
    1039 - AddedOperation The new version is adding an operation that was not found in the old version.
    New: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L240:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌LintDiff: 7 Errors, 1 Warnings failed [Detail]
    compared tags (via openapi-validator v2.1.3) new version base version
    package-2023-04-06 package-2023-04-06(07d4d97) package-2023-04-06(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    PutGetPatchResponseSchema /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BareMetalInfrastructure/bareMetalInstances/{azureBareMetalInstanceName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L159
    RPC-Put-V1-12
    DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L227
    RPC-Delete-V1-01
    ValidResponseCodeRequired There is no declared valid status code.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L227
    NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L228
    PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L275
    RPC-Put-V1-11
    ValidResponseCodeRequired There is no declared valid status code.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L275
    NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L276
    ⚠️ PutInOperationName 'PUT' operation 'AzureBareMetalInstances_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L244


    The following errors/warnings exist before current PR submission:

    Rule Message
    OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L144
    ResourceNameRestriction The resource name parameter 'azureBareMetalInstanceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L159
    MissingTypeObject The schema 'AzureBareMetalInstancesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L603
    MissingTypeObject The schema 'AzureBareMetalInstance' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L619
    TrackedResourcesMustHavePut The tracked resource AzureBareMetalInstance does not have a corresponding put operation.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L619
    MissingTypeObject The schema 'AzureBareMetalInstanceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L639
    ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L693
    MissingTypeObject The schema 'HardwareProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L714
    MissingTypeObject The schema 'Disk' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L786
    MissingTypeObject The schema 'StorageProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L806
    MissingTypeObject The schema 'OSProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L826
    MissingTypeObject The schema 'NetworkProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L849
    MissingTypeObject The schema 'IpAddress' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L869
    MissingTypeObject The schema 'Result' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L914
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.BareMetalInfrastructure/stable/2023-04-06/baremetalinfrastructure.json#L906
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented May 18, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/baremetalinfrastructure/armbaremetalinfrastructure - Approved - 2.0.0
    +	Struct `ErrorDefinition` has been removed
    +	Type of `ErrorResponse.Error` has been changed from `*ErrorDefinition` to `*ErrorDetail`

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 65d16c33d9aeda7a9a769a56dc44e1807775270f. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh]  New minor version of npm available! 9.5.1 -> 9.8.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.8.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-baremetalinfrastructure [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation AzureBareMetalInstancesOperations.delete
      info	[Changelog]   - Added operation AzureBareMetalInstancesOperations.put
      info	[Changelog]   - Added operation group AzureBareMetalStorageInstancesOperations
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 65d16c33d9aeda7a9a769a56dc44e1807775270f. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/baremetalinfrastructure/armbaremetalinfrastructure [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `ErrorResponse.Error` has been changed from `*ErrorDefinition` to `*ErrorDetail`
      info	[Changelog] - Struct `ErrorDefinition` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `ProvisioningState` with values `ProvisioningStateAccepted`, `ProvisioningStateCanceled`, `ProvisioningStateCreating`, `ProvisioningStateDeleting`, `ProvisioningStateFailed`, `ProvisioningStateMigrating`, `ProvisioningStateSucceeded`, `ProvisioningStateUpdating`
      info	[Changelog] - New function `*AzureBareMetalInstancesClient.Delete(context.Context, string, string, *AzureBareMetalInstancesClientDeleteOptions) (AzureBareMetalInstancesClientDeleteResponse, error)`
      info	[Changelog] - New function `*AzureBareMetalInstancesClient.Put(context.Context, string, string, *AzureBareMetalInstancesClientPutOptions) (AzureBareMetalInstancesClientPutResponse, error)`
      info	[Changelog] - New function `NewAzureBareMetalStorageInstancesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AzureBareMetalStorageInstancesClient, error)`
      info	[Changelog] - New function `*AzureBareMetalStorageInstancesClient.Create(context.Context, string, string, AzureBareMetalStorageInstance, *AzureBareMetalStorageInstancesClientCreateOptions) (AzureBareMetalStorageInstancesClientCreateResponse, error)`
      info	[Changelog] - New function `*AzureBareMetalStorageInstancesClient.Delete(context.Context, string, string, *AzureBareMetalStorageInstancesClientDeleteOptions) (AzureBareMetalStorageInstancesClientDeleteResponse, error)`
      info	[Changelog] - New function `*AzureBareMetalStorageInstancesClient.Get(context.Context, string, string, *AzureBareMetalStorageInstancesClientGetOptions) (AzureBareMetalStorageInstancesClientGetResponse, error)`
      info	[Changelog] - New function `*AzureBareMetalStorageInstancesClient.NewListByResourceGroupPager(string, *AzureBareMetalStorageInstancesClientListByResourceGroupOptions) *runtime.Pager[AzureBareMetalStorageInstancesClientListByResourceGroupResponse]`
      info	[Changelog] - New function `*AzureBareMetalStorageInstancesClient.NewListBySubscriptionPager(*AzureBareMetalStorageInstancesClientListBySubscriptionOptions) *runtime.Pager[AzureBareMetalStorageInstancesClientListBySubscriptionResponse]`
      info	[Changelog] - New function `*AzureBareMetalStorageInstancesClient.Update(context.Context, string, string, Tags, *AzureBareMetalStorageInstancesClientUpdateOptions) (AzureBareMetalStorageInstancesClientUpdateResponse, error)`
      info	[Changelog] - New function `*ClientFactory.NewAzureBareMetalStorageInstancesClient() *AzureBareMetalStorageInstancesClient`
      info	[Changelog] - New struct `AzureBareMetalStorageInstance`
      info	[Changelog] - New struct `AzureBareMetalStorageInstanceProperties`
      info	[Changelog] - New struct `AzureBareMetalStorageInstancesListResult`
      info	[Changelog] - New struct `ErrorAdditionalInfo`
      info	[Changelog] - New struct `ErrorDetail`
      info	[Changelog] - New struct `StorageBillingProperties`
      info	[Changelog] - New struct `StorageProperties`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 33 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 65d16c33d9aeda7a9a769a56dc44e1807775270f. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-baremetalinfrastructure [View full logs]  [Preview SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from 65d16c33d9aeda7a9a769a56dc44e1807775270f. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.baremetalinfrastructure.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.baremetalinfrastructure.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented May 18, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Swagger Microsoft.BareMetalInfrastructure https://apiview.dev/Assemblies/Review/a55c04c7ea76478db3e59d36cd15ab31
    Go sdk/resourcemanager/baremetalinfrastructure/armbaremetalinfrastructure https://apiview.dev/Assemblies/Review/5da4fe718c204153bc09031edefc6113
    Java azure-resourcemanager-baremetalinfrastructure https://apiview.dev/Assemblies/Review/8c9c791b0da945df9ce488d2c4e275a7
    JavaScript @azure/arm-baremetalinfrastructure https://apiview.dev/Assemblies/Review/0a0c6d5e1c6e4a7ca295f92d165bbba1

    @dsmith111
    Copy link
    Copy Markdown
    Member

    dsmith111 commented May 18, 2023

    As a note, our RP does not support PUT or DELETE operations. However, as a requirement for GA, we need to return a response for them. The ARM team originally gave us the greenlight for only returning a "Not supported" code with a message stating the official routes needed to perform it. Which is why we do not have any 2xx responses listed.

    Second, this is not a breaking change. This api version, 2023-04-06, received an exception very recently when it was created for not adding PUT/DELETE operations. This PR simply adds a formal "Not supported" response. No actual functionality with this operation has changed.

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    Hi @8Gitbrix, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    The automation detected this Pull Request introduces breaking changes to an existing API version and hence it added the NewApiVersionRequired label. This means you cannot proceed with merging this PR until you complete one of the following action items:

    - A) Submit a new PR instead of this one, or modify this PR, so that it introduces a new API version instead of introducing breaking changes to an existing API version. The automation will remove the label once it detects there are no more breaking changes.
    - B) OR you can request an approval of the breaking changes, get it reviewed, and approved. The reviewer will add Approved-BreakingChange label if they approve.

    For additional guidance, please see https://aka.ms/NewApiVersionRequired

    @ankhyk
    Copy link
    Copy Markdown
    Contributor

    ankhyk commented May 23, 2023

    @konrad-jamrozik can we approve this breaking change?

    @konrad-jamrozik
    Copy link
    Copy Markdown

    konrad-jamrozik commented May 23, 2023

    As a note, our RP does not support PUT or DELETE operations. However, as a requirement for GA, we need to return a response for them. The ARM team originally gave us the greenlight for only returning a "Not supported" code with a message stating the official routes needed to perform it. Which is why we do not have any 2xx responses listed.

    Can you link me to the greenlight from the ARM team, so I can verify?

    Second, this is not a breaking change. This api version, 2023-04-06, received an exception very recently when it was created for not adding PUT/DELETE operations. This PR simply adds a formal "Not supported" response. No actual functionality with this operation has changed.

    To which of the failing checks of the breaking change detector are you referring to specifically? I mean the failures listed here.

    @konrad-jamrozik can we approve this breaking change?

    Please address my questions above. I also recommend addressing the other failures. Thx! :)

    @bdefoy @rkmanda FYI

    @mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 1, 2023
    @mentat9
    Copy link
    Copy Markdown
    Member

    mentat9 commented Jun 1, 2023

    As a note, our RP does not support PUT or DELETE operations. However, as a requirement for GA, we need to return a response for them. The ARM team originally gave us the greenlight for only returning a "Not supported" code with a message stating the official routes needed to perform it. Which is why we do not have any 2xx responses listed.

    Second, this is not a breaking change. This api version, 2023-04-06, received an exception very recently when it was created for not adding PUT/DELETE operations. This PR simply adds a formal "Not supported" response. No actual functionality with this operation has changed.

    Note: ARM signed off on the private PR here: https://github.com/Azure/azure-rest-api-specs-pr/pull/12118.

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented Aug 21, 2023

    Next Steps to Merge

    Next steps that must be taken to merge this PR:
    • ❌ Your PR has non-breaking changes (label: NewApiVersionRequired). You must introduce a new API version with these changes instead of modifying existing one. See the PR description for help.
    • ❌ The required check named Swagger BreakingChange has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 1 in the PR workflow diagram (even if your PR is for data plane, not ARM).

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    7 similar comments
    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    13 similar comments
    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    @microsoft-github-policy-service
    Copy link
    Copy Markdown
    Contributor

    Hi, @8Gitbrix. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    10 participants