Enable Azure Key Vault for compute linked services

[fhljys]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• [Y] The title of the PR is clear and informative.
• [Y] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• [Y] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• [Y] If applicable, the PR references the bug/issue that it fixes.
• [Y] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• [Y] I have read the contribution guidelines.
• [Y] My spec meets the review criteria:
  • [Y] The spec conforms to the Swagger 2.0 specification.
  • [Y] The spec follows the guidelines described in the Swagger checklist document.
  • [Y] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

This commit was treated and no generation was made for Azure/azure-sdk-for-python

[AutorestCI]

This commit was treated and no generation was made for Azure/azure-sdk-for-go

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datafactory/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[jianghaolu]

Cannot resolve reference. "../../datafactory.json#/definitions/SecretBase"?

[fhljys]

In datafactory.json,

Theres is "SecretBase": {
"description": "The base definition of a secret type.",
"discriminator": "type",
"type": "object",
"properties": {
"type": {
"type": "string",
"description": "Type of the secret."
}
},
"required": [
"type"
]
},
Should I add it to somewhere else?

[AutorestCI]

Automation for azure-sdk-for-python

Was unable to create SDK azure-sdk-for-python PR for this closed PR.

[jianghaolu]

Per communication offline, the error in semantic validation is a false alarm.

Oops, this looks like a bug in travis-ci logic. So for PR_ONLY=true mode, we run the semantic validator on the files that were touched in this PR. Unfortunately this is the PR where only the file containing the model definitions (LinkedService.json) was touched. The actual swagger spec (datafactory.json) was not touched. The actual swagger spec should have been the entry point for the semantic validator instead of the external model file.
If I execute the following command on my machine, then everything works fine.
oav validate-spec https://github.com/fhljys/azure-rest-api-specs/blob/19db39b7ade68cf715a6d4102d6faf81d9215f30/specification/datafactory/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/datafactory.json
info: No Errors were found.
Bottom line: in PR_ONLY true mode we need to ensure that we are validating a swagger spec and not a model definition file. The problem here is that model definition files are also swagger specs but they only have model definitions no paths. So we need to find an intelligent way to find out the right swagger spec(entry point) and validate accordingly.
Thanks,
Amar

[AutorestCI]

This commit was treated and no generation was made for Azure/azure-sdk-for-go

[AutorestCI]

Swagger to SDK encountered an unknown error: (Azure/azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 29, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 180, in rest_handle_action
    return rest_pull_close(body, github_con, restapi_repo, sdk_pr_target_repo, sdkbase)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 311, in rest_pull_close
    rest_pr.create_issue_comment("Was unable to create SDK %s PR for this closed PR.", sdkid)
TypeError: create_issue_comment() takes 2 positional arguments but 3 were given