[Hub Generated] Publish private branch 'amatukmolina-graphservicesprod-Microsoft.GraphServices-2023-04-13'

[amatukmolina]

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

1. What's the purpose of the update?
   • new service onboarding
   • new API version
   • update existing version for new feature
   • update existing version to fix swagger quality issue in s360
   • Other, please clarify
2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. May 2023
3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. May 2023
4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

• I commit to follow the Breaking Change Policy of "no breaking changes"
• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

• Change to data plane APIs
• Adding new properties
• All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

• Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

  • Adding a new service
  • Adding new API(s)
  • Adding a new API version
    -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.

• Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

• If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

[amatukmolina]

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/12109

[openapi-pipeline-app]

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️Breaking Change(Cross-Version): 5 Warnings warning [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
graphservicesprod.json	2023-04-13(038eda2)	2022-09-22-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1008 - ModifiedOperationId	The operation id has been changed from 'Account_Get' to 'Accounts_Get'. This will impact generated code. New: Microsoft.GraphServices/stable/2023-04-13/graphservicesprod.json#L115:7 Old: Microsoft.GraphServices/preview/2022-09-22-preview/graphservicesprod.json#L115:7
⚠️ 1008 - ModifiedOperationId	The operation id has been changed from 'Account_CreateAndUpdate' to 'Accounts_CreateAndUpdate'. This will impact generated code. New: Microsoft.GraphServices/stable/2023-04-13/graphservicesprod.json#L152:7 Old: Microsoft.GraphServices/preview/2022-09-22-preview/graphservicesprod.json#L152:7
⚠️ 1008 - ModifiedOperationId	The operation id has been changed from 'Account_Update' to 'Accounts_Update'. This will impact generated code. New: Microsoft.GraphServices/stable/2023-04-13/graphservicesprod.json#L208:7 Old: Microsoft.GraphServices/preview/2022-09-22-preview/graphservicesprod.json#L208:7
⚠️ 1008 - ModifiedOperationId	The operation id has been changed from 'Account_Delete' to 'Accounts_Delete'. This will impact generated code. New: Microsoft.GraphServices/stable/2023-04-13/graphservicesprod.json#L254:7 Old: Microsoft.GraphServices/preview/2022-09-22-preview/graphservicesprod.json#L254:7
⚠️ 1008 - ModifiedOperationId	The operation id has been changed from 'Operation_List' to 'Operations_List'. This will impact generated code. New: Microsoft.GraphServices/stable/2023-04-13/graphservicesprod.json#L293:7 Old: Microsoft.GraphServices/preview/2022-09-22-preview/graphservicesprod.json#L293:7

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.1)	new version	base version
package-2023-04-13	package-2023-04-13(038eda2)	default(main)

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.GraphServices/stable/2023-04-13/graphservicesprod.json#L373
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.GraphServices/stable/2023-04-13/graphservicesprod.json#L418

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
❌ API Readiness check failed. Please make sure your service is deployed.	"code: InvalidResourceType, message: The resource type 'operations' could not be found in the namespace 'Microsoft.GraphServices' for api version '2023-04-13'. The supported api-versions are '2022-09-22-preview'."

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-workflow-bot]

Hi, @amatukmolina Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

[openapi-pipeline-app]

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account. 

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-python-track2 - track2_azure-mgmt-graphservices - 1.0.0b1

+	Removed operation group AccountOperations
+	Removed operation group OperationOperations

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from 7b9aa4c. SDK Automation 14.0.0

  command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
  command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

• ️✔️Azure.ResourceManager.Graphservicesprod [View full logs]  [Release SDK Changes]
  • Azure.ResourceManager.Graphservicesprod.1.0.0-alpha.20230524.1.nupkg

  info	[Changelog]

• ️✔️Azure.ResourceManager.GraphServices [View full logs]  [Release SDK Changes]
  • Azure.ResourceManager.GraphServices.1.0.0-alpha.20230524.1.nupkg

  info	[Changelog]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

• ⚠️Warning [Logs]Release - Generate from 7b9aa4c. SDK Automation 14.0.0

  command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
  cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
  command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  cmderr	[automation_generate.sh]
  cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
  cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
  cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.7` to update!
  cmderr	[automation_generate.sh] npm notice

• ️✔️track2_azure-mgmt-graphservices [View full logs]  [Release SDK Changes] Breaking Change Detected
  • azure-mgmt-graphservices-1.0.0b1.zip
  • azure_mgmt_graphservices-1.0.0b1-py3-none-any.whl

  info	[Changelog] ### Features Added
  info	[Changelog]
  info	[Changelog]   - Added operation AccountsOperations.begin_create_and_update
  info	[Changelog]   - Added operation AccountsOperations.delete
  info	[Changelog]   - Added operation AccountsOperations.get
  info	[Changelog]   - Added operation AccountsOperations.update
  info	[Changelog]   - Added operation group Operations
  info	[Changelog]
  info	[Changelog] ### Breaking Changes
  info	[Changelog]
  info	[Changelog]   - Removed operation group AccountOperations
  info	[Changelog]   - Removed operation group OperationOperations

️⚠️ azure-sdk-for-java warning [Detail]

• ⚠️Warning [Logs]Release - Generate from 7b9aa4c. SDK Automation 14.0.0

  command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
  cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
  cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
  cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
  cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
  command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

• ️✔️azure-resourcemanager-graphservices [View full logs]  [Release SDK Changes]
  • pom.xml
  • azure-resourcemanager-graphservices-1.0.0-beta.2-sources.jar
  • azure-resourcemanager-graphservices-1.0.0-beta.2.jar

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from 7b9aa4c. SDK Automation 14.0.0

  command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
  warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
  command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

• ️✔️@azure/arm-graphservices [View full logs]  [Release SDK Changes]
  • azure-arm-graphservices-1.0.0.tgz

  info	[Changelog]
  error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-resource-manager-schemas warning [Detail]

• ⚠️Warning [Logs]Release - Generate from 7b9aa4c. Schema Automation 14.0.0

  command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
  cmderr	[initScript.sh] WARN old lockfile
  cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
  cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
  cmderr	[initScript.sh] npm WARN old lockfile
  cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
  cmderr	[initScript.sh] npm WARN old lockfile
  warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
  command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

• ️✔️graphservicesprod [View full logs]  [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Generated ApiView

Language	Package Name	ApiView Link
Java	azure-resourcemanager-graphservices	https://apiview.dev/Assemblies/Review/31f42712d0f94f0f94466178d7631d64
.Net	Azure.ResourceManager.GraphServices	There is no API change compared with the previous version
.Net	Azure.ResourceManager.Graphservicesprod	https://apiview.dev/Assemblies/Review/68024bf22a2949e984a35b1bd694d5b2
JavaScript	@azure/arm-graphservices	https://apiview.dev/Assemblies/Review/d5fcf74f9a574cc0912c2afa2f7327e3

[openapi-workflow-bot]

Hi, @amatukmolina your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

[amatukmolina]

@zedy-wj Regarding the API Readiness error, right now the operations RT is updated in Canary for testing purposes and I assume that's why the pipeline says the new api-verison can't be found. Is that a blocker or can we wait for this swagger spec to be merged so we can rollout to every region?

[zedy-wj]

Regarding the API Readiness error, right now the operations RT is updated in Canary for testing purposes and I assume that's why the pipeline says the new api-verison can't be found. Is that a blocker or can we wait for this swagger spec to be merged so we can rollout to every region?

@josefree Could you help to check if it is a blocker?

[raosuhas]

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/12109
Is there any diff between this PR and the one checked into the private branch ?

[openapi-workflow-bot]

Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

[amatukmolina]

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/12109
Is there any diff between this PR and the one checked into the private branch ?

@raosuhas There's no difference, we sent the PR as is from the OpenAPI hub tool

[zedy-wj]

ArmSignedOff as has been reviewed and approved in private pr https://github.com/Azure/azure-rest-api-specs-pr/pull/12109.