Skip to content

[EventGrid] Remove internal#23995

Merged
lmazuel merged 2 commits intoAzure:feature/eventgrid/typespecfrom
l0lawrence:remove_internal
May 16, 2023
Merged

[EventGrid] Remove internal#23995
lmazuel merged 2 commits intoAzure:feature/eventgrid/typespecfrom
l0lawrence:remove_internal

Conversation

@l0lawrence
Copy link
Member

No description provided.

@openapi-workflow-bot
Copy link

Hi, @l0lawrence Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 15, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 15, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Code Generator Failed [Logs] Generate from 88bac3d5bf8bd4ac652854a2faf70e0c815e3fd7. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      cmderr	[Automation-Sdk-Init.ps1] �[31;1mGetDotNetInstallScript: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Automation-Sdk-Init.ps1:39
      cmderr	[Automation-Sdk-Init.ps1] �[36;1mLine |
      cmderr	[Automation-Sdk-Init.ps1] �[36;1m  39 | �[0m $installScript = �[36;1mGetDotNetInstallScript�[0m
      cmderr	[Automation-Sdk-Init.ps1] �[36;1m     | �[31;1m                  ~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Automation-Sdk-Init.ps1] �[31;1m�[36;1m     | �[31;1mThe SSL connection could not be established, see inner exception.
      cmderr	[Automation-Sdk-Init.ps1] �[0m
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mException: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:133
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 133 | �[0m             �[36;1mthrow "Not provide service name or namespace."�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mNot provide service name or namespace.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1
      warn	Skip package processing as generation is failed
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Event Grid label May 15, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 15, 2023

    Generated ApiView

    Language Package Name ApiView Link
    TypeSpec Azure.Messaging.EventGrid https://apiview.dev/Assemblies/Review/c2072846e9524c9e953159b974d48274

    @lmazuel lmazuel marked this pull request as ready for review May 16, 2023 17:30
    @lmazuel lmazuel requested review from Kishp01 and ahamad-MS as code owners May 16, 2023 17:30
    @lmazuel lmazuel merged commit e570388 into Azure:feature/eventgrid/typespec May 16, 2023
    lmazuel added a commit that referenced this pull request May 22, 2023
    * start typespec
    
    * adding eventgrid typespec for api w/ TODOs
    
    * update eventgrid typespec with latest eventgrid v2 operations
    
    * don't require content-type if there is no body
    
    * Update specification/eventgrid/typespec/main.tsp
    
    Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
    
    * Update specification/eventgrid/typespec/main.tsp
    
    Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
    
    * changing naming of cloudevent and added in data_base64
    
    * openapi.json
    
    * Update specification/eventgrid/typespec/main.tsp
    
    Co-authored-by: Libba Lawrence <llawrence@microsoft.com>
    
    * Update specification/eventgrid/typespec/main.tsp
    
    Co-authored-by: Libba Lawrence <llawrence@microsoft.com>
    
    * Update specification/eventgrid/typespec/main.tsp
    
    Co-authored-by: Libba Lawrence <llawrence@microsoft.com>
    
    * lockTokens format, updated json, optional? params
    
    * address code review comments
    
    * name_change
    
    * add @internal for python
    
    * Update specification/eventgrid/Azure.Messaging.EventGrid/main.tsp
    
    Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
    
    * move @internal to client.tsp (#23538)
    
    * rename (#23565)
    
    * [EventGrid Typespec] breaking changes with april release of typespec (#23539)
    
    * breaking changes with april release of typespec
    
    * unknown type
    
    * [EG Typespec] Update Release behavior (#23699)
    
    * update behavior
    
    * just behavior
    
    * Add tspconfig and remove AAD auth (#23717)
    
    * add tspconfig
    
    * add namespace
    
    * remove oauth
    
    * [EG TypeSpec] Archboard Comments (#23696)
    
    * refactoring off of apiview
    
    * keep as int
    
    * no duration
    
    * aligning ack and release
    
    * remove behavioral change
    
    * ack to release
    
    * initial naming changes
    
    * Update ReleaseResult doc
    
    Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
    
    * Update AckResult doc
    
    Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
    
    * versioning twice-- remove one instance
    
    ---------
    
    Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
    
    * Address couple of stewardship team feedback. These include: 1. Rename CloudEventEvent to simply CloudEvent, 2. Add more description to the operations including the possible erorr codes, 3. Add PublishResult with empty Json object as successful response for the Publish operation, 4. Others.
    
    * Add support for missing Reject operation + adding deliveryAttemptCount to BrokerProperties + Adding query parameter for release operation for deliveryDelayInSeconds
    
    * Update failedTokens/SuccessfulTokens Description to address code review comments
    
    * Update to match service behavior (#23754)
    
    * Update to match service behavior
    
    * remove locktoken
    
    * [EGv2] Editing unused variables (#23917)
    
    * event delivery delay not in preview
    
    * remove from url comment
    
    * [EGv2] Version dependency on Azure.Core  (#23936)
    
    * verioning fix
    
    * spacing mishap?
    
    * [EventGrid] Deliveryattempt change (#23960)
    
    * deliveryCount 5/1
    
    * small typo
    
    * [EventGrid] Remove internal (#23995)
    
    * remove internal
    
    * remove client.tsp
    
    * remove waitWaitTime (#24078)
    
    * move location of json file (#24076)
    
    * [Egv2] Encode param (#24080)
    
    * encode
    
    * remove num default on duration
    
    ---------
    
    Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com>
    
    * [EGv2] Fix pipeline (#24098)
    
    * regen off new commit for encode
    
    * reference preview tag
    
    * ignore word
    
    * update readme to have both apis
    
    * update with next autorest
    
    * change format to int32
    
    ---------
    
    Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com>
    Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com>
    Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
    Co-authored-by: Ashraf Hamad <ahamad-MS@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants