[TypeSpec-Clean] Updates for OpenAi.Inference#23970
Merged
markcowl merged 1 commit intoAzure:mainfrom May 13, 2023
markcowl:tsp-clean-oaiinf
Merged
[TypeSpec-Clean] Updates for OpenAi.Inference#23970markcowl merged 1 commit intoAzure:mainfrom markcowl:tsp-clean-oaiinf
markcowl merged 1 commit intoAzure:mainfrom
markcowl:tsp-clean-oaiinf
Conversation
|
Hi, @markcowl Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Couldn't resolve import "@azure-tools/typespec-client-generator-core" Location: specification/cognitiveservices/ContentSafety/routes.tsp#L2 |
|
Namespace Azure doesn't have member ClientGenerator Location: specification/cognitiveservices/ContentSafety/routes.tsp#L12 |
|
Unknown identifier Cadl Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L9 |
|
Unknown identifier Cadl Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L10 |
|
Unknown identifier Cadl Location: specification/cognitiveservices/OpenAI.Authoring/finetune.tsp#L93 |
|
Unknown decorator Location: specification/cognitiveservices/OpenAI.Authoring/finetune.tsp#L93 |
|
Unknown identifier route Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L27 |
|
Unknown decorator Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L27 |
|
Unknown identifier get Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L28 |
|
Unknown decorator Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L28 |
|
"details":"The 'examples' directory is missing in the typespec folder specification/cognitiveservices/OpenAI.Authoring, please ensure the 'examples' is added in the PR." |
|
"details":"The 'examples' directory is missing in the typespec folder specification/cognitiveservices/OpenAI.Inference, please ensure the 'examples' is added in the PR." |
|
"details":"The generated swagger file 2022-12-01/openapi.json from typespec specification/cognitiveservices/OpenAI.Inference is not on the branch." |
|
"details":"The generated swagger file 2023-03-15-preview/openapi.json from typespec specification/cognitiveservices/OpenAI.Inference is not on the branch." |
| "details":"The configuration 'azure-resource-provider-folder' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/AnomalyDetector, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'." |
|
| "details":"The configuration 'output-file' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Authoring, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'." |
|
| "details":"The configuration 'azure-resource-provider-folder' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Authoring, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'." |
|
| "details":"The configuration 'output-file' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Inference, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'." |
|
| "details":"The configuration 'azure-resource-provider-folder' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Inference, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'." |
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
ghost
added
the
Swagger Generation Artifacts
|
Generated ApiView
|
mikeharder
requested changes
May 13, 2023
| - "@azure-tools/typespec-autorest" | ||
| - "@azure-tools/cadl-apiview" | ||
| # - "@azure-tools/typespec-autorest" | ||
| # - "@azure-tools/cadl-apiview" |
Member
There was a problem hiding this comment.
There is currently no config for typespec-autorest, so I don't think it will output any swagger? Once we add config, should it output to this folder?
Member
Author
There was a problem hiding this comment.
If this started with a new api-version, that would be the case. As it is, this older api-version is very unlikely to match the swagger in that folder (though it would hopefully be sematically equivalent)
Member
There was a problem hiding this comment.
This change causes the CI pipeline to "pass", but it's only because no emitter is run:
+ pushd specification/cognitiveservices/OpenAI.Inference
+ npx tsp compile .
TypeSpec compiler v0.43.0
Diagnostics were reported during compilation:
warning emitter-not-found: Emitter with name @azure-tools/typespec-csharp is not found.
warning emitter-not-found: Emitter with name @azure-tools/typespec-java is not found.
Found 2 warnings.
No emitter was configured, no output was generated. Use `--emit <emitterName>` to pick emitter or specify it in the typespec config.
Do we want specs in the repo with no emitters configured? What is the scenario for this?
Member
Author
There was a problem hiding this comment.
It looks like this is here purely for client generation. If we can agree on where to emit the swagger, it would be good to emit it there
Member
There was a problem hiding this comment.
I'm fine merging this PR as-is. Later we will need to decide what to do with specs that are client-only (don't emit swagger).
3 tasks
mikeharder
requested changes
May 13, 2023
| - "@azure-tools/typespec-autorest" | ||
| - "@azure-tools/cadl-apiview" | ||
| # - "@azure-tools/typespec-autorest" | ||
| # - "@azure-tools/cadl-apiview" |
Member
There was a problem hiding this comment.
This change causes the CI pipeline to "pass", but it's only because no emitter is run:
+ pushd specification/cognitiveservices/OpenAI.Inference
+ npx tsp compile .
TypeSpec compiler v0.43.0
Diagnostics were reported during compilation:
warning emitter-not-found: Emitter with name @azure-tools/typespec-csharp is not found.
warning emitter-not-found: Emitter with name @azure-tools/typespec-java is not found.
Found 2 warnings.
No emitter was configured, no output was generated. Use `--emit <emitterName>` to pick emitter or specify it in the typespec config.
Do we want specs in the repo with no emitters configured? What is the scenario for this?
mikeharder
approved these changes
May 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.