[TypeSpec-Clean]: Updating HealthInsights#23966
[TypeSpec-Clean]: Updating HealthInsights#23966markcowl merged 4 commits intoAzure:mainfrom markcowl:tsp-clean-hi
Conversation
|
Hi, @markcowl Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| "How to fix":"Check the detailed log and verify if the TypeSpec emitter is able to create API review file for the changes in PR." | |
| "How to fix":"Check the detailed log and verify if the TypeSpec emitter is able to create API review file for the changes in PR." |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️❌TypeSpec Validation: 20 Errors, 5 Warnings failed [Detail]
| Rule | Message |
|---|---|
import-not-found |
Couldn't resolve import "@azure-tools/typespec-client-generator-core" Location: specification/cognitiveservices/ContentSafety/routes.tsp#L2 |
invalid-ref |
Namespace Azure doesn't have member ClientGenerator Location: specification/cognitiveservices/ContentSafety/routes.tsp#L12 |
unknown-identifier |
Unknown identifier Cadl Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L9 |
unknown-identifier |
Unknown identifier Cadl Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L10 |
unknown-identifier |
Unknown identifier Cadl Location: specification/cognitiveservices/OpenAI.Authoring/finetune.tsp#L93 |
unknown-decorator |
Unknown decorator Location: specification/cognitiveservices/OpenAI.Authoring/finetune.tsp#L93 |
unknown-identifier |
Unknown identifier route Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L27 |
unknown-decorator |
Unknown decorator Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L27 |
unknown-identifier |
Unknown identifier get Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L28 |
unknown-decorator |
Unknown decorator Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L28 |
import-not-found |
Couldn't resolve import "@azure-tools/typespec-client-generator-core" Location: specification/cognitiveservices/OpenAI.Inference/routes.tsp#L4 |
invalid-ref |
Namespace Azure doesn't have member ClientGenerator Location: specification/cognitiveservices/OpenAI.Inference/routes.tsp#L13 |
unknown-identifier |
Unknown identifier convenientAPI Location: specification/cognitiveservices/OpenAI.Inference/routes.tsp#L20 |
unknown-decorator |
Unknown decorator Location: specification/cognitiveservices/OpenAI.Inference/routes.tsp#L20 |
unknown-identifier |
Unknown identifier convenientAPI Location: specification/cognitiveservices/OpenAI.Inference/routes.tsp#L31 |
unknown-decorator |
Unknown decorator Location: specification/cognitiveservices/OpenAI.Inference/routes.tsp#L31 |
unknown-identifier |
Unknown identifier convenientAPI Location: specification/cognitiveservices/OpenAI.Inference/routes.tsp#L42 |
unknown-decorator |
Unknown decorator Location: specification/cognitiveservices/OpenAI.Inference/routes.tsp#L42 |
MissingExamplesDirectory |
"details":"The 'examples' directory is missing in the typespec folder specification/cognitiveservices/OpenAI.Authoring, please ensure the 'examples' is added in the PR." |
MissingExamplesDirectory |
"details":"The 'examples' directory is missing in the typespec folder specification/cognitiveservices/OpenAI.Inference, please ensure the 'examples' is added in the PR." |
| "details":"The configuration 'azure-resource-provider-folder' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/AnomalyDetector, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'." |
|
| "details":"The configuration 'output-file' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Authoring, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'." |
|
| "details":"The configuration 'azure-resource-provider-folder' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Authoring, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'." |
|
| "details":"The configuration 'output-file' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Inference, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'." |
|
| "details":"The configuration 'azure-resource-provider-folder' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Inference, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'." |
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
|
Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
specification/cognitiveservices/HealthInsights/healthinsights.openapi/tspconfig.yaml
Outdated
Show resolved
Hide resolved
...fication/cognitiveservices/HealthInsights/healthinsights.trialmatcher/route.trialmatcher.tsp
Outdated
Show resolved
Hide resolved
...cation/cognitiveservices/HealthInsights/healthinsights.oncophenotype/route.oncophenotype.tsp
Outdated
Show resolved
Hide resolved
Respondign to review comments Co-authored-by: Mike Harder <mharder@microsoft.com>
|
@mikeharder I made one change - the service name is set from the root namespace, which does not match where this swagger should be emitted. I used the literal service name rather than the interpolated variable, rather than changing the namespace. |
Should we change the namespace instead? I'm fine if we want to fix this in a later PR, and for now only make changes required to successfully build the folder. But longer-term I think we want to align all the existing specs folders in the repo as much as we can. So if the convention is the swagger should be emitted to a folder named the same as the namespace, I'd like to make this consistent across specs. |
cognitiveservices).healthinsights.oncophenotypethat are not configured to generate Swagger.