-
Notifications
You must be signed in to change notification settings - Fork 5.7k
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2023-03-01 #23914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
weidongxu-microsoft
merged 37 commits into
main
from
pthippeswamy-consumption-Microsoft.Consumption-2023-03-01
Jun 14, 2023
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
53d7e60
EA Pricesheet download documentation.
pthippeswamy d802b6d
Model validation error fix
pthippeswamy 5e79725
readme edit to add consumption_pricesheet.json
pthippeswamy dfa6a5c
corrections
pthippeswamy b88151e
Proper braces
pthippeswamy 73d80d0
corrections
pthippeswamy 17a19ec
corrections
pthippeswamy 6a47fe4
edits
pthippeswamy bcdd833
corrections
pthippeswamy 4ef23f4
edit
pthippeswamy b19299e
Removed unwanted path and example file
pthippeswamy c7b4448
Added error response back
pthippeswamy 14815b1
Call method correction
pthippeswamy f403086
validating Linter error - testing
pthippeswamy 50e099e
Removed errorResponse to common file
pthippeswamy 38ed9dd
errorResponse
pthippeswamy 5a2614e
Adding common-types json to readme
pthippeswamy 079af5a
ErrorDetail addition
pthippeswamy 5054dc7
Removed common-types. Edits to correct Linter issues.
pthippeswamy 5d30090
removed the reference to old file
pthippeswamy bb11c77
CI issues fixed
pthippeswamy 5729531
Corrections based on PR comment
pthippeswamy 24eb944
rename
pthippeswamy e0d3154
SDK error fix
pthippeswamy 135dd5f
Delete consumption.json
pthippeswamy f86b658
Revert "SDK error fix"
pthippeswamy 76bd16f
Merge branch 'pthippeswamy-consumption-Microsoft.Consumption-2023-03-…
pthippeswamy 79d167e
Suppression for Linter error
pthippeswamy 0b79606
supression
pthippeswamy 1691e36
supression
pthippeswamy 943ddd8
supression error
pthippeswamy 35c8b2b
resolve go duplicate schema issue
tadelesh b679f83
Changes per - https://nam06.safelinks.protection.outlook.com/?url=htt…
pthippeswamy e826806
Merge branch 'pthippeswamy-consumption-Microsoft.Consumption-2023-03-…
pthippeswamy eab544d
correction
pthippeswamy aba9d50
correcting suppression format
pthippeswamy b48c7ef
revert suppression
tadelesh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
158 changes: 158 additions & 0 deletions
158
...tion/resource-manager/Microsoft.Consumption/stable/2023-03-01/consumption_pricesheet.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| { | ||
| "swagger": "2.0", | ||
| "info": { | ||
| "version": "2023-03-01", | ||
| "title": "ConsumptionManagementClient", | ||
| "description": "Consumption management client provides access to consumption resources for Azure Enterprise Subscriptions." | ||
| }, | ||
| "host": "management.azure.com", | ||
| "schemes": [ | ||
| "https" | ||
| ], | ||
| "consumes": [ | ||
| "application/json" | ||
| ], | ||
| "produces": [ | ||
| "application/json" | ||
| ], | ||
| "security": [ | ||
| { | ||
| "azure_auth": [ | ||
| "user_impersonation" | ||
| ] | ||
| } | ||
| ], | ||
| "securityDefinitions": { | ||
| "azure_auth": { | ||
| "type": "oauth2", | ||
| "authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize", | ||
| "flow": "implicit", | ||
| "description": "Azure Active Directory OAuth2 Flow.", | ||
| "scopes": { | ||
| "user_impersonation": "impersonate your user account" | ||
| } | ||
| } | ||
| }, | ||
| "paths": { | ||
| "/providers/Microsoft.Billing/billingAccounts/{billingAccountId}/billingPeriods/{billingPeriodName}/providers/Microsoft.Consumption/pricesheets/download": { | ||
| "post": { | ||
| "tags": [ | ||
| "PriceSheet" | ||
| ], | ||
| "operationId": "PriceSheet_DownloadByBillingAccountPeriod", | ||
| "description": "Generates the pricesheet for the provided billing period asynchronously based on the enrollment id", | ||
| "externalDocs": { | ||
| "url": "https://docs.microsoft.com/en-us/rest/api/consumption/" | ||
| }, | ||
| "x-ms-long-running-operation": true, | ||
| "x-ms-long-running-operation-options": { | ||
| "final-state-via": "location" | ||
| }, | ||
| "x-ms-examples": { | ||
| "EAPriceSheetForBillingPeriod": { | ||
| "$ref": "./examples/EAPriceSheetForBillingPeriod.json" | ||
| } | ||
| }, | ||
| "parameters": [ | ||
| { | ||
| "$ref": "#/parameters/billingAccountIdParameter" | ||
| }, | ||
| { | ||
| "$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ApiVersionParameter" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/billingPeriodNameParameter" | ||
| } | ||
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "Request processing completed.", | ||
| "schema": { | ||
| "$ref": "#/definitions/OperationStatus" | ||
| } | ||
| }, | ||
| "202": { | ||
| "description": "Accepted", | ||
| "headers": { | ||
| "Location": { | ||
| "type": "string" | ||
| }, | ||
| "Retry-After": { | ||
| "type": "integer", | ||
| "format": "int64" | ||
| } | ||
| } | ||
| }, | ||
| "default": { | ||
| "description": "Error response describing why the operation failed.", | ||
| "schema": { | ||
| "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" | ||
tadelesh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "definitions": { | ||
| "OperationStatus": { | ||
| "description": "The status of the long running operation.", | ||
| "type": "object", | ||
| "properties": { | ||
| "status": { | ||
| "description": "The status of the long running operation.", | ||
| "type": "string", | ||
| "enum": [ | ||
| "Running", | ||
| "Completed", | ||
| "Failed" | ||
| ], | ||
| "x-ms-enum": { | ||
| "name": "OperationStatusType", | ||
| "modelAsString": true | ||
| } | ||
| }, | ||
| "properties": { | ||
| "x-ms-client-flatten": true, | ||
| "description": "The properties of the resource generated.", | ||
| "$ref": "#/definitions/PricesheetDownloadProperties" | ||
| } | ||
| } | ||
| }, | ||
| "PricesheetDownloadProperties": { | ||
| "description": "The properties of the price sheet download.", | ||
| "type": "object", | ||
| "properties": { | ||
| "downloadUrl": { | ||
| "description": "The link (url) to download the pricesheet.", | ||
| "type": "string", | ||
| "readOnly": true | ||
| }, | ||
| "validTill": { | ||
| "description": "Download link validity.", | ||
| "type": "string", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It should be date-time format? #Resolved
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added it. |
||
| "format": "date-time", | ||
| "readOnly": true | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "parameters": { | ||
| "billingAccountIdParameter": { | ||
| "name": "billingAccountId", | ||
| "in": "path", | ||
| "description": "BillingAccount ID", | ||
| "required": true, | ||
| "type": "string", | ||
| "x-ms-parameter-location": "method" | ||
| }, | ||
| "billingPeriodNameParameter": { | ||
| "name": "billingPeriodName", | ||
| "in": "path", | ||
| "description": "Billing Period Name.", | ||
| "required": true, | ||
| "type": "string", | ||
| "pattern": "^[0-9]*$", | ||
| "x-ms-parameter-location": "method" | ||
| } | ||
| } | ||
| } | ||
24 changes: 24 additions & 0 deletions
24
...anager/Microsoft.Consumption/stable/2023-03-01/examples/EAPriceSheetForBillingPeriod.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2023-03-01", | ||
| "billingAccountId": "0000000", | ||
| "billingPeriodName": "202305" | ||
| }, | ||
| "responses": { | ||
| "202": { | ||
| "headers": { | ||
| "Location": "https://management.azure.com/providers/Microsoft.Billing/billingAccounts/0000000/providers/Microsoft.Consumption/operationResults/00000000-0000-0000-0000-000000000000?api-version=2023-03-01", | ||
| "Retry-After": 10 | ||
| } | ||
| }, | ||
| "200": { | ||
| "body": { | ||
| "status": "Completed", | ||
| "properties": { | ||
| "downloadUrl": "https://xxxxxx.blob.core.windows.net/armpricesheetreportdownloadcontainer/20230510/00000000-0000-0000-0000-000000000000", | ||
| "validTill": "2023-05-11T05:12:50.4266333Z" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.