Update tspconfig.yaml by raych1 · Pull Request #23866 · Azure/azure-rest-api-specs

raych1 · 2023-05-09T00:56:31Z

The purpose is to have each language emitter to use the same config value in this file for code generation. Language emitters have the knowledge of the code generation path under sdk project directory base on the sdk project template.

clean up parameters section
get rid of emitter-out-dir
introduce service-dir and package-dir to be used by emitter and tools to compute the sdk project directory
add additionalDirectories to parameters section

clean up parameters section; get rid of emitter-out-dir; introduce service-dir and package-dir to be used by emitter and tools to figure out the sdk project directory.

openapi-workflow-bot · 2023-05-09T00:56:35Z

Hi, @raych1 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-05-09T00:56:36Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-09T00:56:37Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 69637dc. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.7.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️azure-contoso-widgetmanager [View full logs] [Release SDK Changes]
- azure-contoso-widgetmanager-1.0.0b1.zip
- azure_contoso_widgetmanager-1.0.0b1-py3-none-any.whl
```
info	[Changelog] data-plan skip changelog generation temporarily
```

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 69637dc. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:126
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 126 | �[0m             �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m             ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:805
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 805 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:126
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 126 | �[0m             �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m             ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.Contoso.WidgetManager [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 69637dc. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure-rest/contoso-widgetmanager-rest [View full logs] [Release SDK Changes]
- azure-rest-contoso-widgetmanager-rest-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 69637dc. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py]
cmderr	[generate.py] npm notice New major version of npm available! 8.19.4 -> 9.7.1
cmderr	[generate.py] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.1>
cmderr	[generate.py] npm notice Run `npm install -g npm@9.7.1` to update!
cmderr	[generate.py] npm notice
cmderr	[generate.py] warning: in the working copy of 'sdk/contosowidgetmanager/azure-contoso-widgetmanager/pom.xml', CRLF will be replaced by LF the next time Git touches it

️✔️azure-contoso-widgetmanager [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-09T00:56:37Z

Generated ApiView

Language	Package Name	ApiView Link
Python	azure-contoso-widgetmanager	https://apiview.dev/Assemblies/Review/77375b8781204cd7a188cdcc6a558d48
Java	azure-contoso-widgetmanager	https://apiview.dev/Assemblies/Review/39ca954fdf30432cbab08b0d5673abbb
JavaScript	@azure-rest/contoso-widgetmanager-rest	https://apiview.dev/Assemblies/Review/9e875440d1f94015b7c2356770153c36

weshaggard · 2023-05-09T23:39:06Z

I like this change but lets please try to get the sdk automation working before merging.

specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml

ghost · 2023-06-04T16:03:46Z

Hi, @raych1. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml

MaryGao · 2023-06-14T08:40:57Z

/azp run

azure-pipelines · 2023-06-14T08:41:07Z

Azure Pipelines successfully started running 1 pipeline(s).

Remove addition spaces and unnecessary keys for JS emitter options.

raych1 · 2023-06-15T01:55:42Z

/azp run

azure-pipelines · 2023-06-15T01:55:51Z

Azure Pipelines successfully started running 1 pipeline(s).

raych1 · 2023-06-15T03:05:54Z

dotnet sdk generation fails due to known issue of project scaffolding. Michael is working on the support in csharp emitter.

* Update tspconfig.yaml clean up parameters section; get rid of emitter-out-dir; introduce service-dir and package-dir to be used by emitter and tools to figure out the sdk project directory. * Update tspconfig.yaml * Update tspconfig.yaml * Update tspconfig.yaml Remove addition spaces and unnecessary keys for JS emitter options.

Update tspconfig.yaml

1cc8a7d

clean up parameters section; get rid of emitter-out-dir; introduce service-dir and package-dir to be used by emitter and tools to figure out the sdk project directory.

raych1 requested a review from weshaggard May 9, 2023 00:56

raych1 assigned weshaggard May 9, 2023

raych1 requested review from allenjzhang and m-nash May 9, 2023 00:57

raych1 added 2 commits May 9, 2023 18:27

Update tspconfig.yaml

4c64553

Update tspconfig.yaml

677e272

weshaggard mentioned this pull request May 9, 2023

[BUG] tsp script, avoid overwrite emitter-output-dir Azure/azure-sdk-for-java#34439

Closed

raych1 mentioned this pull request May 11, 2023

Consolidate interfaces/scripts used for typespec SDK package generation by each language Azure/azure-sdk-tools#6012

Closed

weshaggard reviewed May 11, 2023

View reviewed changes

specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml Outdated Show resolved Hide resolved

weshaggard reviewed May 11, 2023

View reviewed changes

specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml Outdated Show resolved Hide resolved

weshaggard reviewed May 11, 2023

View reviewed changes

specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml Show resolved Hide resolved

ghost added the no-recent-activity label Jun 4, 2023

weshaggard removed the no-recent-activity label Jun 5, 2023

weidongxu-microsoft approved these changes Jun 14, 2023

View reviewed changes

specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml Outdated Show resolved Hide resolved

msyyc approved these changes Jun 14, 2023

View reviewed changes

raych1 mentioned this pull request Jun 14, 2023

[OpenAI] Update JS tspconfig #24427

Closed

3 tasks

Update tspconfig.yaml

1c0d8f4

Remove addition spaces and unnecessary keys for JS emitter options.

raych1 merged commit 69637dc into main Jun 15, 2023

raych1 deleted the user/raych1/tspconfig-update branch June 15, 2023 03:06

raych1 mentioned this pull request Jul 3, 2023

Configuration changes for LoadTesting #24481

Merged

chunyu3 mentioned this pull request Aug 22, 2023

Default the namespace config to the value of packageDir Azure/autorest.csharp#3408

Closed

Conversation

raych1 commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openapi-workflow-bot bot commented May 9, 2023

Uh oh!

openapi-pipeline-app bot commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

weshaggard commented May 9, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Jun 4, 2023

Uh oh!

Uh oh!

MaryGao commented Jun 14, 2023

Uh oh!

azure-pipelines bot commented Jun 14, 2023

Uh oh!

raych1 commented Jun 15, 2023

Uh oh!

azure-pipelines bot commented Jun 15, 2023

Uh oh!

raych1 commented Jun 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

raych1 commented May 9, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 9, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 9, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 9, 2023 •

edited

Loading

raych1 commented Jun 15, 2023 •

edited

Loading