[Key Vault] Adding preview version 7.0 by schaabs · Pull Request #2367 · Azure/azure-rest-api-specs

schaabs · 2018-01-30T17:49:45Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…into 7.0-preview

AutorestCI · 2018-01-30T17:50:30Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

AutorestCI · 2018-01-30T17:51:37Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

AutorestCI · 2018-01-30T18:04:18Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

AutorestCI · 2018-01-30T18:05:09Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

AutorestCI · 2018-01-30T19:40:15Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

AutorestCI · 2018-01-30T19:47:25Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

jhendrixMSFT · 2018-01-30T21:29:53Z

@schaabs Hey man there are some modeler validation failures here, can you please take a look? I'm going through the linter failures however I don't think most of them apply to dataplane.

jhendrixMSFT · 2018-01-30T21:30:41Z

@schaabs Also the README.md file wasn't updated, is that intentional?

AutorestCI · 2018-01-30T22:27:21Z

Did a commit to Azure/azure-sdk-for-go:
Azure/azure-sdk-for-go@ff02b7c

AutorestCI · 2018-01-30T23:01:27Z

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@b690a4b

jhendrixMSFT · 2018-01-31T18:09:04Z

@schaabs There are still some model validation errors, see the log.
You can run the model validation tool locally, there are instructions for installing it here. Then you run oav validate-example <spec-path>.

rijethma · 2018-01-31T18:21:33Z

...ion/keyvault/data-plane/Microsoft.KeyVault/preview/7.0/examples/getStorageSasDefinition.json

+         "body":{
+            "id":"https://storage-sdk-test.vault-int.azure-int.net/storage/getsas01/sas/getStrgSasDef01",
+            "sid":"https://storage-sdk-test.vault-int.azure-int.net/secrets/getsas01-getStrgSasDef01",
+            "template":"se=2018-02-01T00%3A00Z&spr=https&sv=2017-04-17&sr=b&sig=XXFNfuMCHYrBx0bhemJ7PWn0xGfImMXT6LfbXWvtRUk%3D",


there are 2 new parameters: "sasType" and "validityPeriod", in all sas get, delete, update, set responses and set request

rijethma · 2018-01-31T18:23:19Z

...ion/keyvault/data-plane/Microsoft.KeyVault/preview/7.0/examples/setStorageSasDefinition.json

+      "sas-definition-name":"setStrgSasDef01",
+      "api-version":"2016-10-01",
+      "parameters":{
+         "template":"se=2018-02-01T00%3A00Z&spr=https&sv=2017-04-17&sr=b&sig=XXFNfuMCHYrBx0bhemJ7PWn0xGfImMXT6LfbXWvtRUk%3D",


sasType and validityPeriod are required parameters

rijethma · 2018-01-31T18:30:43Z

specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.0/keyvault.json

+  "info": {
+    "title": "KeyVaultClient",
+    "description": "The key vault client performs cryptographic key operations and vault operations against the Key Vault service.",
+    "version": "2016-10-01"


we need to change this to reflect v7.0

Good catch. I had this change originally but I must have blown it away when I merged in updates from 2016-10-01

rijethma

I'll CR once again after you add the missing parameters

rijethma · 2018-01-31T18:39:56Z

specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.0/keyvault.json

+            "description": "Created certificate bundle.",
+            "schema": {
+              "$ref": "#/definitions/CertificateOperation"
+


sasType and validityPeriod are 2 new required parameters here

rijethma · 2018-01-31T18:40:32Z

specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.0/keyvault.json

+            "description": "Created certificate bundle.",
+            "schema": {
+              "$ref": "#/definitions/CertificateOperation"
+


sasType and validityPeriod are 2 new required properties here

schaabs · 2018-02-01T00:36:34Z

@jhendrixMSFT All the model validation failures seem to be saying that path parameters aren't specified, but they are. I believe I've seen this before and was told it was a bug in the validation. Is this the case, or am I incorrectly specifying path parameters in the examples?

AutorestCI · 2018-02-01T00:41:03Z

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@ffd727f

AutorestCI · 2018-02-01T00:51:45Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

azuresdkciprbot · 2018-02-01T00:58:02Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/keyvault/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 30
After the PR: Warning(s): 0 Error(s): 30

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

jhendrixMSFT · 2018-02-01T19:19:10Z

specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.0/keyvault.json

+            "description": "Created certificate bundle.",
+            "schema": {
+              "$ref": "#/definitions/CertificateOperation"
+


This is marked as read-only however the property is also required (like 4758). It can't be both, which one is correct?

I'm not sure what you're referring to here. Is this comment on the wrong line?

Was supposed to be on line 4742, not sure what happened.

jhendrixMSFT · 2018-02-01T19:21:49Z

specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.0/keyvault.json

+  ],
+  "paths": {
+    "/keys/{key-name}/create": {
+      "post": {


Not all of the operations have examples, will they be added later?

Yes. This version (7.0-preview) of the spec is a copy of the 2016-10-01 spec, with a few breaking changes so far. The 2016-10-01 didn't have examples for these operations. We plan on adding examples for all before moving 7.0 to stable.

azuresdkciprbot · 2018-02-01T19:45:35Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/keyvault/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 30
After the PR: Warning(s): 0 Error(s): 30

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-02-01T19:49:59Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

AutorestCI · 2018-02-01T19:55:04Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

AutorestCI · 2018-02-01T20:17:06Z

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@c8fe8aa

AutorestCI · 2018-02-01T20:18:18Z

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@088c1e7

Scott Schaab added 2 commits January 8, 2018 10:58

Removing secrets.json from keyvault RM readme.md

818188c

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

05583f5

…into 7.0-preview

azuresdkci assigned jhendrixMSFT Jan 30, 2018

initial add of 7.0 preview rest spec

a59c9e7

fixing required properties on SasDefinitionCreateParameters

119f031

Fixing model validation errors, adding 7.0-preview tag to the readme.md

1458b23

schaabs requested review from RandalliLama and fearthecowboy and removed request for fearthecowboy January 30, 2018 23:10

RandalliLama approved these changes Jan 31, 2018

View reviewed changes

schaabs requested a review from rijethma January 31, 2018 01:14

rijethma reviewed Jan 31, 2018

View reviewed changes

adding SasDefinition properties sasType and validityPeriod

172b28e

rijethma approved these changes Feb 1, 2018

View reviewed changes

jhendrixMSFT reviewed Feb 1, 2018

View reviewed changes

fixing read-only and required properties

02ebbaa

jhendrixMSFT approved these changes Feb 1, 2018

View reviewed changes

jhendrixMSFT merged commit bfe1258 into Azure:master Feb 1, 2018

AutorestCI mentioned this pull request Feb 1, 2018

Automatic PR of restapi_auto_schaabs_7.0-preview into dev Azure/azure-sdk-for-go#1034

Closed

AutorestCI mentioned this pull request Feb 1, 2018

Automatic PR of restapi_auto_schaabs_7.0-preview into master Azure/azure-sdk-for-python#1879

Closed

schaabs mentioned this pull request Feb 1, 2018

[KeyVault] updating autorest generated code from 7.0-preview spec Azure/azure-sdk-for-python#1883

Merged

Conversation

schaabs commented Jan 30, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

jhendrixMSFT commented Jan 30, 2018

Uh oh!

jhendrixMSFT commented Jan 30, 2018

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

AutorestCI commented Jan 30, 2018

Uh oh!

jhendrixMSFT commented Jan 31, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rijethma Jan 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rijethma left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

schaabs commented Feb 1, 2018

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

azuresdkciprbot commented Feb 1, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Feb 1, 2018

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

AutorestCI commented Feb 1, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

schaabs commented Jan 30, 2018 •

edited by azuresdkci

Loading

rijethma Jan 31, 2018 •

edited

Loading