Delete Dataplane package.json and update to 0.43 by lmazuel · Pull Request #23618 · Azure/azure-rest-api-specs

lmazuel · 2023-04-19T00:14:41Z

Per @weshaggard recommendation, this file shouldn't exist

openapi-workflow-bot · 2023-04-19T00:14:45Z

Hi, @lmazuel Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-04-19T00:14:46Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-19T00:14:46Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from b64dd24. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
warn		specification/cognitiveservices/OpenAI.Authoring/tspconfig.yaml skipped due to azure-sdk-for-python not found in tspconfig.yaml
warn		specification/cognitiveservices/OpenAI.Inference/tspconfig.yaml skipped due to azure-sdk-for-python not found in tspconfig.yaml
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.5
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.5>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.5` to update!
cmderr	[automation_generate.sh] npm notice

️✔️azure-ai-anomalydetector [View full logs] [Release SDK Changes]
- azure_ai_anomalydetector-3.0.0-py3-none-any.whl
- azure-ai-anomalydetector-3.0.0.zip
```
info	[Changelog] data-plan skip changelog generation temporarily
```
️✔️azure-ai-translation-text [View full logs] [Release SDK Changes]
- azure-ai-translation-text-1.0.0b1.zip
- azure_ai_translation_text-1.0.0b1-py3-none-any.whl
```
info	[Changelog] data-plan skip changelog generation temporarily
```

️❌ azure-sdk-for-java failed [Detail]

❌Code Generator Failed [Logs]Release - Generate from b64dd24. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] Traceback (most recent call last):
cmderr	[generate.py]   File "/mnt/vss/_work/1/s/azure-sdk-for-java/./eng/mgmt/automation/generate.py", line 277, in <module>
cmderr	[generate.py]     main()
cmderr	[generate.py]   File "/mnt/vss/_work/1/s/azure-sdk-for-java/./eng/mgmt/automation/generate.py", line 206, in main
cmderr	[generate.py]     return sdk_automation(args['config'][0], args['config'][1])
cmderr	[generate.py]   File "/mnt/vss/_work/1/s/azure-sdk-for-java/./eng/mgmt/automation/generate.py", line 98, in sdk_automation
cmderr	[generate.py]     packages = sdk_automation_cadl(config)
cmderr	[generate.py]   File "/mnt/vss/_work/1/s/azure-sdk-for-java/eng/mgmt/automation/generate_data.py", line 42, in sdk_automation_cadl
cmderr	[generate.py]     sdk_folder = get_cadl_sdk_folder(os.path.join(cadl_dir, 'tspconfig.yaml'))
cmderr	[generate.py]   File "/mnt/vss/_work/1/s/azure-sdk-for-java/eng/mgmt/automation/generate_data.py", line 140, in get_cadl_sdk_folder
cmderr	[generate.py]     sdk_folder = project_yaml['options']['@azure-tools/typespec-java']['emitter-output-dir']
cmderr	[generate.py] KeyError: 'emitter-output-dir'
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-java]: ./eng/mgmt/automation/generate.py
warn	Skip package processing as generation is failed
warn		specification/cognitiveservices/OpenAI.Authoring/tspconfig.yaml skipped due to azure-sdk-for-java not found in tspconfig.yaml
warn		specification/cognitiveservices/OpenAI.Inference/tspconfig.yaml skipped due to azure-sdk-for-java not found in tspconfig.yaml
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] npm notice
cmderr	[generate.py] npm notice New major version of npm available! 8.19.4 -> 9.6.5
cmderr	[generate.py] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.5>
cmderr	[generate.py] npm notice Run `npm install -g npm@9.6.5` to update!
cmderr	[generate.py] npm notice

️✔️azure-ai-translation-text [View full logs] [Release SDK Changes]

pom.xml

warn	Skip command for failed context: ./eng/mgmt/automation/install_instruction.py ../azure-sdk-for-java_tmp/installInstructionInput.json ../azure-sdk-for-java_tmp/installInstructionOutput.json

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Code Generator Failed [Logs]Release - Generate from b64dd24. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn		specification/cognitiveservices/OpenAI.Authoring/tspconfig.yaml skipped due to azure-sdk-for-net-track2 not found in tspconfig.yaml
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:145
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 145 | �[0m         �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:759
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 759 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:145
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 145 | �[0m         �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mException: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:133
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 133 | �[0m             �[36;1mthrow "Not provide service name or namespace."�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mNot provide service name or namespace.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1
warn	Skip package processing as generation is failed

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b64dd24. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
warn		specification/cognitiveservices/AnomalyDetector/tspconfig.yaml skipped due to azure-sdk-for-js not found in tspconfig.yaml
warn		specification/cognitiveservices/OpenAI.Authoring/tspconfig.yaml skipped due to azure-sdk-for-js not found in tspconfig.yaml
warn		specification/cognitiveservices/OpenAI.Inference/tspconfig.yaml skipped due to azure-sdk-for-js not found in tspconfig.yaml
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure-rest/ai-translation-text [View full logs] [Release SDK Changes]
- azure-rest-ai-translation-text-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-19T00:14:47Z

Generated ApiView

Language	Package Name	ApiView Link
Python	azure-ai-anomalydetector	https://apiview.dev/Assemblies/Review/31ba969a83144d28b595140751e94322
Python	azure-ai-translation-text	https://apiview.dev/Assemblies/Review/31ba969a83144d28b595140751e94322
JavaScript	@azure-rest/ai-translation-text	Create ApiView failed. Please ask PR assignee for help

weshaggard

The change looks correct but we should also investigate the sdk generation failures as well. Are they also caused by a versioning mis-match or other known issues?

This reverts commit b64dd24.

* Delete package.json * Update to latest TSP deps * Remove all Data-Plane TSP package.json

Delete package.json

03db24c

lmazuel requested a review from yangyuan as a code owner April 19, 2023 00:14

openapi-assignment-bot bot assigned MaryGao Apr 19, 2023

ghost added the Cognitive Services label Apr 19, 2023

azure-sdk mentioned this pull request Apr 19, 2023

[AutoPR Azure.AI.AnomalyDetector] MVAD: Delete package.json azure-sdk/azure-sdk-for-net#3609

Closed

weshaggard approved these changes Apr 19, 2023

View reviewed changes

lmazuel added 2 commits April 19, 2023 10:04

Update to latest TSP deps

ba3a666

Remove all Data-Plane TSP package.json

501ff58

lmazuel changed the title ~~MVAD: Delete package.json~~ Delete Dataplane package.json and update to 0.43 Apr 19, 2023

lmazuel merged commit b64dd24 into main Apr 19, 2023

lmazuel deleted the no_package_mvad branch April 19, 2023 22:44

mikeharder added a commit to mikeharder/azure-rest-api-specs that referenced this pull request Apr 21, 2023

Revert "Delete Dataplane package.json and update to 0.43 (Azure#23618)"

d73bfe8

This reverts commit b64dd24.

suxi-ms pushed a commit that referenced this pull request Apr 24, 2023

Delete Dataplane package.json and update to 0.43 (#23618)

30bf326

* Delete package.json * Update to latest TSP deps * Remove all Data-Plane TSP package.json

JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023

Delete Dataplane package.json and update to 0.43 (Azure#23618)

7769d58

* Delete package.json * Update to latest TSP deps * Remove all Data-Plane TSP package.json

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete Dataplane package.json and update to 0.43#23618

Delete Dataplane package.json and update to 0.43#23618
lmazuel merged 3 commits intomainfrom
no_package_mvad

lmazuel commented Apr 19, 2023

Uh oh!

openapi-workflow-bot bot commented Apr 19, 2023

Uh oh!

openapi-pipeline-app bot commented Apr 19, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Apr 19, 2023 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Apr 19, 2023 •

edited

Loading

Uh oh!

weshaggard left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lmazuel commented Apr 19, 2023

Uh oh!

openapi-workflow-bot bot commented Apr 19, 2023

Uh oh!

openapi-pipeline-app bot commented Apr 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Apr 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Apr 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

weshaggard left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

openapi-pipeline-app bot commented Apr 19, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 19, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 19, 2023 •

edited

Loading