[ADLA - ADLS] - Adding pageable extension for Catalog ACL APIs and removing childrenNum property #2353
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2553,11 +2553,11 @@ | |
| "schema": { | ||
| "$ref": "#/definitions/AclList" | ||
| } | ||
| } | ||
| }, | ||
| "x-ms-pageable": { | ||
| "nextLinkName": "nextLink" | ||
| }, | ||
| "x-ms-odata": "#/definitions/Acl" | ||
| } | ||
| }, | ||
|
|
@@ -2628,11 +2628,11 @@ | |
| "schema": { | ||
| "$ref": "#/definitions/AclList" | ||
| } | ||
| } | ||
| }, | ||
| "x-ms-pageable": { | ||
| "nextLinkName": "nextLink" | ||
| }, | ||
| "x-ms-odata": "#/definitions/Acl" | ||
| } | ||
| }, | ||
|
|
@@ -2745,32 +2745,25 @@ | |
| } | ||
| }, | ||
| "x-ms-paths": { | ||
| "/catalog/usql/acl?op=GRANTACE": { | ||
| "post": { | ||
| "tags": [ | ||
| "Catalog" | ||
| ], | ||
| "operationId": "Catalog_GrantAcl", | ||
| "description": "Grants an access control list (ACL) entry to the Data Lake Analytics catalog.", | ||
| "x-ms-examples": { | ||
| "Grants an access control list (ACL) entry to the Data Lake Analytics catalog": { "$ref": "./examples/Adla_Catalog_GrantAcl.json" } | ||
| }, | ||
| "parameters": [ | ||
| { | ||
| "name": "parameters", | ||
| "in": "body", | ||
| "required": true, | ||
| "schema": { | ||
| "$ref": "#/definitions/AclCreateOrUpdateParameters" | ||
| }, | ||
| "description": "Parameters supplied to create or update an access control list (ACL) entry for a Data Lake Analytics catalog." | ||
| }, | ||
| { | ||
| "name": "op", | ||
|
|
@@ -2788,23 +2781,20 @@ | |
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "Successfully granted the access control list (ACL) entry to the Data Lake Analytics catalog." | ||
|
Member
There was a problem hiding this comment. Why we are removing the
Contributor
Author
There was a problem hiding this comment. @anuchandy This was to follow the the rest of the APIs in that file. These ACL APIs were the first ones that I added to this Swagger file. But now as I look at them, I see that |
||
| } | ||
| } | ||
| } | ||
| }, | ||
| "/catalog/usql/databases/{databaseName}/acl?op=GRANTACE": { | ||
| "post": { | ||
| "tags": [ | ||
| "Catalog" | ||
| ], | ||
| "operationId": "Catalog_GrantAclToDatabase", | ||
| "description": "Grants an access control list (ACL) entry to the database from the Data Lake Analytics catalog.", | ||
| "x-ms-examples": { | ||
| "Grants an access control list (ACL) entry to the database from the Data Lake Analytics catalog": { "$ref": "./examples/Adla_Catalog_GrantAclToDatabase.json" } | ||
| }, | ||
| "parameters": [ | ||
| { | ||
|
|
@@ -2819,9 +2809,9 @@ | |
| "in": "body", | ||
| "required": true, | ||
| "schema": { | ||
| "$ref": "#/definitions/AclCreateOrUpdateParameters" | ||
| }, | ||
| "description": "Parameters supplied to create or update an access control list (ACL) entry for a database." | ||
| }, | ||
| { | ||
| "name": "op", | ||
|
|
@@ -2830,7 +2820,7 @@ | |
| "type": "string", | ||
| "description": "The constant value for the operation.", | ||
| "enum": [ | ||
| "GRANTACE" | ||
| ] | ||
| }, | ||
| { | ||
|
|
@@ -2839,33 +2829,30 @@ | |
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "Successfully granted the access control list (ACL) entry to the specified database." | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "/catalog/usql/acl?op=REVOKEACE": { | ||
| "post": { | ||
| "tags": [ | ||
| "Catalog" | ||
| ], | ||
| "operationId": "Catalog_RevokeAcl", | ||
| "description": "Revokes an access control list (ACL) entry from the Data Lake Analytics catalog.", | ||
| "x-ms-examples": { | ||
| "Revokes an access control list (ACL) entry from the Data Lake Analytics catalog": { "$ref": "./examples/Adla_Catalog_RevokeAcl.json" } | ||
| }, | ||
| "parameters": [ | ||
| { | ||
| "name": "parameters", | ||
| "in": "body", | ||
| "required": true, | ||
| "schema": { | ||
| "$ref": "#/definitions/AclDeleteParameters" | ||
| }, | ||
| "description": "Parameters supplied to delete an access control list (ACL) entry from a Data Lake Analytics catalog." | ||
| }, | ||
| { | ||
| "name": "op", | ||
|
|
@@ -2874,7 +2861,7 @@ | |
| "type": "string", | ||
| "description": "The constant value for the operation.", | ||
| "enum": [ | ||
| "REVOKEACE" | ||
| ] | ||
| }, | ||
| { | ||
|
|
@@ -2883,33 +2870,37 @@ | |
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "Successfully revoked the access control list (ACL) entry from the Data Lake Analytics catalog." | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "/catalog/usql/databases/{databaseName}/acl?op=REVOKEACE": { | ||
| "post": { | ||
| "tags": [ | ||
| "Catalog" | ||
| ], | ||
| "operationId": "Catalog_RevokeAclFromDatabase", | ||
| "description": "Revokes an access control list (ACL) entry for the database from the Data Lake Analytics catalog.", | ||
| "x-ms-examples": { | ||
| "Revokes an access control list (ACL) entry for the database from the Data Lake Analytics catalog": { "$ref": "./examples/Adla_Catalog_RevokeAclFromDatabase.json" } | ||
| }, | ||
| "parameters": [ | ||
| { | ||
| "name": "databaseName", | ||
| "in": "path", | ||
| "required": true, | ||
| "type": "string", | ||
| "description": "The name of the database." | ||
| }, | ||
| { | ||
| "name": "parameters", | ||
| "in": "body", | ||
| "required": true, | ||
| "schema": { | ||
| "$ref": "#/definitions/AclDeleteParameters" | ||
| }, | ||
| "description": "Parameters supplied to delete an access control list (ACL) entry for a database." | ||
| }, | ||
| { | ||
| "name": "op", | ||
|
|
@@ -2927,10 +2918,7 @@ | |
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "Successfully revoked the access control list (ACL) entry from the specified database." | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -3059,6 +3047,11 @@ | |
| "description": "A Data Lake Analytics catalog access control list (ACL) entry." | ||
| }, | ||
| "AclList": { | ||
| "allOf": [ | ||
| { | ||
| "$ref": "#/definitions/CatalogItemList" | ||
| } | ||
| ], | ||
| "properties": { | ||
| "value": { | ||
| "type": "array", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,8 +10,6 @@ | |
| }, | ||
| "responses": { | ||
| "200": { | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,8 +11,6 @@ | |
| }, | ||
| "responses": { | ||
| "200": { | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,8 +9,6 @@ | |
| }, | ||
| "responses": { | ||
| "200": { | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,8 +10,6 @@ | |
| }, | ||
| "responses": { | ||
| "200": { | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[For the record] Looking at the diff, at first glance it may appear that there are breaking changes in the following endpoints defs but not really - they appear so due to re-ordering of the operations in the swagger.
@ro-joowan if possible, for future PRs it will be very helpful if we can ensure that PR shows only the changed sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anuchandy, Noted :) I should've put that part in a separate commit. Sorry about that!