Fixes for 2023-04-01-preview API version

[pratyush-prateek]

Data Plane API - Pull Request

• Fixes for new API version 2023-04-01, a continuation of this PR - [Agrifood] Adding new API version 2023-04-01-preview #23265
• Renaming shapeFileType to shapeType and shapeFileResolution to shapeResolution post bugbash and discussion with PMs.

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your engagement record.

• Link to engagement record issue: [Agrifood ] API Review - Adding client id and client secret parameter #23007

Is this review for (select one):

• a private preview
• a public preview
• GA release

Change Scope

^{This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.}

• Design Document:
• Previous Open API Doc:
• Updated paths:

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

• 💬 Teams Channel
• 💌 email

Click here for links to tools, specs, guidelines & other good stuff

Tooling

• Open API validation tools were run on this PR. Go here to see how to fix errors
• Spectral Linting
• Open API Hub

Guidelines & Specifications

• Azure REST API Guidelines
• OpenAPI Style Guidelines
• Azure Breaking Change Policy

Helpful Links

• Azure DevTools Wiki

[openapi-workflow-bot]

Hi, @pratyush-prateek Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

[openapi-pipeline-app]

Swagger Validation Report

️❌BreakingChange: 8 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
agfood.json	2023-04-01-preview(26220fb)	2023-04-01-preview(main)

Rule	Message
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'ShapeFileResolution' removed or renamed? New: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L18097:3 Old: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L18097:3
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'ShapeFileType' removed or renamed? New: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L18097:3 Old: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L18097:3
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'shapeFileType' renamed or removed? New: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L19852:7 Old: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L19852:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'shapeFileResolution' renamed or removed? New: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L19852:7 Old: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L19852:7
❌ 1034 - AddedRequiredProperty	The new version has new required property 'shapeType' that was not found in the old version. New: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L19852:7 Old: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L19852:7
❌ 1034 - AddedRequiredProperty	The new version has new required property 'shapeResolution' that was not found in the old version. New: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L19852:7 Old: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L19852:7
❌ 1034 - AddedRequiredProperty	The new version has new required property 'shapeResolution, shapeType' that was not found in the old version. New: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L19759:9 Old: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L19759:9
❌ 1034 - AddedRequiredProperty	The new version has new required property 'shapeResolution, shapeType' that was not found in the old version. New: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L19845:5 Old: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L19845:5

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2023-04-01-preview	package-2023-04-01-preview(26220fb)	package-2023-04-01-preview(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
❌ AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L16042
❌ AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L16110
❌ AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L16182
⚠️ OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ApplicationDataModel'. Consider using the plural form of 'ApplicationData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L15
⚠️ ErrorResponse	The error property in the error response schema should be required. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L225
⚠️ OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ApplicationDataModel'. Consider using the plural form of 'ApplicationData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L253
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L258
⚠️ LroHeaders	A 202 response should include an Operation-Location response header. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L288
⚠️ ErrorResponse	The error property in the error response schema should be required. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L296
⚠️ OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ApplicationDataModel'. Consider using the plural form of 'ApplicationData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L323
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L328
⚠️ ErrorResponse	The error property in the error response schema should be required. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L352
⚠️ OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ApplicationDataModel'. Consider using the plural form of 'ApplicationData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L377
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L382
⚠️ ErrorResponse	The error property in the error response schema should be required. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L594
⚠️ OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ApplicationDataModel'. Consider using the plural form of 'ApplicationData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L622
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L627
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L634
⚠️ ErrorResponse	The error property in the error response schema should be required. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L658
⚠️ OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ApplicationDataModel'. Consider using the plural form of 'ApplicationData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L681
⚠️ PatchInOperationName	'PATCH' operation 'ApplicationData_CreateOrUpdate' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L681
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L689
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L696
⚠️ ErrorResponse	The error property in the error response schema should be required. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L723
⚠️ OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ApplicationDataModel'. Consider using the plural form of 'ApplicationData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L758
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L763
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L770
⚠️ ErrorResponse	The error property in the error response schema should be required. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L791
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L821
⚠️ ErrorResponse	The error property in the error response schema should be required. Location: Microsoft.AgFoodPlatform/preview/2023-04-01-preview/agfood.json#L949

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account. 

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-java warning [Detail]

• ⚠️Warning [Logs]Release - Generate from b32028a. SDK Automation 14.0.0

  command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
  command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  warn	No file changes detected after generation
  warn	No package detected after generation

_{Posted by Swagger Pipeline | How to fix these errors?}

[ghost]

Thank you for your contribution pratyush-prateek! We will review the pull request and get back to you soon.

[openapi-pipeline-app]

Generated ApiView

Language	Package Name	ApiView Link
Swagger	Microsoft.AgFoodPlatform	https://apiview.dev/Assemblies/Review/243934a542aa4a8598dad051064647fa

[openapi-workflow-bot]

Hi @pratyush-prateek, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

[mikekistler]

Approved breaking changes as this version has not yet been make available to customers.