Carry all minor changes to dev sql microsoft.sql 2022 11 01 preview#23337
Merged
raych1 merged 7 commits intoAzure:release-sql-Microsoft.Sql-2022-11-01-previewfrom Apr 13, 2023
jeremyfrosti:jeremyfrosti-minor-release-sql-Microsoft.Sql-2022-11-01-preview
Merged
Carry all minor changes to dev sql microsoft.sql 2022 11 01 preview#23337raych1 merged 7 commits intoAzure:release-sql-Microsoft.Sql-2022-11-01-previewfrom jeremyfrosti:jeremyfrosti-minor-release-sql-Microsoft.Sql-2022-11-01-preview
raych1 merged 7 commits intoAzure:release-sql-Microsoft.Sql-2022-11-01-previewfrom
jeremyfrosti:jeremyfrosti-minor-release-sql-Microsoft.Sql-2022-11-01-preview
Conversation
|
Hi, @jeremyfrosti Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
Swagger Generation Artifacts
|
ghost
added
the
Generated ApiView
|
jeremyfrosti
changed the title
This was referenced Mar 29, 2023
This was referenced Mar 29, 2023
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @jeremyfrosti, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @jeremyfrosti, Your PR has some issues. Please fix the CI sequentially by following the order of
|
raych1
reviewed
Mar 29, 2023
| "items": { | ||
| "$ref": "#/definitions/PrivateEndpointConnectionRequestStatus" | ||
| }, | ||
| "x-ms-identifiers": [], |
Member
|
@jeremyfrosti , this PR includes a lot of files and it's hard to review the changes. Can you elaborate the changes? Are they just description change and re-order the models in swagger? @ericshape , do you have idea of better showing the diffs? |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
yea. we are addressing some issues in the PR @raych1 can you have a look at the breaking change page? it seems the display of Breaking Change(Cross-Version) has an issue. |
Member
|
@jeremyfrosti, you could also use this command to trigger the pipeline if it is stuck.
|
Member
|
@ericshape , check the build log which has the breaking change details. For rendering issue, can you raise the issue in this tool support channel. |
Member
Author
|
@raych1 On one of the build issues, we are getting a TypeFormatChange because a double was changed to an int. While this makes sense for the breaking change, it seems that the comparison is to 2021-11-01, and when I check 2022-08-01-preview, this change was already made. I wouldn't expect a breaking change then? Am I missing something here?
|
Member
@jeremyfrosti , there're other breaking changes reported and needs the breaking change board review. |
Swagger Validation Report
|
… Jobs.json,ServerDevOpsAudit.json, and TransparentDataEncryptions.json
ericshape
approved these changes
Apr 5, 2023
AzureRestAPISpecReview
removed
the
BreakingChangeReviewRequired
Member
Author
|
@raych1 Could you give this PR a review now? We have resolved the breaking change issue. These changes are mostly just description changes and some example file updates. |
Member
Author
|
@raych1 Gentle ping on this |
raych1
reviewed
Apr 11, 2023
| } | ||
| }, | ||
| "definitions": { | ||
| "BaseLongTermRetentionPolicyProperties": { |
Member
There was a problem hiding this comment.
model name change might cause SDK breaking change. This model also removes a property comparing to previous model.
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@weidongxu-microsoft @msyyc @tadelesh , can you review the potential SDK breaking change? |
Member
|
@raych1 It's hard to distinguish all the breakings for such composite tag. I'll approve the breaking since it is a preview version, but we need to figure out what is the best way to deal with such PR. |
tadelesh
added
the
Approved-SdkBreakingChange-Go
raych1
approved these changes
Apr 13, 2023
11 tasks
raych1
pushed a commit
that referenced
this pull request
May 19, 2023
* Adds base for updating Microsoft.Sql from version preview/2022-08-01-preview to version 2022-11-01-preview * Updates readme * Updates API version in new specs and examples * Add Swagger API changes required for progress-reporting related changes in DatabaseOperations (#22669) * Update swagger (#22715) * Follow-up Swagger API changes required for progress-reporting related changes in DatabaseOperations (#22775) * Add Swagger API changes required for progress-reporting related changes in DatabaseOperations * Follow up changes required for progress-reporting related changes in DatabaseOperations * updated example file * Added Failed case in list-operations examples * Update Microsoft.Sql ManagedInstance 2022-11-01-preview Swagger Docs (#22899) * Update Microsoft.sql ManagedInstance 2022-11-01-preview Swagger Docs * Address Swagger Validation Errors * Modify custom-words.txt * Manually updating arm-id format to match stable 2021-11-01 version * Adding provisioning state changes * fixing validation * adding missing space * Remove HTTP 200 from Start/Stop Actions as we only return HTTP 202 --------- Co-authored-by: Jovana Toroman <jtoroman@microsoft.com> * Update DateTime to ISO-8601 format in example file (#22986) * Add Swagger API changes required for progress-reporting related changes in DatabaseOperations * Follow up changes required for progress-reporting related changes in DatabaseOperations * updated example file * Added Failed case in list-operations examples * Update DateTime to ISo-8601 format in example file * Enable TryPlannedBeforeForcedFailover for SQL DB Failover Group (#22673) * Enable TryPlannedBeforeForcedFailover for SQL DB Failover Group * Modify example file * Add example * Fix ModelValidation issues * Fix ModelValidation issues * Add new controller * Modify example * Modify example * Update server name * Fix LintDiff * Fix model validation errors * Fix PostOperationAsyncResponseValidation, Unfix LroLocationHeader,ResourceNameRestriction * Fix PostOperationAsyncResponseValidation * Fix pending items * Update doc * Remove empty/unschematized object --------- Co-authored-by: subhrob <subhrob@microsoft.com> * [DO NOT MERGE] Add Archive option to LTR Policy for SQL DB (#22697) * add archival changes to LTRPolicy * fix LongTermRetentionPolicies swagger file * fix check failures * redo swagger * Update swagger documentation for Managed Instance start-stop actions (#22992) * Add NetworkSecurityPerimeterConfigurations Swagger (#22960) * Add NetworkSecurityPerimeterConfigurations Swagger * Fixes round 1 * Fixes round 2 * Fixes Round 3 * Fixes Round 4 * Fix Round 5 * fixing enum (#22995) Co-authored-by: Jovana Toroman <jtoroman@microsoft.com> * add changes (#23120) * Carry all minor changes to dev sql microsoft.sql 2022 11 01 preview (#23337) * Revert "add changes (#23120)" This reverts commit 5c348d2. Revert "[DO NOT MERGE] Add Archive option to LTR Policy for SQL DB (#22697)" This reverts commit 559f7f4. * Carrying minor changes to release branch for Microsoft.Sql 2022-11-01-preview * Reverting DatabaseAdvisors * Further reverting problematic files * Reverting a few example files * Adding back arm-id to a few files * Reverting error message change in ManagedDatabaseRestoreDetails.json, Jobs.json,ServerDevOpsAudit.json, and TransparentDataEncryptions.json * Minor fixes for Turkey name change and missing x-ms-identifier (#23637) * Fixing issues with a few breaking changes (#23943) * Minor fixes for Turkey name change and missing x-ms-identifier * Adding back missing arm-id and other missing property issues causing breaking changes incorrectly. * Fixing prettier issue with ManagedDatabases.json * Fixing arm-id format in 4 examples * Adding missing location for 202 responses on sync examples --------- Co-authored-by: Ji Wang <wangjiprc@gmail.com> Co-authored-by: Mohit Agarwal <mohitagarwal@microsoft.com> Co-authored-by: GalGoldi72 <124780962+GalGoldi72@users.noreply.github.com> Co-authored-by: ilijadivljan-ms <122982104+ilijadivljan-ms@users.noreply.github.com> Co-authored-by: Jovana Toroman <jtoroman@microsoft.com> Co-authored-by: subhrob <subhro.bhattacharya@gmail.com> Co-authored-by: subhrob <subhrob@microsoft.com> Co-authored-by: CelinaJiangJXY <124339390+CelinaJiangJXY@users.noreply.github.com> Co-authored-by: beoberha <51964155+beoberha@users.noreply.github.com> Co-authored-by: toki95 <35834415+toki95@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.