Skip to content

Added UMC operations#23320

Merged
dorothyhu merged 2 commits intodorothyhu-hybridcompute-Microsoft.HybridCompute-2022-12-27from
assing-hcrp-umc-2
Mar 30, 2023
Merged

Added UMC operations#23320
dorothyhu merged 2 commits intodorothyhu-hybridcompute-Microsoft.HybridCompute-2022-12-27from
assing-hcrp-umc-2

Conversation

@assing
Copy link
Contributor

@assing assing commented Mar 28, 2023

No description provided.

Added UMC operations
@openapi-workflow-bot
Copy link

Hi, @assing Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 28, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 10 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    HybridCompute.json 2022-12-27(9dc6c8c) 2022-11-10(main)
    HybridCompute.json 2022-12-27(9dc6c8c) 2022-12-27-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L54:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L54:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L110:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L107:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L166:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L160:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L213:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L204:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L486:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L339:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L553:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L403:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L635:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L482:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L708:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L552:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L764:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L605:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L829:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L667:11
    ️⚠️LintDiff: 3 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-12 package-2022-12(9dc6c8c) package-2022-12(dorothyhu-hybridcompute-Microsoft.HybridCompute-2022-12-27)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L2021
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L2226
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L2315


    The following errors/warnings exist before current PR submission:

    Rule Message
    ResourceNameRestriction The resource name parameter 'extensionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L475
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L476
    LongRunningResponseStatusCode A 'put' operation 'MachineExtensions_CreateOrUpdate' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L476
    CreateOperationAsyncResponseValidation An async PUT operation must return 201.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L519
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L526
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L526
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L625
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L813
    BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'Machine' has extra properties ['resources'].
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L1632
    ArmResourcePropertiesBag Top level property names should not be repeated inside the properties bag for ARM resource 'MachineExtension'. Properties [properties.type] conflict with ARM top level properties. Please rename these.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L1711
    ⚠️ PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Machines_CreateOrUpdate' Request Model: 'parameters[4].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L38
    ⚠️ PageableOperation Based on the response model schema, operation 'Machines_Get' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L197
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List Machines by resource group
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L465
    ⚠️ PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'MachineExtensions_CreateOrUpdate' Request Model: 'parameters[3].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L476
    ⚠️ XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L476
    ⚠️ XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L543
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Create or Update a Machine Extension
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L618
    ⚠️ XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L625
    ⚠️ XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L813
    ⚠️ PageableOperation Based on the response model schema, operation 'NetworkProfile_Get' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L1047
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'NetworkProfileModel'. Consider using the plural form of 'NetworkProfile' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L1051
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L1181
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L1382
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L1762
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L1766
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L1811
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L1815
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 4 Errors, 0 Warnings failed [Detail]
    Rule Message
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L293:22
    ExampleUrl: stable/2022-12-27/examples/MachineAssessPatches.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L365:22
    ExampleUrl: stable/2022-12-27/examples/MachineInstallPatches.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L293:22
    ExampleUrl: stable/2022-12-27/examples/MachineAssessPatches.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L365:22
    ExampleUrl: stable/2022-12-27/examples/MachineInstallPatches.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌PrettierCheck: 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    HowToFix Code style issues found
    path: stable/2022-12-27/examples/MachineAssessPatches.json
    HowToFix Code style issues found
    path: stable/2022-12-27/examples/MachineInstallPatches.json
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 28, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking


    ⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-hybridcompute - 8.0.0
    +	Model Machine no longer has parameter properties
    +	Model MachineExtension no longer has parameter properties
    +	Model MachineExtensionUpdate no longer has parameter properties
    +	Model MachineUpdate no longer has parameter properties
    ⚠️azure-sdk-for-js - @azure/arm-hybridcompute - 4.0.0
    +	Interface MachineExtensionsListNextOptionalParams no longer has parameter expand
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs] Generate from aba2fae66fa2df181d73f799b006dcf347012639. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:671
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 671 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:759
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 759 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:671
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 671 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.HybridCompute [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from aba2fae66fa2df181d73f799b006dcf347012639. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.2` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-hybridcompute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation MachinesOperations.begin_assess_patches
      info	[Changelog]   - Added operation MachinesOperations.begin_install_patches
      info	[Changelog]   - Added operation group ExtensionMetadataOperations
      info	[Changelog]   - Added operation group NetworkProfileOperations
      info	[Changelog]   - Model AgentConfiguration has a new parameter config_mode
      info	[Changelog]   - Model Machine has a new parameter ad_fqdn
      info	[Changelog]   - Model Machine has a new parameter agent_configuration
      info	[Changelog]   - Model Machine has a new parameter agent_upgrade
      info	[Changelog]   - Model Machine has a new parameter agent_version
      info	[Changelog]   - Model Machine has a new parameter client_public_key
      info	[Changelog]   - Model Machine has a new parameter cloud_metadata
      info	[Changelog]   - Model Machine has a new parameter detected_properties
      info	[Changelog]   - Model Machine has a new parameter display_name
      info	[Changelog]   - Model Machine has a new parameter dns_fqdn
      info	[Changelog]   - Model Machine has a new parameter domain_name
      info	[Changelog]   - Model Machine has a new parameter error_details
      info	[Changelog]   - Model Machine has a new parameter extensions
      info	[Changelog]   - Model Machine has a new parameter last_status_change
      info	[Changelog]   - Model Machine has a new parameter location_data
      info	[Changelog]   - Model Machine has a new parameter machine_fqdn
      info	[Changelog]   - Model Machine has a new parameter mssql_discovered
      info	[Changelog]   - Model Machine has a new parameter os_name
      info	[Changelog]   - Model Machine has a new parameter os_profile
      info	[Changelog]   - Model Machine has a new parameter os_sku
      info	[Changelog]   - Model Machine has a new parameter os_type
      info	[Changelog]   - Model Machine has a new parameter os_version
      info	[Changelog]   - Model Machine has a new parameter parent_cluster_resource_id
      info	[Changelog]   - Model Machine has a new parameter private_link_scope_resource_id
      info	[Changelog]   - Model Machine has a new parameter provisioning_state
      info	[Changelog]   - Model Machine has a new parameter resources
      info	[Changelog]   - Model Machine has a new parameter service_statuses
      info	[Changelog]   - Model Machine has a new parameter status
      info	[Changelog]   - Model Machine has a new parameter vm_id
      info	[Changelog]   - Model Machine has a new parameter vm_uuid
      info	[Changelog]   - Model MachineExtension has a new parameter auto_upgrade_minor_version
      info	[Changelog]   - Model MachineExtension has a new parameter enable_automatic_upgrade
      info	[Changelog]   - Model MachineExtension has a new parameter force_update_tag
      info	[Changelog]   - Model MachineExtension has a new parameter instance_view
      info	[Changelog]   - Model MachineExtension has a new parameter protected_settings
      info	[Changelog]   - Model MachineExtension has a new parameter provisioning_state
      info	[Changelog]   - Model MachineExtension has a new parameter publisher
      info	[Changelog]   - Model MachineExtension has a new parameter settings
      info	[Changelog]   - Model MachineExtension has a new parameter type_handler_version
      info	[Changelog]   - Model MachineExtension has a new parameter type_properties_type
      info	[Changelog]   - Model MachineExtensionUpdate has a new parameter auto_upgrade_minor_version
      info	[Changelog]   - Model MachineExtensionUpdate has a new parameter enable_automatic_upgrade
      info	[Changelog]   - Model MachineExtensionUpdate has a new parameter force_update_tag
      info	[Changelog]   - Model MachineExtensionUpdate has a new parameter protected_settings
      info	[Changelog]   - Model MachineExtensionUpdate has a new parameter publisher
      info	[Changelog]   - Model MachineExtensionUpdate has a new parameter settings
      info	[Changelog]   - Model MachineExtensionUpdate has a new parameter type
      info	[Changelog]   - Model MachineExtensionUpdate has a new parameter type_handler_version
      info	[Changelog]   - Model MachineUpdate has a new parameter agent_upgrade
      info	[Changelog]   - Model MachineUpdate has a new parameter cloud_metadata
      info	[Changelog]   - Model MachineUpdate has a new parameter location_data
      info	[Changelog]   - Model MachineUpdate has a new parameter os_profile
      info	[Changelog]   - Model MachineUpdate has a new parameter parent_cluster_resource_id
      info	[Changelog]   - Model MachineUpdate has a new parameter private_link_scope_resource_id
      info	[Changelog]   - Model ProxyResource has a new parameter system_data
      info	[Changelog]   - Model Resource has a new parameter system_data
      info	[Changelog]   - Model TrackedResource has a new parameter system_data
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model Machine no longer has parameter properties
      info	[Changelog]   - Model MachineExtension no longer has parameter properties
      info	[Changelog]   - Model MachineExtensionUpdate no longer has parameter properties
      info	[Changelog]   - Model MachineUpdate no longer has parameter properties
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from aba2fae66fa2df181d73f799b006dcf347012639. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/hybridcompute/armhybridcompute [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `AgentConfigurationMode` with values `AgentConfigurationModeFull`, `AgentConfigurationModeMonitor`
      info	[Changelog] - New enum type `LastAttemptStatusEnum` with values `LastAttemptStatusEnumFailed`, `LastAttemptStatusEnumSuccess`
      info	[Changelog] - New enum type `OsType` with values `OsTypeLinux`, `OsTypeWindows`
      info	[Changelog] - New enum type `PatchOperationStartedBy` with values `PatchOperationStartedByPlatform`, `PatchOperationStartedByUser`
      info	[Changelog] - New enum type `PatchOperationStatus` with values `PatchOperationStatusCompletedWithWarnings`, `PatchOperationStatusFailed`, `PatchOperationStatusInProgress`, `PatchOperationStatusSucceeded`, `PatchOperationStatusUnknown`
      info	[Changelog] - New enum type `PatchServiceUsed` with values `PatchServiceUsedAPT`, `PatchServiceUsedUnknown`, `PatchServiceUsedWU`, `PatchServiceUsedWUWSUS`, `PatchServiceUsedYUM`, `PatchServiceUsedZypper`
      info	[Changelog] - New enum type `VMGuestPatchClassificationLinux` with values `VMGuestPatchClassificationLinuxCritical`, `VMGuestPatchClassificationLinuxOther`, `VMGuestPatchClassificationLinuxSecurity`
      info	[Changelog] - New enum type `VMGuestPatchClassificationWindows` with values `VMGuestPatchClassificationWindowsCritical`, `VMGuestPatchClassificationWindowsDefinition`, `VMGuestPatchClassificationWindowsFeaturePack`, `VMGuestPatchClassificationWindowsSecurity`, `VMGuestPatchClassificationWindowsServicePack`, `VMGuestPatchClassificationWindowsTools`, `VMGuestPatchClassificationWindowsUpdateRollUp`, `VMGuestPatchClassificationWindowsUpdates`
      info	[Changelog] - New enum type `VMGuestPatchRebootSetting` with values `VMGuestPatchRebootSettingAlways`, `VMGuestPatchRebootSettingIfRequired`, `VMGuestPatchRebootSettingNever`
      info	[Changelog] - New enum type `VMGuestPatchRebootStatus` with values `VMGuestPatchRebootStatusCompleted`, `VMGuestPatchRebootStatusFailed`, `VMGuestPatchRebootStatusNotNeeded`, `VMGuestPatchRebootStatusRequired`, `VMGuestPatchRebootStatusStarted`, `VMGuestPatchRebootStatusUnknown`
      info	[Changelog] - New function `NewClientFactory(string, azcore.TokenCredential, *arm.ClientOptions) (*ClientFactory, error)`
      info	[Changelog] - New function `*ClientFactory.NewExtensionMetadataClient() *ExtensionMetadataClient`
      info	[Changelog] - New function `*ClientFactory.NewMachineExtensionsClient() *MachineExtensionsClient`
      info	[Changelog] - New function `*ClientFactory.NewMachinesClient() *MachinesClient`
      info	[Changelog] - New function `*ClientFactory.NewManagementClient() *ManagementClient`
      info	[Changelog] - New function `*ClientFactory.NewNetworkProfileClient() *NetworkProfileClient`
      info	[Changelog] - New function `*ClientFactory.NewOperationsClient() *OperationsClient`
      info	[Changelog] - New function `*ClientFactory.NewPrivateEndpointConnectionsClient() *PrivateEndpointConnectionsClient`
      info	[Changelog] - New function `*ClientFactory.NewPrivateLinkResourcesClient() *PrivateLinkResourcesClient`
      info	[Changelog] - New function `*ClientFactory.NewPrivateLinkScopesClient() *PrivateLinkScopesClient`
      info	[Changelog] - New function `NewExtensionMetadataClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ExtensionMetadataClient, error)`
      info	[Changelog] - New function `*ExtensionMetadataClient.Get(context.Context, string, string, string, string, *ExtensionMetadataClientGetOptions) (ExtensionMetadataClientGetResponse, error)`
      info	[Changelog] - New function `*ExtensionMetadataClient.NewListPager(string, string, string, *ExtensionMetadataClientListOptions) *runtime.Pager[ExtensionMetadataClientListResponse]`
      info	[Changelog] - New function `*MachinesClient.BeginAssessPatches(context.Context, string, string, *MachinesClientBeginAssessPatchesOptions) (*runtime.Poller[MachinesClientAssessPatchesResponse], error)`
      info	[Changelog] - New function `*MachinesClient.BeginInstallPatches(context.Context, string, string, MachineInstallPatchesParameters, *MachinesClientBeginInstallPatchesOptions) (*runtime.Poller[MachinesClientInstallPatchesResponse], error)`
      info	[Changelog] - New function `NewNetworkProfileClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkProfileClient, error)`
      info	[Changelog] - New function `*NetworkProfileClient.Get(context.Context, string, string, *NetworkProfileClientGetOptions) (NetworkProfileClientGetResponse, error)`
      info	[Changelog] - New struct `AgentUpgrade`
      info	[Changelog] - New struct `AvailablePatchCountByClassification`
      info	[Changelog] - New struct `ClientFactory`
      info	[Changelog] - New struct `ErrorDetailAutoGenerated`
      info	[Changelog] - New struct `ErrorResponseAutoGenerated`
      info	[Changelog] - New struct `ExtensionValue`
      info	[Changelog] - New struct `ExtensionValueListResult`
      info	[Changelog] - New struct `ExtensionValueProperties`
      info	[Changelog] - New struct `IPAddress`
      info	[Changelog] - New struct `LinuxParameters`
      info	[Changelog] - New struct `MachineAssessPatchesResult`
      info	[Changelog] - New struct `MachineInstallPatchesParameters`
      info	[Changelog] - New struct `MachineInstallPatchesResult`
      info	[Changelog] - New struct `NetworkInterface`
      info	[Changelog] - New struct `NetworkProfile`
      info	[Changelog] - New struct `Subnet`
      info	[Changelog] - New struct `WindowsParameters`
      info	[Changelog] - New field `ConfigMode` in struct `AgentConfiguration`
      info	[Changelog] - New field `Resources` in struct `Machine`
      info	[Changelog] - New field `EnableAutomaticUpgrade` in struct `MachineExtensionUpdateProperties`
      info	[Changelog] - New field `AgentUpgrade` in struct `MachineProperties`
      info	[Changelog] - New field `AgentUpgrade` in struct `MachineUpdateProperties`
      info	[Changelog] - New field `SystemData` in struct `ProxyResource`
      info	[Changelog] - New field `SystemData` in struct `Resource`
      info	[Changelog] - New field `SystemData` in struct `TrackedResource`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 108 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from aba2fae66fa2df181d73f799b006dcf347012639. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-hybridcompute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group ExtensionMetadata
      info	[Changelog]   - Added operation group NetworkProfileOperations
      info	[Changelog]   - Added operation Machines.beginAssessPatches
      info	[Changelog]   - Added operation Machines.beginAssessPatchesAndWait
      info	[Changelog]   - Added operation Machines.beginInstallPatches
      info	[Changelog]   - Added operation Machines.beginInstallPatchesAndWait
      info	[Changelog]   - Added Interface AgentConfiguration
      info	[Changelog]   - Added Interface AgentUpgrade
      info	[Changelog]   - Added Interface AvailablePatchCountByClassification
      info	[Changelog]   - Added Interface CloudMetadata
      info	[Changelog]   - Added Interface ConfigurationExtension
      info	[Changelog]   - Added Interface ErrorDetailAutoGenerated
      info	[Changelog]   - Added Interface ErrorResponseAutoGenerated
      info	[Changelog]   - Added Interface ExtensionMetadataGetOptionalParams
      info	[Changelog]   - Added Interface ExtensionMetadataListOptionalParams
      info	[Changelog]   - Added Interface ExtensionValue
      info	[Changelog]   - Added Interface ExtensionValueListResult
      info	[Changelog]   - Added Interface HybridComputeManagementClientUpgradeExtensionsHeaders
      info	[Changelog]   - Added Interface HybridComputePrivateLinkScope
      info	[Changelog]   - Added Interface IpAddress
      info	[Changelog]   - Added Interface LinuxParameters
      info	[Changelog]   - Added Interface Machine
      info	[Changelog]   - Added Interface MachineAssessPatchesResult
      info	[Changelog]   - Added Interface MachineExtension
      info	[Changelog]   - Added Interface MachineExtensionsDeleteHeaders
      info	[Changelog]   - Added Interface MachineExtensionsUpdateHeaders
      info	[Changelog]   - Added Interface MachineExtensionUpdate
      info	[Changelog]   - Added Interface MachineInstallPatchesParameters
      info	[Changelog]   - Added Interface MachineInstallPatchesResult
      info	[Changelog]   - Added Interface MachinesAssessPatchesHeaders
      info	[Changelog]   - Added Interface MachinesAssessPatchesOptionalParams
      info	[Changelog]   - Added Interface MachinesInstallPatchesHeaders
      info	[Changelog]   - Added Interface MachinesInstallPatchesOptionalParams
      info	[Changelog]   - Added Interface MachineUpdate
      info	[Changelog]   - Added Interface NetworkInterface
      info	[Changelog]   - Added Interface NetworkProfile
      info	[Changelog]   - Added Interface NetworkProfileGetOptionalParams
      info	[Changelog]   - Added Interface OSProfileLinuxConfiguration
      info	[Changelog]   - Added Interface OSProfileWindowsConfiguration
      info	[Changelog]   - Added Interface PrivateEndpointConnection
      info	[Changelog]   - Added Interface PrivateEndpointConnectionDataModel
      info	[Changelog]   - Added Interface PrivateEndpointConnectionsDeleteHeaders
      info	[Changelog]   - Added Interface PrivateLinkResource
      info	[Changelog]   - Added Interface PrivateLinkScopesDeleteHeaders
      info	[Changelog]   - Added Interface ProxyResource
      info	[Changelog]   - Added Interface ServiceStatus
      info	[Changelog]   - Added Interface ServiceStatuses
      info	[Changelog]   - Added Interface Subnet
      info	[Changelog]   - Added Interface TrackedResource
      info	[Changelog]   - Added Interface WindowsParameters
      info	[Changelog]   - Added Type Alias AgentConfigurationMode
      info	[Changelog]   - Added Type Alias AssessmentModeTypes
      info	[Changelog]   - Added Type Alias ExtensionMetadataGetResponse
      info	[Changelog]   - Added Type Alias ExtensionMetadataListResponse
      info	[Changelog]   - Added Type Alias LastAttemptStatusEnum
      info	[Changelog]   - Added Type Alias MachinesAssessPatchesResponse
      info	[Changelog]   - Added Type Alias MachinesInstallPatchesResponse
      info	[Changelog]   - Added Type Alias NetworkProfileGetResponse
      info	[Changelog]   - Added Type Alias OsType
      info	[Changelog]   - Added Type Alias PatchModeTypes
      info	[Changelog]   - Added Type Alias PatchOperationStartedBy
      info	[Changelog]   - Added Type Alias PatchOperationStatus
      info	[Changelog]   - Added Type Alias PatchServiceUsed
      info	[Changelog]   - Added Type Alias VMGuestPatchClassificationLinux
      info	[Changelog]   - Added Type Alias VMGuestPatchClassificationWindows
      info	[Changelog]   - Added Type Alias VMGuestPatchRebootSetting
      info	[Changelog]   - Added Type Alias VMGuestPatchRebootStatus
      info	[Changelog]   - Interface HybridComputePrivateLinkScopeProperties has a new optional parameter privateEndpointConnections
      info	[Changelog]   - Interface OperationValue has a new optional parameter isDataAction
      info	[Changelog]   - Interface OSProfile has a new optional parameter linuxConfiguration
      info	[Changelog]   - Interface OSProfile has a new optional parameter windowsConfiguration
      info	[Changelog]   - Interface PrivateEndpointConnectionProperties has a new optional parameter groupIds
      info	[Changelog]   - Interface Resource has a new optional parameter systemData
      info	[Changelog]   - Added Enum KnownAgentConfigurationMode
      info	[Changelog]   - Added Enum KnownAssessmentModeTypes
      info	[Changelog]   - Added Enum KnownLastAttemptStatusEnum
      info	[Changelog]   - Added Enum KnownOsType
      info	[Changelog]   - Added Enum KnownPatchModeTypes
      info	[Changelog]   - Added Enum KnownPatchOperationStartedBy
      info	[Changelog]   - Added Enum KnownPatchOperationStatus
      info	[Changelog]   - Added Enum KnownPatchServiceUsed
      info	[Changelog]   - Added Enum KnownVMGuestPatchClassificationLinux
      info	[Changelog]   - Added Enum KnownVMGuestPatchClassificationWindows
      info	[Changelog]   - Added Enum KnownVMGuestPatchRebootSetting
      info	[Changelog]   - Added Enum KnownVMGuestPatchRebootStatus
      info	[Changelog]   - Added function getContinuationToken
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface MachineExtensionsListNextOptionalParams no longer has parameter expand
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from aba2fae66fa2df181d73f799b006dcf347012639. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️hybridcompute [View full logs]  [Preview Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from aba2fae66fa2df181d73f799b006dcf347012639. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.hybridcompute.DefaultTag [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 28, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/hybridcompute/armhybridcompute https://apiview.dev/Assemblies/Review/99110a169a02457e9fa28de03c61232e
    Java azure-resourcemanager-hybridcompute https://apiview.dev/Assemblies/Review/9b82418e8da64b65a629c899f4c93b04
    JavaScript @azure/arm-hybridcompute https://apiview.dev/Assemblies/Review/7fa1fa6d7dcc42ddb16ea596547951f7

    @ghost ghost added the ArcReview label Mar 28, 2023
    @openapi-workflow-bot
    Copy link

    Hi @assing and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at Consistency in ARM Modeling. To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to arcboard@microsoft.com.

    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure resource-manager labels Mar 28, 2023
    @openapi-workflow-bot
    Copy link

    Hi @assing, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi @assing, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @dorothyhu dorothyhu merged commit 400dec1 into dorothyhu-hybridcompute-Microsoft.HybridCompute-2022-12-27 Mar 30, 2023
    @dorothyhu dorothyhu deleted the assing-hcrp-umc-2 branch March 30, 2023 16:57
    weidongxu-microsoft pushed a commit that referenced this pull request Apr 25, 2023
    …sion stable/2022-12-27 (#23282)
    
    * Adds base for updating Microsoft.HybridCompute from version preview/2022-12-27-preview to version 2022-12-27
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Added UMC operations (#23320)
    
    * Added UMC operations
    
    Added UMC operations
    
    * Fixed CR comments
    
    * fixed model validation error
    
    ---------
    
    Co-authored-by: assing <43956166+assing@users.noreply.github.com>
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    …sion stable/2022-12-27 (Azure#23282)
    
    * Adds base for updating Microsoft.HybridCompute from version preview/2022-12-27-preview to version 2022-12-27
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Added UMC operations (Azure#23320)
    
    * Added UMC operations
    
    Added UMC operations
    
    * Fixed CR comments
    
    * fixed model validation error
    
    ---------
    
    Co-authored-by: assing <43956166+assing@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    ArcReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-JavaScript CI-FixRequiredOnFailure resource-manager

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants