Skip to content

Conversation

@jaredmoo
Copy link
Contributor

@jaredmoo jaredmoo commented Jan 25, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@jaredmoo
Copy link
Contributor Author

This is a refactoring of existing Microsoft.Sql swagger docs with no functional change. We will be introducing a new version of databases, elastic pools, and check name availability APIs in the near future, so I have extracted the current (soon to be old) versions of these APIs from sql.core.json so that they can be included in readme.md independently.

},
"allOf": [
{
"$ref": "#/definitions/TrackedResource"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ref does not resolve and is causing CI failures (same for elasticPools.json).

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@jhendrixMSFT
Copy link
Member

@jaredmoo I regenerated the Go SDK with these changes on top of the latest SDK for this swagger and there is some content missing, specifically the databaseAutomaticTuning.json and serverAutomaticTuning.json swaggers are no longer referenced in this readme, see the reference in head. Is this expected or is your branch a bit behind?

@jaredmoo
Copy link
Contributor Author

Autotuning was only just merged 1 hour ago so my branch was behind. Now up-to-date :)

Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the generated SDK with these changes is identical to what's already in master.

@AutorestCI
Copy link

Swagger to SDK encountered an error: (Azure/azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 28, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 182, in rest_handle_action
    return rest_pull_sync(body, github_con, restapi_repo, sdk_pr_target_repo, sdkbase)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 332, in rest_pull_sync
    sdk_default_base
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 310, in generate_sdk_from_commit
    sdk_repo, temp_dir, autorest_bin)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 170, in build_libraries
    autorest_bin
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 127, in build_project
    autorest_bin)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/autorest_tools.py", line 109, in generate_code
    execute_simple_command(cmd_line, cwd=str(input_path))
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/autorest_tools.py", line 130, in execute_simple_command
    cmd_line
subprocess.CalledProcessError: Command '['/usr/local/bin/autorest', '/tmp/tmpxeuz3jy1/rest/specification/cognitiveservices/data-plane/LUIS/Programmatic/readme.md', '--go', '--go-sdk-folder=/tmp/tmpxeuz3jy1/sdk', '--multiapi', '--package-version=v12.2.1-beta', '--use=@microsoft.azure/autorest.go@preview', "--user-agent='Azure-SDK-For-Go/v12.2.1-beta services'", '--verbose']' returned non-zero exit status 1.

@jhendrixMSFT jhendrixMSFT merged commit 16052a6 into Azure:master Jan 25, 2018
@AutorestCI
Copy link

Was unable to find SDK Azure/azure-sdk-for-go PR for this closed PR.

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-python

mccleanp pushed a commit that referenced this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants