-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Extract databases, elastic pools, and check name availability from sql.core.json #2328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is a refactoring of existing Microsoft.Sql swagger docs with no functional change. We will be introducing a new version of databases, elastic pools, and check name availability APIs in the near future, so I have extracted the current (soon to be old) versions of these APIs from sql.core.json so that they can be included in readme.md independently. |
| }, | ||
| "allOf": [ | ||
| { | ||
| "$ref": "#/definitions/TrackedResource" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ref does not resolve and is causing CI failures (same for elasticPools.json).
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
@jaredmoo I regenerated the Go SDK with these changes on top of the latest SDK for this swagger and there is some content missing, specifically the databaseAutomaticTuning.json and serverAutomaticTuning.json swaggers are no longer referenced in this readme, see the reference in head. Is this expected or is your branch a bit behind? |
|
Autotuning was only just merged 1 hour ago so my branch was behind. Now up-to-date :) |
jhendrixMSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that the generated SDK with these changes is identical to what's already in master.
Swagger to SDK encountered an error: (Azure/azure-sdk-for-go)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 28, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 182, in rest_handle_action
return rest_pull_sync(body, github_con, restapi_repo, sdk_pr_target_repo, sdkbase)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 332, in rest_pull_sync
sdk_default_base
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 310, in generate_sdk_from_commit
sdk_repo, temp_dir, autorest_bin)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 170, in build_libraries
autorest_bin
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 127, in build_project
autorest_bin)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/autorest_tools.py", line 109, in generate_code
execute_simple_command(cmd_line, cwd=str(input_path))
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/autorest_tools.py", line 130, in execute_simple_command
cmd_line
subprocess.CalledProcessError: Command '['/usr/local/bin/autorest', '/tmp/tmpxeuz3jy1/rest/specification/cognitiveservices/data-plane/LUIS/Programmatic/readme.md', '--go', '--go-sdk-folder=/tmp/tmpxeuz3jy1/sdk', '--multiapi', '--package-version=v12.2.1-beta', '--use=@microsoft.azure/autorest.go@preview', "--user-agent='Azure-SDK-For-Go/v12.2.1-beta services'", '--verbose']' returned non-zero exit status 1. |
|
Was unable to find SDK Azure/azure-sdk-for-go PR for this closed PR. |
|
No modification for AutorestCI/azure-sdk-for-python |
Making arczone as optional input...
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger