[Go] storagecache add directive by Alancere · Pull Request #23218 · Azure/azure-rest-api-specs

Alancere · 2023-03-22T09:47:32Z

No description provided.

openapi-workflow-bot · 2023-03-22T09:47:36Z

Hi, @Alancere Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-03-22T09:47:38Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

compared tags (via openapi-validator v2.0.0)	new version	base version
default	default(0287d2b)	default(main)

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-03-22T09:47:39Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 72e526d. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.2` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-storagecache [View full logs] [Release SDK Changes]
- azure-mgmt-storagecache-1.0.0b1.zip
- azure_mgmt_storagecache-1.0.0b1-py3-none-any.whl
```
info	[Changelog]
```

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 72e526d. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:671
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 671 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.StorageCache [View full logs] [Release SDK Changes] Breaking Change Detected

Azure.ResourceManager.StorageCache.1.1.0-alpha.20230323.1.nupkg

info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.StorageCache/Debug/netstandard2.0/Azure.ResourceManager.StorageCache.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/storagecache/Azure.ResourceManager.StorageCache/src/Azure.ResourceManager.StorageCache.csproj::TargetFramework=netstandard2.0]

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 72e526d. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-storagecache [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 72e526d. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/storagecache/armstoragecache [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `NewClientFactory(string, azcore.TokenCredential, *arm.ClientOptions) (*ClientFactory, error)`
info	[Changelog] - New function `*ClientFactory.NewAscOperationsClient() *AscOperationsClient`
info	[Changelog] - New function `*ClientFactory.NewAscUsagesClient() *AscUsagesClient`
info	[Changelog] - New function `*ClientFactory.NewCachesClient() *CachesClient`
info	[Changelog] - New function `*ClientFactory.NewOperationsClient() *OperationsClient`
info	[Changelog] - New function `*ClientFactory.NewSKUsClient() *SKUsClient`
info	[Changelog] - New function `*ClientFactory.NewStorageTargetClient() *StorageTargetClient`
info	[Changelog] - New function `*ClientFactory.NewStorageTargetsClient() *StorageTargetsClient`
info	[Changelog] - New function `*ClientFactory.NewUsageModelsClient() *UsageModelsClient`
info	[Changelog] - New struct `ClientFactory`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 11 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 72e526d. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.

️✔️@azure/arm-storagecache [View full logs] [Release SDK Changes]
- azure-arm-storagecache-7.0.0-beta.2.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 72e526d. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️storagecache [View full logs]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 72e526d. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.
HttpError: You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.
    at /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit+request@5.6.3_encoding@0.1.13/node_modules/@octokit/request/dist-node/index.js:86:21
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async workflowPkgUpdatePR (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:397:21)
    at async Object.exports.workflowPkgMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:63:5)
    at async workflowHandleReadmeMdOrCadlProject (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:216:9)
    at async Object.exports.workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:94:9)
    at async Object.exports.sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:191:13)
    at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18

❌Az.storagecache.DefaultTag [View full logs]

error	Fatal error: You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.
error	The following packages are still pending:
error		Az.storagecache.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-03-22T09:47:40Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/storagecache/armstoragecache	Create ApiView failed. Please ask PR assignee for help
.Net	Azure.ResourceManager.StorageCache	https://apiview.dev/Assemblies/Review/505c5313141e4253a33d54d3ce161c4e
Java	azure-resourcemanager-storagecache	https://apiview.dev/Assemblies/Review/5aef74abb420467bbe0d333b45071ab2
JavaScript	@azure/arm-storagecache	https://apiview.dev/Assemblies/Review/81758793dbc1451bbc8a937c7b1988d4

tadelesh · 2023-03-22T09:49:21Z

specification/storagecache/resource-manager/readme.go.md

+  - from: swagger-document
+    where: $.definitions.CacheIdentity.properties
+    transform: >
+      $['userAssignedIdentities']['$ref'] = "amlfilesystem.json#/definitions/UserAssignedIdentities";


What is this directive for?

tadelesh · 2023-03-22T10:05:16Z

specification/storagecache/resource-manager/readme.go.md

 output-folder: $(go-sdk-folder)/$(module-name)
 azure-arm: true
+directive:
+  - from: swagger-document


Suggested change

- from: swagger-document

- from: "amlfilesystem.json"

* [Go] storagecache add directive * fix

[Go] storagecache add directive

a463b5e

Alancere requested a review from ArcturusZhang as a code owner March 22, 2023 09:47

openapi-assignment-bot bot assigned weidongxu-microsoft Mar 22, 2023

Alancere requested a review from tadelesh March 22, 2023 09:48

tadelesh reviewed Mar 22, 2023

View reviewed changes

AzureRestAPISpecReview added the resource-manager label Mar 22, 2023

tadelesh reviewed Mar 22, 2023

View reviewed changes

fix

0287d2b

azure-sdk mentioned this pull request Mar 22, 2023

[AutoPR sdk/resourcemanager/storagecache/armstoragecache] [Go] storagecache add directive azure-sdk/azure-sdk-for-go#5020

Closed

tadelesh approved these changes Mar 23, 2023

View reviewed changes

tadelesh merged commit 72e526d into Azure:main Mar 23, 2023

JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023

[Go] storagecache add directive (Azure#23218)

fe7ac6d

* [Go] storagecache add directive * fix

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Go] storagecache add directive#23218

[Go] storagecache add directive#23218
tadelesh merged 2 commits intoAzure:mainfrom
Alancere:storagecache_directive_0322

Alancere commented Mar 22, 2023

Uh oh!

openapi-workflow-bot bot commented Mar 22, 2023

Uh oh!

openapi-pipeline-app bot commented Mar 22, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Mar 22, 2023 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Mar 22, 2023 •

edited

Loading

Uh oh!

tadelesh Mar 22, 2023

Uh oh!

tadelesh Mar 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

Alancere commented Mar 22, 2023

Uh oh!

openapi-workflow-bot bot commented Mar 22, 2023

Uh oh!

openapi-pipeline-app bot commented Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

tadelesh Mar 22, 2023

Choose a reason for hiding this comment

Uh oh!

tadelesh Mar 22, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

openapi-pipeline-app bot commented Mar 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Mar 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Mar 22, 2023 •

edited

Loading