Skip to content

Conversation

@hstellmach-msft
Copy link
Contributor

@hstellmach-msft hstellmach-msft commented Mar 15, 2023

Data Plane API - Pull Request

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your engagement record.

  • Link to engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.

  • Design Document:
  • Previous Open API Doc:
  • Updated paths:

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 15, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 4 Warnings warning [Detail]
compared tags (via openapi-validator v2.0.0) new version base version
release_2023_04_15_preview release_2023_04_15_preview(2fe4093) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: authoring/preview/2023-04-15-preview/images.json#L98
⚠️ ParameterNamesConvention Parameter name 'operation-id' should be camel case.
Location: authoring/preview/2023-04-15-preview/images.json#L100
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: authoring/preview/2023-04-15-preview/images.json#L157
⚠️ ParameterNamesConvention Parameter name 'operation-id' should be camel case.
Location: authoring/preview/2023-04-15-preview/images.json#L159
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Posted by Swagger Pipeline | How to fix these errors?

@ghost ghost added the Cognitive Services label Mar 15, 2023
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 15, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 15, 2023

Generated ApiView

Language Package Name ApiView Link
swagger cognitiveservices-data-plane-AzureOpenAI-authoring https://apiview.dev/Assemblies/Review/9a688094e70840fbacba260c3a7e3465

@openapi-workflow-bot
Copy link

Hi, @hstellmach-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @hstellmach-msft hstellmach-msft changed the title Adding images.json to 2023-04-01-preview [Azure OpenAI Service] Adding images.json to 2023-04-01-preview Mar 16, 2023
    @openapi-pipeline-app
    Copy link

    Swagger Generation Artifacts

    ️🔄ApiDocPreview inProgress [Detail]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    Posted by Swagger Pipeline | How to fix these errors?

    @hstellmach-msft
    Copy link
    Contributor Author

    The current release for the AzureOpenAI is release_2022_12_01.

    update to latest?

    Refers to: specification/cognitiveservices/data-plane/AzureOpenAI/authoring/readme.md:7 in 7dbed88. [](commit_id = 7dbed88, deletion_comment = False)

    Even though it is only a preview?

    @johanste
    Copy link
    Member

    Why is image generation under authoring?

    }
    }
    },
    "x-ms-long-running-operation": true,
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Are we deviating from the OAI API pattern by making these operation Azure LROs?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants