-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[Azure OpenAI Service] Adding images.json to 2023-04-15-preview #23104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Swagger Validation Report
|
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| release_2023_04_15_preview | release_2023_04_15_preview(2fe4093) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: authoring/preview/2023-04-15-preview/images.json#L98 |
||
| Parameter name 'operation-id' should be camel case. Location: authoring/preview/2023-04-15-preview/images.json#L100 |
||
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: authoring/preview/2023-04-15-preview/images.json#L157 |
||
| Parameter name 'operation-id' should be camel case. Location: authoring/preview/2023-04-15-preview/images.json#L159 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
|
Hi, @hstellmach-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-01-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-15-preview/images.json
Outdated
Show resolved
Hide resolved
Swagger Generation Artifacts
|
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-15-preview/images.json
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-15-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-15-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-15-preview/images.json
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-15-preview/images.json
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-15-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-15-preview/images.json
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-15-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-15-preview/images.json
Outdated
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-15-preview/images.json
Show resolved
Hide resolved
...on/cognitiveservices/data-plane/AzureOpenAI/authoring/preview/2023-04-15-preview/images.json
Show resolved
Hide resolved
|
Why is image generation under authoring? |
| } | ||
| } | ||
| }, | ||
| "x-ms-long-running-operation": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we deviating from the OAI API pattern by making these operation Azure LROs?
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links