Changing customConfig from optional to required#2304
Merged
fearthecowboy merged 1 commit intoAzure:masterfrom Jan 23, 2018
q3blend:bugfix/customconfig-1
Merged
Changing customConfig from optional to required#2304fearthecowboy merged 1 commit intoAzure:masterfrom q3blend:bugfix/customconfig-1
fearthecowboy merged 1 commit intoAzure:masterfrom
q3blend:bugfix/customconfig-1
Conversation
Contributor
fearthecowboy
left a comment
There was a problem hiding this comment.
FYI -this will cause a binary breaking change in the generated SDK (and perhaps a order change in the method parameters).
I'm assuming this is OK with you?
Contributor
Author
|
Yes, this is Ok with me. |
fearthecowboy
approved these changes
Jan 23, 2018
|
Was unable to find SDK Azure/azure-sdk-for-python PR for this closed PR. |
|
No modification for AutorestCI/azure-sdk-for-python |
|
No modification for AutorestCI/azure-sdk-for-ruby |
|
No modification for AutorestCI/azure-sdk-for-python |
|
No modification for AutorestCI/azure-sdk-for-ruby |
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger