Remove syntax from many descriptions in CRP swagger files #23019

Sandido · 2023-03-10T20:38:29Z

ARM API Information (Control Plane)

The syntax is translated fine in the Rest API docs, https://learn.microsoft.com/en-us/rest/api/compute/virtual-machine-scale-sets/create-or-update?tabs=HTTP#scaleinpolicy
However, in all of the SDK docs the raw html is translated to 
as seen in https://learn.microsoft.com/en-us/dotnet/api/microsoft.azure.management.compute.models.vaultcertificate?view=azure-dotnet#properties

After an extensive email discussion with the code generator teams and docs teams, they are leaning towards treating the swagger description as plain text going forward.
This PR removes the syntax from descriptions where the change in the Rest API docs would not make the docs meaningfully worse, but would improve the SDK docs.

Lots of break line formats remain as removing them would make the Rest API docs worse, https://msazure.visualstudio.com/One/_workitems/edit/17491396.
I need to spend more time determining how to rewrite these if necessary.

.Net SDK PR: Azure/azure-sdk-for-net#35016

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2023-03-10T20:38:34Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
availabilitySet.json	2023-03-01(2f6b797)	2022-11-01(main)
capacityReservation.json	2023-03-01(2f6b797)	2022-11-01(main)
computeRPCommon.json	2023-03-01(2f6b797)	2022-11-01(main)
dedicatedHost.json	2023-03-01(2f6b797)	2022-11-01(main)
image.json	2023-03-01(2f6b797)	2022-11-01(main)
proximityPlacementGroup.json	2023-03-01(2f6b797)	2022-11-01(main)
virtualMachine.json	2023-03-01(2f6b797)	2022-11-01(main)
virtualMachineScaleSet.json	2023-03-01(2f6b797)	2022-11-01(main)

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2023-03-01	package-2023-03-01(2f6b797)	package-2023-03-01(feature/cplat-2023-03-01)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'availabilitySetName' should be defined with a 'pattern' restriction. Location: ComputeRP/stable/2023-03-01/availabilitySet.json#L37
`❌` ResourceNameRestriction	The resource name parameter 'availabilitySetName' should be defined with a 'pattern' restriction. Location: ComputeRP/stable/2023-03-01/availabilitySet.json#L353
`❌` MissingTypeObject	The schema 'AvailabilitySetProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/availabilitySet.json#L411
`❌` MissingTypeObject	The schema 'AvailabilitySet' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/availabilitySet.json#L458
`❌` MissingTypeObject	The schema 'AvailabilitySetUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/availabilitySet.json#L476
`❌` MissingTypeObject	The schema 'AvailabilitySetListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/availabilitySet.json#L494
`❌` ResourceNameRestriction	The resource name parameter 'capacityReservationGroupName' should be defined with a 'pattern' restriction. Location: ComputeRP/stable/2023-03-01/capacityReservation.json#L37
`❌` ResourceNameRestriction	The resource name parameter 'capacityReservationGroupName' should be defined with a 'pattern' restriction. Location: ComputeRP/stable/2023-03-01/capacityReservation.json#L390
`❌` ResourceNameRestriction	The resource name parameter 'capacityReservationName' should be defined with a 'pattern' restriction. Location: ComputeRP/stable/2023-03-01/capacityReservation.json#L390
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: ComputeRP/stable/2023-03-01/capacityReservation.json#L391
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2023-03-01/capacityReservation.json#L513
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: ComputeRP/stable/2023-03-01/capacityReservation.json#L533
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2023-03-01/capacityReservation.json#L572
`❌` ResourceNameRestriction	The resource name parameter 'capacityReservationGroupName' should be defined with a 'pattern' restriction. Location: ComputeRP/stable/2023-03-01/capacityReservation.json#L665
`❌` OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'CapacityReservations' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: ComputeRP/stable/2023-03-01/capacityReservation.json#L670
`❌` OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Compute/operations' does not match the ARM specification. Please standardize the schema. Location: ComputeRP/stable/2023-03-01/computeRPCommon.json#L52
`❌` MissingTypeObject	The schema 'ComputeOperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/computeRPCommon.json#L178
`❌` MissingTypeObject	The schema 'ComputeOperationValue' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/computeRPCommon.json#L194
`❌` MissingTypeObject	The schema 'ComputeOperationValueDisplay' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/computeRPCommon.json#L213
`❌` MissingTypeObject	The schema 'UsageName' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/computeRPCommon.json#L238
`❌` MissingTypeObject	The schema 'Usage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/computeRPCommon.json#L251
`❌` MissingTypeObject	The schema 'ListUsagesResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/computeRPCommon.json#L287
`❌` MissingTypeObject	The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/computeRPCommon.json#L319
`❌` MissingTypeObject	The schema 'SubResourceWithColocationStatus' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/computeRPCommon.json#L354
`❌` MissingTypeObject	The schema 'VirtualMachineSize' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/computeRPCommon.json#L368
`❌` MissingTypeObject	The schema 'VirtualMachineSizeListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/computeRPCommon.json#L402
`❌` MissingTypeObject	The schema 'Plan' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/computeRPCommon.json#L417
`❌` MissingTypeObject	The schema 'HardwareProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/computeRPCommon.json#L438
`❌` MissingTypeObject	The schema 'ImageReference' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/computeRPCommon.json#L639
`❌` MissingTypeObject	The schema 'KeyVaultSecretReference' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2023-03-01/computeRPCommon.json#L690

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2023-03-01

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2023-03-10T20:38:34Z

Hi, @Sandido Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-03-10T20:38:38Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go - sdk/resourcemanager/compute/armcompute - 5.0.0

+	Field `ID` of struct `VirtualMachineScaleSetIPConfiguration` has been removed
+	Field `ID` of struct `VirtualMachineScaleSetNetworkConfiguration` has been removed

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 29.2.0b1

+	Model VirtualMachineScaleSetIPConfiguration no longer has parameter id
+	Model VirtualMachineScaleSetNetworkConfiguration no longer has parameter id

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from b67476441693d96826dc03acc1c39fcf0c6ca006. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Compute [View full logs] [Preview SDK Changes]
- Azure.ResourceManager.Compute.1.2.0-alpha.20230320.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from b67476441693d96826dc03acc1c39fcf0c6ca006. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.6.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-compute [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model VirtualMachineScaleSetVMInstanceView has a new parameter computer_name
info	[Changelog]   - Model VirtualMachineScaleSetVMInstanceView has a new parameter hyper_v_generation
info	[Changelog]   - Model VirtualMachineScaleSetVMInstanceView has a new parameter os_name
info	[Changelog]   - Model VirtualMachineScaleSetVMInstanceView has a new parameter os_version
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model VirtualMachineScaleSetIPConfiguration no longer has parameter id
info	[Changelog]   - Model VirtualMachineScaleSetNetworkConfiguration no longer has parameter id

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from b67476441693d96826dc03acc1c39fcf0c6ca006. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-compute-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from b67476441693d96826dc03acc1c39fcf0c6ca006. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-compute [View full logs] [Preview SDK Changes]

azure-arm-compute-20.1.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Interface VirtualMachineScaleSetVMInstanceView has a new optional parameter computerName
info	[Changelog]   - Interface VirtualMachineScaleSetVMInstanceView has a new optional parameter hyperVGeneration
info	[Changelog]   - Interface VirtualMachineScaleSetVMInstanceView has a new optional parameter osName
info	[Changelog]   - Interface VirtualMachineScaleSetVMInstanceView has a new optional parameter osVersion
info	[Changelog]   - Enum KnownStorageAccountType has a new value StandardSSDLRS

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from b67476441693d96826dc03acc1c39fcf0c6ca006. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/compute/armcompute [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Field `ID` of struct `VirtualMachineScaleSetIPConfiguration` has been removed
info	[Changelog] - Field `ID` of struct `VirtualMachineScaleSetNetworkConfiguration` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `StorageAccountTypeStandardSSDLRS` added to enum type `StorageAccountType`
info	[Changelog] - New field `ComputerName` in struct `VirtualMachineScaleSetVMInstanceView`
info	[Changelog] - New field `HyperVGeneration` in struct `VirtualMachineScaleSetVMInstanceView`
info	[Changelog] - New field `OSName` in struct `VirtualMachineScaleSetVMInstanceView`
info	[Changelog] - New field `OSVersion` in struct `VirtualMachineScaleSetVMInstanceView`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 2 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from b67476441693d96826dc03acc1c39fcf0c6ca006. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️compute [View full logs] [Preview Schema Changes]

️❌ azure-powershell failed [Detail]

❌Failed [Logs] Generate from b67476441693d96826dc03acc1c39fcf0c6ca006. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.compute [View full logs] [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-03-10T20:38:43Z

Generated ApiView

Language	Package Name	ApiView Link
swagger	Microsoft.Compute	https://apiview.dev/Assemblies/Review/ee34d7d6e15f4d75ba0aab64d2bab6ae
Go	sdk/resourcemanager/compute/armcompute	Create ApiView failed. Please ask PR assignee for help
Java	azure-resourcemanager-compute-generated	https://apiview.dev/Assemblies/Review/22caf03ead5548438a4fa498a93c8753
.Net	Azure.ResourceManager.Compute	There is no API change compared with the previous version
JavaScript	@azure/arm-compute	https://apiview.dev/Assemblies/Review/fc1daf9816f448ffb1262d453e5053b7

Sandido · 2023-03-10T21:16:59Z

Hold off on merging as there is still some discussion about this.

ghost · 2023-04-09T16:03:41Z

Hi, @Sandido. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

* copy last version to 2023-03-01 folder * update version reference in the new folder * update versions reference in the new folder * add new readme tag with new version * sync with updates made to 2022-11-01 version * fix generation error * fix duplicate enum name thru c# directive instead. * make all the changes to this version that was made to the last version (2022-11-01) to address modelvalidation errors * update * Revert "update" This reverts commit 08417d3. * Added $expand option in ListAllVMs and ListAllVMs in RG (#22800) * Added $expand option in ListAllVMs and ListAllVMs in RG * Update virtualMachine.json * dedicatedHost Resize feature (#23268) * dedicatedHost Resize feature * DedicatedHost Sku renamed to size and resolved lint errors. * reviewer comments * httpMethod fix * Add property for VM (#22882) (#23329) Co-authored-by: payalguptapg <[email protected]> * Add Reapply for VMSS (#22344) * Add Reapply for VMSS * Prettier fix * Update examples * Address review comments 01 * Use typical resourceGroupName parameter. * Address review comments - Rename examples * Remove syntax from many descriptions in CRP swagger files (#23019) * up to computeRPCommon * all but computeRPCommons * computerpcommon * vmss clean * common clean * vmss try n * trying only \n * remove \n as it messes with rest docs * cleanup 2022-11-01 accidents * cleanups 2023 * remove ID from Update objects that do not have ID (#23078) * update * add identifiers --------- Co-authored-by: Theodore Chang <[email protected]> * Origin/feature/cplat 2023 03 01 (#23203) * Update virtualMachine.json Added missing property for Additional properties not allowed: provisionAfterExtensions Json path: $.value[*].properties.provisionAfterExtensions * added missing property for provisionAfterExtensions * add locatoin in VirtualMachineScaleSetVMExtension * fixed issue of x-ms-mutability --------- Co-authored-by: Younghyun Kim <[email protected]> * Add securityPostureReference (#23106) * [RestorePoints] Adding Encryption, Source Details, HyperVGeneration and WriteAccelerated for Restore Point (#23303) * Restore Point Encryption Details * Modified descriptions and made DiskRestorePointProperties as input property * Renaming object and adding type * Renaming DiskRestorePointProperties * making DiskRestorePoint.id readOnly * Modifying reference * Running Prettier * Renaming EncryptionType * Adding HyperVGeneration and WriteAcceleratorEnabled (prchin) * Add optional parameter hibernate to vmss deallocate api (#23409) * Add optional parameter hibernate to vmss deallocate api * Fix with prettier * update example for vmss deallocate * Add Spot Related Properties to VMSS PATCH * prettier and lintDiff suppressions * retry lintDiff suppression * lint diff suppression retry * Add managed identities parameters for blobs, add treatFailureAsDeploymentFailure flag for Run Command (#23557) * Add managed identities inputs for script, errorBlob, outputBlob * Add treatFailureAsDeploymentFailure flag * Update proximityPlacementGroup.json (#23556) * Update proximityPlacementGroup.json * Update proximityPlacementGroup.json * Update proximityPlacementGroup.json --------- Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Kartik Gupta <[email protected]> Co-authored-by: cakarata <[email protected]> Co-authored-by: payalguptapg <[email protected]> Co-authored-by: Anshul Verma <[email protected]> Co-authored-by: Adam Sandor <[email protected]> Co-authored-by: younghyun5756 <[email protected]> Co-authored-by: Younghyun Kim <[email protected]> Co-authored-by: krishnak-msft <[email protected]> Co-authored-by: Linu George <[email protected]> Co-authored-by: vatsan28 <[email protected]> Co-authored-by: Viv Lingaiah <[email protected]> Co-authored-by: Micah McKittrick <[email protected]>

* copy last version to 2023-03-01 folder * update version reference in the new folder * update versions reference in the new folder * add new readme tag with new version * sync with updates made to 2022-11-01 version * fix generation error * fix duplicate enum name thru c# directive instead. * make all the changes to this version that was made to the last version (2022-11-01) to address modelvalidation errors * update * Revert "update" This reverts commit 08417d3. * Added $expand option in ListAllVMs and ListAllVMs in RG (Azure#22800) * Added $expand option in ListAllVMs and ListAllVMs in RG * Update virtualMachine.json * dedicatedHost Resize feature (Azure#23268) * dedicatedHost Resize feature * DedicatedHost Sku renamed to size and resolved lint errors. * reviewer comments * httpMethod fix * Add property for VM (Azure#22882) (Azure#23329) Co-authored-by: payalguptapg <[email protected]> * Add Reapply for VMSS (Azure#22344) * Add Reapply for VMSS * Prettier fix * Update examples * Address review comments 01 * Use typical resourceGroupName parameter. * Address review comments - Rename examples * Remove syntax from many descriptions in CRP swagger files (Azure#23019) * up to computeRPCommon * all but computeRPCommons * computerpcommon * vmss clean * common clean * vmss try n * trying only \n * remove \n as it messes with rest docs * cleanup 2022-11-01 accidents * cleanups 2023 * remove ID from Update objects that do not have ID (Azure#23078) * update * add identifiers --------- Co-authored-by: Theodore Chang <[email protected]> * Origin/feature/cplat 2023 03 01 (Azure#23203) * Update virtualMachine.json Added missing property for Additional properties not allowed: provisionAfterExtensions Json path: $.value[*].properties.provisionAfterExtensions * added missing property for provisionAfterExtensions * add locatoin in VirtualMachineScaleSetVMExtension * fixed issue of x-ms-mutability --------- Co-authored-by: Younghyun Kim <[email protected]> * Add securityPostureReference (Azure#23106) * [RestorePoints] Adding Encryption, Source Details, HyperVGeneration and WriteAccelerated for Restore Point (Azure#23303) * Restore Point Encryption Details * Modified descriptions and made DiskRestorePointProperties as input property * Renaming object and adding type * Renaming DiskRestorePointProperties * making DiskRestorePoint.id readOnly * Modifying reference * Running Prettier * Renaming EncryptionType * Adding HyperVGeneration and WriteAcceleratorEnabled (prchin) * Add optional parameter hibernate to vmss deallocate api (Azure#23409) * Add optional parameter hibernate to vmss deallocate api * Fix with prettier * update example for vmss deallocate * Add Spot Related Properties to VMSS PATCH * prettier and lintDiff suppressions * retry lintDiff suppression * lint diff suppression retry * Add managed identities parameters for blobs, add treatFailureAsDeploymentFailure flag for Run Command (Azure#23557) * Add managed identities inputs for script, errorBlob, outputBlob * Add treatFailureAsDeploymentFailure flag * Update proximityPlacementGroup.json (Azure#23556) * Update proximityPlacementGroup.json * Update proximityPlacementGroup.json * Update proximityPlacementGroup.json --------- Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Kartik Gupta <[email protected]> Co-authored-by: cakarata <[email protected]> Co-authored-by: payalguptapg <[email protected]> Co-authored-by: Anshul Verma <[email protected]> Co-authored-by: Adam Sandor <[email protected]> Co-authored-by: younghyun5756 <[email protected]> Co-authored-by: Younghyun Kim <[email protected]> Co-authored-by: krishnak-msft <[email protected]> Co-authored-by: Linu George <[email protected]> Co-authored-by: vatsan28 <[email protected]> Co-authored-by: Viv Lingaiah <[email protected]> Co-authored-by: Micah McKittrick <[email protected]>

Sandido added 3 commits March 9, 2023 17:25

up to computeRPCommon

8e7d23b

all but computeRPCommons

61064ff

computerpcommon

110e410

Sandido requested review from MS-syh2qs, dkulkarni-ms, grizzlytheodore, haagha, hyonholee and madewithsmiles as code owners March 10, 2023 20:38

ghost added the Compute label Mar 10, 2023

vmss clean

b909175

azure-sdk mentioned this pull request Mar 10, 2023

[AutoPR sdk/resourcemanager/compute/armcompute] Remove syntax from many descriptions in CRP swagger files azure-sdk/azure-sdk-for-go#4750

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Mar 10, 2023

AzureRestAPISpecReview added the resource-manager label Mar 10, 2023

common clean

6a4a29d

Sandido added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 10, 2023

vmss try n

5ad7e1f

azure-sdk mentioned this pull request Mar 10, 2023

[AutoPR track2_azure-mgmt-compute] Remove syntax from many descriptions in CRP swagger files azure-sdk/azure-sdk-for-python#2983

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Mar 10, 2023

trying only \n

508f6e7

Sandido marked this pull request as draft March 13, 2023 20:32

Sandido added 3 commits March 20, 2023 09:35

remove \n as it messes with rest docs

2aab400

cleanup 2022-11-01 accidents

d028572

cleanups 2023

2f6b797

openapi-workflow-bot bot added the FixS360 label Mar 21, 2023

Sandido marked this pull request as ready for review March 21, 2023 18:18

grizzlytheodore approved these changes Mar 22, 2023

View reviewed changes

ghost added no-recent-activity and removed no-recent-activity labels Apr 9, 2023

grizzlytheodore merged commit 043b1f5 into feature/cplat-2023-03-01 Apr 11, 2023

grizzlytheodore deleted the adsandor/2023crpBR branch April 11, 2023 13:53

grizzlytheodore mentioned this pull request Apr 11, 2023

Feature/cplat 2023 03 01 #22885

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove <br> syntax from many descriptions in CRP swagger files #23019

Remove <br> syntax from many descriptions in CRP swagger files #23019

Uh oh!

Sandido commented Mar 10, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Mar 10, 2023 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Mar 10, 2023

Uh oh!

openapi-pipeline-app bot commented Mar 10, 2023 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Mar 10, 2023 •

edited

Loading

Uh oh!

Sandido commented Mar 10, 2023

Uh oh!

ghost commented Apr 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Remove <br> syntax from many descriptions in CRP swagger files #23019

Remove <br> syntax from many descriptions in CRP swagger files #23019

Uh oh!

Conversation

Sandido commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-pipeline-app bot commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-workflow-bot bot commented Mar 10, 2023

Uh oh!

openapi-pipeline-app bot commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

Sandido commented Mar 10, 2023

Uh oh!

ghost commented Apr 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sandido commented Mar 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Mar 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Mar 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Mar 10, 2023 •

edited

Loading