Workspace manager Members by rheabansal · Pull Request #22974 · Azure/azure-rest-api-specs

rheabansal · 2023-03-08T19:20:30Z

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

* odata fixes * add skip query * apim doc for filter * documentation

…stable/2022-06-01 (Azure#22619) * Base from version 2021-09-01-preview * adding 2022-06-01 for DCR, DCRA, and DCE * readme MD changes * fix examples * fix provisioning value list * deduplication for csharp track2 * custom-words * dedupe * modelerfour * undo readme changes * add new package in readme.md * fix readme.md * revert readme.md * add new package

* Fix Swagger Linter - 1 * Fix Swagger Linter - 2 * Fix Swagger Linter - 3 * Fix Swagger Linter - 4 * Update Location Value - HDInsight * Add "resourceGroups/rg1/" to 17 Location value * Update Location value Not confirmed but upgraded * Update pathToOperationResult to operationid --------- Co-authored-by: v-yuchenli <v-yuchenli@microsoft.com>

openapi-workflow-bot · 2023-03-08T19:20:34Z

Hi, @rheabansal Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-03-08T19:20:36Z

Swagger Validation Report

️❌BreakingChange: 948 Errors, 0 Warnings failed [Detail]

Only 0 items are rendered, please refer to log for more details.

Only -1 items are listed, please refer to log for more details.

Rule	Message

️❌Breaking Change(Cross-Version): 10 Errors, 71 Warnings failed [Detail]

Only 0 items are rendered, please refer to log for more details.

The following breaking changes are detected by comparison with the latest stable version:

Only -1 items are listed, please refer to log for more details.

Rule	Message

The following breaking changes are detected by comparison with the latest preview version:

Only -1 items are listed, please refer to log for more details.

Rule	Message

️🔄LintDiff inProgress [Detail]

️❌Avocado: 1 Errors, 9 Warnings failed [Detail]

Only -1 items are listed, please refer to log for more details.

Rule	Message

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️❌CadlAPIView: 0 Errors, 1 Warnings failed [Detail]

Only -1 items are listed, please refer to log for more details.

Rule	Message

️❌ModelValidation: 317 Errors, 0 Warnings failed [Detail]

Only -1 items are listed, please refer to log for more details.

Rule	Message

️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]

Only -1 items are listed, please refer to log for more details.

Rule	Message

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-03-08T19:20:38Z

Swagger Generation Artifacts

️🔄ApiDocPreview inProgress [Detail]

️⚠️SDK Breaking Change Tracking warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-net-track2 failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-python failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️🔄 azure-sdk-for-python-track2 inProgress [Detail]

️❌ azure-sdk-for-go failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-resource-manager-schemas failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-powershell failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-js failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-java failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-net failed [Detail]

Only 0 items are rendered, please refer to log for more details.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-03-08T19:20:40Z

Generated ApiView

Language	Package Name	ApiView Link
Java	azure-resourcemanager-applicationinsights	https://apiview.dev/Assemblies/Review/93c0fc88eb7e4f008b18b5ba9260a21a
JavaScript	@azure/arm-apimanagement	https://apiview.dev/Assemblies/Review/fc84d2507e154464a8ddf5c376e158f9
Go	sdk/resourcemanager/alertsmanagement/armalertsmanagement	Create ApiView failed. Please ask PR assignee for help
.Net	Azure.ResourceManager.ApiManagement	https://apiview.dev/Assemblies/Review/aaee7f4c62e640ea8b1ddde6938fb47b
.Net	Azure.ResourceManager.ApplicationInsights	There is no API change compared with the previous version
.Net	Azure.ResourceManager.CosmosDB	There is no API change compared with the previous version
.Net	Azure.ResourceManager.HDInsight	There is no API change compared with the previous version
.Net	Azure.ResourceManager.IotHub	https://apiview.dev/Assemblies/Review/369cec0de549423a966ac3e197d4bb37
.Net	Azure.ResourceManager.KeyVault	There is no API change compared with the previous version
.Net	Azure.ResourceManager.MachineLearning	https://apiview.dev/Assemblies/Review/1dea9754771c46fc9c04dfb71dcd4303
.Net	Azure.ResourceManager.Marketplace	https://apiview.dev/Assemblies/Review/8f89ca2337fe4c35b1c8130b4650bf53
.Net	Azure.ResourceManager.Monitor	There is no API change compared with the previous version
.Net	Azure.ResourceManager.MySql	https://apiview.dev/Assemblies/Review/94224fcf585440fd8149fcbe17d53ad0
.Net	Azure.ResourceManager.Network	There is no API change compared with the previous version
.Net	Azure.ResourceManager.PostgreSql	https://apiview.dev/Assemblies/Review/0aa9128532d74b2987e6f39a3481acec
.Net	Azure.ResourceManager.RecoveryServices	https://apiview.dev/Assemblies/Review/4aaae1ce83ae41a09218e5225f765430
.Net	Azure.ResourceManager.RecoveryServicesBackup	https://apiview.dev/Assemblies/Review/a4162eb254ba4a9db11652e392e091ff
.Net	Azure.ResourceManager.RecoveryServicesSiteRecovery	There is no API change compared with the previous version
.Net	Azure.ResourceManager.SecurityInsights	There is no API change compared with the previous version
.Net	Azure.ResourceManager.ServiceFabric	There is no API change compared with the previous version
.Net	Azure.ResourceManager.ServiceFabricManagedClusters	There is no API change compared with the previous version

openapi-workflow-bot · 2023-03-08T19:30:21Z

Hi, @rheabansal your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

rheabansal · 2023-03-08T20:07:48Z

Hi we previously got sign off on the content in this PR targeting march instead of April for the version. Here is a link to the signed off PR: #21276

@Vibhuti-Sharma-Microsoft

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Discussed with @Vibhuti-Sharma-Microsoft The operation ID will be fixed in subsequent change, since this version of swagger has already been merged in `azure-rest-api-specs-pr`.

…be SystemManaged (Azure#22943) merged with breaking change approved.

…to add version preview/2023-02-01-preview (Azure#22436) * Adds base for updating Microsoft.MachineLearningServices from version preview/2022-12-01-preview to version 2023-02-01-preview * Updates readme * Updates API version in new specs and examples * Add managedResourceGroupTags to registries Feb 2023 Preview swagger (Azure#22617) * removed feb2023 registries.json * Revert "removed feb2023 registries.json" This reverts commit d2d1f70. * add managedResourceGroupTags property --------- Co-authored-by: Komal Yadav <komalyadav@microsoft.com> * updating to feb 2023 preview (Azure#22456) * updating to feb 2023 preview * adding example files * add to custom words, remove spelling errors * Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com> * Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com> * Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com> * resolving model validation errors * try resolving operation async response validation errors * merge data container/ver, queue settings * add datacontainer and version example files, add LRO uri * update example jobs files, update LRO and registry name pattern * last LRO fixes * test that batchdeploymentproperties is resolved * adding maulik's swagger generation PR changes * update swagger with new deduped batch names * adding updated computeresource name * add boolean featuredatatype --------- Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com> * ManagedNetwork Support and paramter parttern update for WorkspaceRP (Azure#22588) * add swagger support for managed network * update parameter pattern * Add rules * remove unused file * fix * fix format and add pattern * update format and example * revert manage network changes * small change * revert * Staging Branch Gate Fixes and Schema Bug Fix for ModelPackage (Azure#22784) * updating to feb 2023 preview * adding example files * add to custom words, remove spelling errors * Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com> * Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com> * Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com> * resolving model validation errors * try resolving operation async response validation errors * merge data container/ver, queue settings * add datacontainer and version example files, add LRO uri * update example jobs files, update LRO and registry name pattern * last LRO fixes * test that batchdeploymentproperties is resolved * adding maulik's swagger generation PR changes * update swagger with new deduped batch names * adding updated computeresource name * add boolean featuredatatype * fixing model validation pattern error * fix LRO gate * adding model package updates to swagger * un requiring property --------- Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com> --------- Co-authored-by: Komal Yadav <23komal.yadav23@gmail.com> Co-authored-by: Komal Yadav <komalyadav@microsoft.com> Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com>

merge with breaking change approved

ghost · 2023-04-02T16:02:59Z

Hi, @rheabansal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2023-04-17T05:02:42Z

Hi, @rheabansal. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

solankisamir and others added 7 commits March 8, 2023 09:40

odata fixes for ApiWikis and ProductWikis Api (Azure#22854)

d755857

* odata fixes * add skip query * apim doc for filter * documentation

update typescript.md for graphservices (Azure#22964)

120c291

update (Azure#22965)

7d313ec

Workspace Manager Members

d64132a

udpate pattern

6a5797a

AzureRestAPISpecReview added the resource-manager label Mar 8, 2023

openapi-workflow-bot Bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 8, 2023

openapi-pipeline-app Bot added the CI-BreakingChange-JavaScript label Mar 8, 2023

This was referenced Mar 8, 2023

[AutoPR Azure.ResourceManager.SecurityInsights] Workspace manager Members azure-sdk/azure-sdk-for-net#2925

Closed

[AutoPR Az.securityinsights] Workspace manager Members azure-sdk/azure-powershell#4687

Closed

rheabansal added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 8, 2023

mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 9, 2023

openapi-workflow-bot Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 9, 2023

Vibhuti-Sharma-Microsoft and others added 5 commits March 9, 2023 10:34

Added pan specifications (Azure#22878)

93fbd7d

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Discussed with @Vibhuti-Sharma-Microsoft The operation ID will be fixed in subsequent change, since this version of swagger has already been merged in `azure-rest-api-specs-pr`.

Fix linter error R4001 (Azure#22973)

2048c7d

{AzurePostgreSQL} fixes Azure#22851 Data encryption type enum should …

1745efa

…be SystemManaged (Azure#22943) merged with breaking change approved.

[S360 fix] Add details field to ErrorResponse (Azure#22910)

d82babc

merge with breaking change approved

ghost added the no-recent-activity label Apr 2, 2023

ghost closed this Apr 17, 2023

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Workspace manager Members#22974

Workspace manager Members#22974
rheabansal wants to merge 56 commits into
Azure:dev-securityinsights-Microsoft.SecurityInsights-2023-04-01-preview-WorkspaceManagerfrom
rheabansal:feature-Sentinel-2023-04-01-preview-WorkspaceManager-Members

rheabansal commented Mar 8, 2023 •

edited

Loading

Uh oh!

openapi-workflow-bot Bot commented Mar 8, 2023

Uh oh!

openapi-pipeline-app Bot commented Mar 8, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app Bot commented Mar 8, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app Bot commented Mar 8, 2023 •

edited

Loading

Uh oh!

openapi-workflow-bot Bot commented Mar 8, 2023

Uh oh!

rheabansal commented Mar 8, 2023

Uh oh!

ghost commented Apr 2, 2023

Uh oh!

ghost commented Apr 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

rheabansal commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot Bot commented Mar 8, 2023

Uh oh!

openapi-pipeline-app Bot commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app Bot commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

openapi-pipeline-app Bot commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

openapi-workflow-bot Bot commented Mar 8, 2023

Uh oh!

rheabansal commented Mar 8, 2023

Uh oh!

ghost commented Apr 2, 2023

Uh oh!

ghost commented Apr 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

rheabansal commented Mar 8, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Mar 8, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Mar 8, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Mar 8, 2023 •

edited

Loading