Skip to content

Add edition and customized scripts support for the SSIS IR #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsgouda merged 1 commit into from
Jan 17, 2018
Merged

Add edition and customized scripts support for the SSIS IR #2266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions ...ager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/IntegrationRuntime.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,22 @@
"name": "IntegrationRuntimeLicenseType",
"modelAsString": true
}
},
"customSetupScriptProperties": {
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Jan 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: For consistency, you can name the model with PascalCase and name the properties with camelCased letters.

Copy link
Copy Markdown
Contributor Author

@chinadragon0515 chinadragon0515 Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent, properties within definition are start with low case, so using low case here.
And definition are start with upper case, refer to link 208

"description": "Custom setup script properties for a managed dedicated integration runtime.",
"$ref": "#/definitions/IntegrationRuntimeCustomSetupScriptProperties"
},
"edition": {
"description": "The edition for the SSIS Integration Runtime",
"type": "string",
"enum": [
"Standard",
"Enterprise"
],
"x-ms-enum": {
"name": "IntegrationRuntimeEdition",
"modelAsString": true
}
}
},
"additionalProperties": {
Expand Down Expand Up @@ -189,6 +205,20 @@
"type": "object"
}
},
"IntegrationRuntimeCustomSetupScriptProperties": {
"description": "Custom setup script properties for a managed dedicated integration runtime.",
"type": "object",
"properties": {
"blobContainerUri": {
"description": "The URI of the Azure blob container that contains the custom setup script.",
"type": "string"
},
"sasToken": {
"description": "The SAS token of the Azure blob container.",
"$ref": "../datafactory.json#/definitions/SecureString"
}
}
},
"SelfHostedIntegrationRuntime": {
"x-ms-discriminator-value": "SelfHosted",
"description": "Self-hosted integration runtime.",
Expand Down