Skip to content

Clean up and fix communication error in spec #22621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minnieliu merged 2 commits into from
Feb 15, 2023
Merged

Clean up and fix communication error in spec #22621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a98da88
Clean up and fix communication error in spec
Feb 14, 2023
65b6ccf
Fix example version
Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...communication/data-plane/Rooms/preview/2023-03-31-preview/communicationservicesrooms.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,9 @@
"CommunicationErrorResponse": {
"$ref": "../../../Common/stable/2021-03-07/common.json#/definitions/CommunicationErrorResponse"
},
"CommunicationError": {
"$ref": "../../../Common/stable/2021-03-07/common.json#/definitions/CommunicationError"
},
"CreateRoomRequest": {
"description": "Request payload for creating new room.",
"type": "object",
Expand Down Expand Up @@ -520,7 +523,6 @@
"description": "The endpoint of the Azure Communication resource.",
"required": true,
"type": "string",
"format": "uri",
"x-ms-skip-url-encoding": true,
"x-ms-parameter-location": "client"
}
Expand All @@ -530,7 +532,7 @@
"type": "apiKey",
"name": "Authorization",
"in": "header",
"description": "An ACS (Azure Communication Services) user access token."
"description": "An authentication string containing a signature generated using HMAC-SHA256 scheme."
}
},
"security": [
Expand Down
2 changes: 1 addition & 1 deletion .../communication/data-plane/Rooms/preview/2023-03-31-preview/examples/Rooms_DeleteRoom.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"parameters": {
"endpoint": "https://contoso.communication.azure.com/",
"api-version": "2023-01-01",
"api-version": "2023-03-31-preview",
"roomId": "99199690362660524"
},
"responses": {
Expand Down