[Hub Generated] Publish private branch 'release-graphservicesprod-Microsoft.GraphServices-2022-09-22-preview' by romero-ms · Pull Request #22373 · Azure/azure-rest-api-specs

romero-ms · 2023-01-30T21:56:08Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

romero-ms · 2023-01-30T21:56:09Z

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/8908

openapi-pipeline-app · 2023-01-30T21:56:11Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 2 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2022-09-22-preview	package-2022-09-22-preview(b10bb74)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.GraphServices/preview/2022-09-22-preview/graphservicesprod.json#L377
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.GraphServices/preview/2022-09-22-preview/graphservicesprod.json#L383

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]

Tag package-2022-09-22-preview; Prod region: Not deployed; Canary region: Not deployed

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2023-01-30T21:56:11Z

Hi, @romero-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-01-30T21:56:12Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from bfdb4bf. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.3.1 -> 9.5.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.5.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.5.1` to update!
cmderr	[automation_generate.sh] npm notice
warn	No file changes detected after generation
warn	No package detected after generation

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from bfdb4bf. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-graphservicesprod [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from bfdb4bf. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-graphservicesprod [View full logs] [Release SDK Changes]
- azure-arm-graphservicesprod-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from bfdb4bf. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️graphservicesprod [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-01-30T21:56:13Z

Generated ApiView

Language	Package Name	ApiView Link
Java	azure-resourcemanager-graphservicesprod	https://apiview.dev/Assemblies/Review/db5f80872f1943daa239c17e18ba1f06
JavaScript	@azure/arm-graphservicesprod	Create ApiView failed. Please ask PR assignee for help

ruowan · 2023-01-31T02:22:48Z

/azp run

azure-pipelines · 2023-01-31T02:22:58Z

Azure Pipelines successfully started running 1 pipeline(s).

ruowan · 2023-01-31T02:44:58Z

/azp run

azure-pipelines · 2023-01-31T02:45:07Z

Azure Pipelines successfully started running 1 pipeline(s).

romero-ms · 2023-02-01T22:19:32Z

@jianyexi I see the error "API Readiness check failed. Please make sure your service is deployed. | InvalidResourceNamespace. The resource namespace 'Microsoft.GraphServices' is invalid."

The RP is under a feature flag at the moment until our final rollout finished to enter our public preview. Is this something we need to wait for to progress in here?

sjanamma · 2023-02-04T20:34:35Z

typo - plan?

Refers to: specification/graphservicesprod/resource-manager/Microsoft.GraphServices/preview/2022-09-22-preview/graphservicesprod.json:470 in e722196. [](commit_id = e722196, deletion_comment = False)

sjanamma · 2023-02-04T20:36:17Z

can v3 or later version of common type be used here?

Refers to: specification/graphservicesprod/resource-manager/Microsoft.GraphServices/preview/2022-09-22-preview/graphservicesprod.json:470 in e722196. [](commit_id = e722196, deletion_comment = False)

...d/resource-manager/Microsoft.GraphServices/preview/2022-09-22-preview/graphservicesprod.json

openapi-workflow-bot · 2023-02-04T20:39:30Z

Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

…elease-graphservicesprod-Microsoft.GraphServices-2022-09-22-preview

amatukmolina · 2023-02-23T00:10:23Z

Hi @jianyexi, we're getting 2 errors in the pipeline. One at the SDK azure-sdk-for-js step that fails with the message "Create APiView failed. Please ask PR assignee for help" and the othe error in the SwaggerAPIView step. For context in case it helps, our resource type "accounts" is public and we only have Canary behind a feature flag.

Could you help us with this?

carlosov-ms · 2023-02-28T15:51:33Z

@jianyexi can you provide any guidance on how to resolve the 2 issues that @amatukmolina shared above? We need to get this PR merged so that we can proceed with the SDK generation and testing.

Thank you

…rosoft.GraphServices-2022-09-22-preview' (Azure#22373) * add or modify files * Fix typo --------- Co-authored-by: amatukmolina <81262128+amatukmolina@users.noreply.github.com>

add or modify files

e722196

romero-ms requested review from Wzb123456789, jsntcy, msyyc and qiaozha as code owners January 30, 2023 21:56

openapi-assignment-bot bot assigned raych1 Jan 30, 2023

azure-sdk mentioned this pull request Jan 30, 2023

[AutoPR graphservicesprod] [Hub Generated] Publish private branch 'release-graphservicesprod-Microsoft.GraphServices-2022-09-22-preview' azure-sdk/azure-resource-manager-schemas#1902

Closed

raych1 assigned jianyexi and unassigned raych1 Jan 31, 2023

sjanamma reviewed Feb 4, 2023

View reviewed changes

...d/resource-manager/Microsoft.GraphServices/preview/2022-09-22-preview/graphservicesprod.json Show resolved Hide resolved

sjanamma added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review ARMChangesRequested labels Feb 4, 2023

openapi-workflow-bot bot removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMChangesRequested labels Feb 4, 2023

amatukmolina added 2 commits February 10, 2023 12:19

Merge branch 'main' into published/cleivabu/azure-rest-api-specs-pr/r…

31d6baa

…elease-graphservicesprod-Microsoft.GraphServices-2022-09-22-preview

Fix typo

b10bb74

jianyexi approved these changes Mar 2, 2023

View reviewed changes

jianyexi merged commit bfdb4bf into main Mar 2, 2023

jianyexi deleted the published/cleivabu/azure-rest-api-specs-pr/release-graphservicesprod-Microsoft.GraphServices-2022-09-22-preview branch March 2, 2023 08:18

Conversation

romero-ms commented Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

romero-ms commented Jan 30, 2023

Uh oh!

openapi-pipeline-app bot commented Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-workflow-bot bot commented Jan 30, 2023

Uh oh!

openapi-pipeline-app bot commented Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

ruowan commented Jan 31, 2023

Uh oh!

azure-pipelines bot commented Jan 31, 2023

Uh oh!

ruowan commented Jan 31, 2023

Uh oh!

azure-pipelines bot commented Jan 31, 2023

Uh oh!

romero-ms commented Feb 1, 2023

Uh oh!

sjanamma commented Feb 4, 2023

Uh oh!

sjanamma commented Feb 4, 2023

Uh oh!

Uh oh!

openapi-workflow-bot bot commented Feb 4, 2023

Uh oh!

amatukmolina commented Feb 23, 2023

Uh oh!

carlosov-ms commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

romero-ms commented Jan 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 30, 2023 •

edited

Loading

carlosov-ms commented Feb 28, 2023 •

edited

Loading