[Hub Generated] Review request for Microsoft.Network to add version stable/2022-04-01 by imsiddhartha · Pull Request #22357 · Azure/azure-rest-api-specs

imsiddhartha · 2023-01-30T11:36:47Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. Mar 2023
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. Feb
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  - To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…-01-preview to version 2022-04-01

openapi-workflow-bot · 2023-01-30T11:36:50Z

Hi, @imsiddhartha Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-01-30T11:36:51Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
trafficmanager.json	2022-04-01(530821c)	2018-08-01(main)
trafficmanager.json	2022-04-01(530821c)	2022-04-01-preview(main)

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 34 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.2)	new version	base version
package-2022-04	package-2022-04(530821c)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Only 30 items are listed, please refer to log for more details.

Rule	Message	Related RPC [For API reviewers]
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L25
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L25
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L101
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L101
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L174
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L174
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L268
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L268
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L340
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L340
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L385
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L385
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L436
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L436
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L478
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L478
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L514
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L514
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L564
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L564
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L638
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L638
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L685
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L685
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L740
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L740
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L773
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L773
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L869
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L869

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` OperationsAPIImplementation	Operations API must be implemented for 'Microsoft.Network'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L1
`❌` PathForNestedResource	The path for nested resource doest not meet the valid resource pattern. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L18
`❌` ResourceNameRestriction	The resource name parameter 'profileName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L18
`❌` ResourceNameRestriction	The resource name parameter 'endpointName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L18
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property name. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L59
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property type. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L59
`❌` DeleteResponseBodyEmpty	The delete response body must be empty. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L312
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L450
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L489
`❌` ResourceNameRestriction	The resource name parameter 'profileName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L507
`❌` DeleteResponseBodyEmpty	The delete response body must be empty. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L659
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property name. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L696
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property type. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L696
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property location. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L696
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L748
`❌` ResourceNameRestriction	The resource name parameter 'profileName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L766
`❌` ParametersInPointGet	Query parameter topLeft should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L773
`❌` ParametersInPointGet	Query parameter botRight should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L773
`❌` PathForPutOperation	The path for 'put' operation must be under a subscription and resource group. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L862
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L880
`❌` PutResponseSchemaDescription	Any Put MUST contain 200 and 201 return codes. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L911
`❌` DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L945
`❌` DeleteResponseBodyEmpty	The delete response body must be empty. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L948
`❌` MissingTypeObject	The schema 'DeleteOperationResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L968
`❌` MissingTypeObject	The schema 'EndpointProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L979
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L1054
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L1067
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L1076
`❌` MissingTypeObject	The schema 'HeatMapModel' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L1109
`❌` NestedResourcesMustHaveListOperation	The nested resource 'HeatMapModel' does not have list operation, please add it. Location: Microsoft.Network/stable/2022-04-01/trafficmanager.json#L1109

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]

Tag package-2022-04; Prod region: Not deployed; Canary region: Not deployed

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-01-30T11:36:51Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 4f4073b. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.TrafficManager [View full logs] [Release SDK Changes] Breaking Change Detected

Azure.ResourceManager.TrafficManager.1.1.0-alpha.20230525.1.nupkg

info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.TrafficManager.Models.TrafficManagerRelativeDnsNameAvailabilityContent' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/trafficmanager/Azure.ResourceManager.TrafficManager/src/Azure.ResourceManager.TrafficManager.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.TrafficManager/Debug/netstandard2.0/Azure.ResourceManager.TrafficManager.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/trafficmanager/Azure.ResourceManager.TrafficManager/src/Azure.ResourceManager.TrafficManager.csproj::TargetFramework=netstandard2.0]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 4f4073b. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.7` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-trafficmanager [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ProfilesOperations.check_traffic_manager_name_availability_v2
info	[Changelog]   - Model Endpoint has a new parameter always_serve

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 4f4073b. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-trafficmanager [View full logs] [Release SDK Changes]

azure-arm-trafficmanager-6.1.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation Profiles.checkTrafficManagerNameAvailabilityV2
info	[Changelog]   - Added Interface Endpoint
info	[Changelog]   - Added Interface HeatMapModel
info	[Changelog]   - Added Interface Profile
info	[Changelog]   - Added Interface ProfilesCheckTrafficManagerNameAvailabilityV2OptionalParams
info	[Changelog]   - Added Interface ProxyResource
info	[Changelog]   - Added Interface TrackedResource
info	[Changelog]   - Added Interface TrafficManagerGeographicHierarchy
info	[Changelog]   - Added Interface UserMetricsModel
info	[Changelog]   - Added Type Alias AlwaysServe
info	[Changelog]   - Added Type Alias ProfilesCheckTrafficManagerNameAvailabilityV2Response
info	[Changelog]   - Added Enum KnownAlwaysServe
info	[Changelog]   - Enum KnownEndpointMonitorStatus has a new value Unmonitored
info	[Changelog]   - Added function getContinuationToken

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 4f4073b. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️trafficmanager [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 4f4073b. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

❌Az.trafficmanager.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.trafficmanager.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-01-30T11:36:52Z

Generated ApiView

Language	Package Name	ApiView Link
.Net	Azure.ResourceManager.TrafficManager	https://apiview.dev/Assemblies/Review/75984f826f944d83b434b95f32bd22b2
JavaScript	@azure/arm-trafficmanager	https://apiview.dev/Assemblies/Review/3f6898db79864e4e81e5079c94660f3b

jblinkedin

LGTM

openapi-workflow-bot · 2023-01-31T06:34:57Z

Hi, @imsiddhartha your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

openapi-workflow-bot · 2023-01-31T18:11:47Z

Hi @imsiddhartha, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

sjanamma · 2023-02-01T21:49:31Z

@imsiddhartha - Please fix the two linter errors introduced as part of this api-version change. https://github.com/Azure/azure-rest-api-specs/pull/22357/checks?check_run_id=11012171989

imsiddhartha · 2023-02-14T15:10:34Z

@akning-ms Fixed prettier checks

fengzhou-msft · 2023-02-15T05:45:53Z

The azure-sdk-for-net-track2 failure is caused by a breaking change where the conditon for auto-renaming from TrafficManagerRelativeDnsNameAvailabilityParameters to TrafficManagerRelativeDnsNameAvailabilityContent is no longer established . We will use config to name it back. The failure should not block this PR.

akning-ms · 2023-02-15T05:52:13Z

Hi @imsiddhartha, ping me for merge when your service is almost ready in production (like before about 1 weeks). according to API readiness check. Looks the new version is not deployed in production yet.

ghost · 2023-03-19T16:03:31Z

Hi, @imsiddhartha. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2023-04-03T05:02:55Z

Hi, @imsiddhartha. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

jblinkedin · 2023-04-18T17:05:46Z

Reopening as we are ready to GET this released.

ghost · 2023-05-07T16:03:16Z

Hi, @imsiddhartha. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

akning-ms · 2023-05-22T00:42:33Z

re-assign to Ray as seems I don't have merge permission anymore

lirenhe · 2023-05-25T04:39:47Z

/azp run

imsiddhartha · 2023-05-25T04:39:51Z

/azp run unifiedPipeline

azure-pipelines · 2023-05-25T04:39:57Z

No pipelines are associated with this pull request.

azure-pipelines · 2023-05-25T04:39:57Z

Azure Pipelines successfully started running 1 pipeline(s).

imsiddhartha added 3 commits January 30, 2023 16:33

Adds base for updating Microsoft.Network from version preview/2022-04…

996ec67

…-01-preview to version 2022-04-01

Updates readme

64bb4e6

Updates API version in new specs and examples

76209f4

ghost added the Network - Traffic Manager label Jan 30, 2023

AzureRestAPISpecReview added new-api-version resource-manager labels Jan 30, 2023

jblinkedin approved these changes Jan 30, 2023

View reviewed changes

imsiddhartha marked this pull request as ready for review January 31, 2023 06:29

imsiddhartha requested a review from allencal as a code owner January 31, 2023 06:29

openapi-assignment-bot bot assigned akning-ms Jan 31, 2023

openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 31, 2023

Add new endpoint monitoring status Unmonitored for always serve.

25d3a21

azure-sdk mentioned this pull request Jan 31, 2023

[AutoPR trafficmanager] [Hub Generated] Review request for Microsoft.Network to add version stable/2022-04-01 azure-sdk/azure-resource-manager-schemas#1906

Closed

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Jan 31, 2023

imsiddhartha added 2 commits January 31, 2023 23:32

Add new API checkNameV2

f70e878

Fix error, Add subscriptionId in parameter

7172a37

AzureRestAPISpecReview added the CI-FixRequiredOnFailure label Jan 31, 2023

AzureRestAPISpecReview removed the CI-FixRequiredOnFailure label Jan 31, 2023

akning-ms added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Mar 3, 2023

ghost added the no-recent-activity label Mar 19, 2023

ghost closed this Apr 3, 2023

jblinkedin reopened this Apr 18, 2023

ghost removed the no-recent-activity label Apr 18, 2023

azure-sdk mentioned this pull request Apr 18, 2023

[AutoPR Az.trafficmanager.DefaultTag] [Hub Generated] Review request for Microsoft.Network to add version stable/2022-04-01 azure-sdk/azure-powershell#5212

Closed

ghost added the no-recent-activity label May 7, 2023

akning-ms assigned raych1 and unassigned akning-ms May 22, 2023

ghost removed the no-recent-activity label May 22, 2023

lirenhe approved these changes May 25, 2023

View reviewed changes

lirenhe merged commit 4f4073b into main May 25, 2023

lirenhe deleted the imsiddhartha-trafficmanager-Microsoft.Network-2022-04-01 branch May 25, 2023 07:16

imsiddhartha mentioned this pull request May 25, 2023

Release for trafficmanager 2022-04-01 Azure/azure-cli#26532

Closed

Comments

Conversation

imsiddhartha commented Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Jan 30, 2023

Uh oh!

openapi-pipeline-app bot commented Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

jblinkedin left a comment

Choose a reason for hiding this comment

Uh oh!

openapi-workflow-bot bot commented Jan 31, 2023

Uh oh!

openapi-workflow-bot bot commented Jan 31, 2023

Uh oh!

sjanamma commented Feb 1, 2023

Uh oh!

imsiddhartha commented Feb 14, 2023

Uh oh!

fengzhou-msft commented Feb 15, 2023

Uh oh!

akning-ms commented Feb 15, 2023

Uh oh!

ghost commented Mar 19, 2023

Uh oh!

ghost commented Apr 3, 2023

Uh oh!

jblinkedin commented Apr 18, 2023

Uh oh!

ghost commented May 7, 2023

Uh oh!

akning-ms commented May 22, 2023

Uh oh!

lirenhe commented May 25, 2023

Uh oh!

imsiddhartha commented May 25, 2023

Uh oh!

azure-pipelines bot commented May 25, 2023

Uh oh!

azure-pipelines bot commented May 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

imsiddhartha commented Jan 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 30, 2023 •

edited

Loading