Update service map swagger spec to latest and fix validation errors by JinFengMS · Pull Request #2231 · Azure/azure-rest-api-specs

JinFengMS · 2018-01-09T18:42:01Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

msftclas · 2018-01-09T18:42:12Z

All CLA requirements met.

…istMachineGroupMembershipGet.json

lmazuel · 2018-01-09T20:00:11Z

            "$ref": "#/parameters/MachineNameParameter"
+          },
+          {
+            "name": "startTime",


This does not correspond to the title of the PR, since this is not just fixing issues, but pushing new stuff. Could you rephrase your PR title if the scope change and this one is finally pushing new features?
Thanks,

fixed the PR title...

Thanks! It's just that sometimes people push stuff they don't want to push ;)

…datePut.json

lmazuel · 2018-01-09T21:13:47Z

@JinFengMS Some of your new samples are not considered valid by the CI, could you take a look? Thanks!

JinFengMS · 2018-01-09T21:53:06Z

@lmazuel I've fixed critical error reported by the CI which may block the build, for those jobs that "allowed failure" can I address them later?

lmazuel · 2018-01-09T22:30:31Z

@JinFengMS Job marked as "PR_ONLY=true" implies this is issue introduced by the PR itself. Example:

{ code: 'REQUEST_VALIDATION_ERROR',
  id: 'OAV109',
  message: 'Found errors in validating the request for x-ms-example "SMMachinesListByWorkspaceGet" in operation "Machines_ListByWorkspace".',

This is an example added by this exact PR, so every example you introduce should at least be valid in the PR you introduce it.
So, you can forget PR-ONLY=false, but please take a look at the two failed PR-ONLY=true

azuresdkciprbot · 2018-01-10T22:58:21Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/service-map/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 4
After the PR: Warning(s): 0 Error(s): 1

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-02-14T19:20:41Z

Automation for azure-sdk-for-go

Was unable to create SDK azure-sdk-for-go PR for this closed PR.

AutorestCI · 2018-02-14T19:20:55Z

Automation for azure-sdk-for-python

Was unable to create SDK azure-sdk-for-python PR for this closed PR.

azuresdkciprbot · 2018-02-14T19:32:29Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/service-map/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 4
After the PR: Warning(s): 0 Error(s): 1

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

JinFengMS · 2018-02-14T20:01:31Z

All the errors in examples are fixed. Now I we only have below errors with PR-ONLY=true from the build:
#7564.10 failed '/providers/Microsoft.OperationalInsights/operations' - as we discussed before service map is sharing RP with other services and this operation will never routed to us even we implemented it.
#7564.12 failed BreakingChange - These changes have been made and online now, I assume we don't have to deal with these "BreakingChanges"
#7564.14 failed liveValidation - Unsure how to fix this, is this a "MUST"? If so, please suggest how to specify an live endpoint.

lmazuel · 2018-02-14T20:18:46Z

          }
        },
-        "Ports": {
+        "ports": {


Could you confirm this is expected and the exact case used in the JSON? C# is not case-sensitive, but Python, Node, etc. are case-sensitive. I'm nervous when I see a case change :)

yes, it is expected change.

lmazuel · 2018-02-14T20:18:59Z

          }
        },
-        "ClientGroups": {
+        "clientGroups": {


Could you confirm this is expected and the exact case used in the JSON?

yes, they are.

lmazuel · 2018-02-14T20:21:32Z

All what you describe (10/12/14) are not required since you put your Swagger in a "preview" folder. Just look at the two comments I wrote and should be good :)

JinFengMS · 2018-02-14T21:05:53Z

Confirmed the two comments, we are good to go:)

fix service map swagger validation errors

4489a8f

azuresdkci assigned lmazuel Jan 9, 2018

JinFengMS added 2 commits January 9, 2018 11:06

remove the extra comma in examples/Machines/MachineGroups/SMMachinesL…

dfdb297

…istMachineGroupMembershipGet.json

remove extra comma for client groups operation examples

4fd7226

lmazuel reviewed Jan 9, 2018

View reviewed changes

ARM operation examples: replace parameter workspaceId with workspaceName

eb68722

JinFengMS changed the title ~~fix service map swagger validation errors~~ Update service map swagger spec to latest and fix validation errors Jan 9, 2018

add required parameter machineGroupName for example SMMachineGroupsUp…

21c11b8

…datePut.json

JinFengMS added 2 commits January 9, 2018 16:56

fix resource id and types

a6f2adf

fix more example validation errors

7026209

fix validation errors

ea5f27b

lmazuel reviewed Feb 14, 2018

View reviewed changes

lmazuel approved these changes Feb 14, 2018

View reviewed changes

lmazuel merged commit d8866e7 into Azure:master Feb 14, 2018

Conversation

JinFengMS commented Jan 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

msftclas commented Jan 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lmazuel Jan 9, 2018

Choose a reason for hiding this comment

Uh oh!

JinFengMS Jan 9, 2018

Choose a reason for hiding this comment

Uh oh!

lmazuel Jan 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lmazuel commented Jan 9, 2018

Uh oh!

JinFengMS commented Jan 9, 2018

Uh oh!

lmazuel commented Jan 9, 2018

Uh oh!

azuresdkciprbot commented Jan 10, 2018

Uh oh!

AutorestCI commented Feb 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Feb 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkciprbot commented Feb 14, 2018

Uh oh!

JinFengMS commented Feb 14, 2018

Uh oh!

lmazuel Feb 14, 2018

Choose a reason for hiding this comment

Uh oh!

JinFengMS Feb 14, 2018

Choose a reason for hiding this comment

Uh oh!

lmazuel Feb 14, 2018

Choose a reason for hiding this comment

Uh oh!

JinFengMS Feb 14, 2018

Choose a reason for hiding this comment

Uh oh!

lmazuel commented Feb 14, 2018

Uh oh!

JinFengMS commented Feb 14, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JinFengMS commented Jan 9, 2018 •

edited

Loading

msftclas commented Jan 9, 2018 •

edited

Loading

lmazuel Jan 9, 2018 •

edited

Loading

AutorestCI commented Feb 14, 2018 •

edited

Loading

AutorestCI commented Feb 14, 2018 •

edited

Loading