Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,8 @@
"prettier": "prettier",
"tsc": "tsc",
"multiapi": "ts-node ./scripts/multiapi.ts"
},
"dependencies": {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be changed.

"autorest": "^3.6.3"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,30 @@
"modelAsString": true
}
},
"CallingCommunicationIdentifierModel": {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the Model suffix?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll note this does seem to match the existing convention used in CommunicationIdentifierModel, CommunicationUserIdentifierModel, etc.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the "type" property.

"description": "Calling communication identifier model",
"allOf": [
{
"$ref": "#/definitions/CommunicationIdentifierModel"
}
],
"properties": {
"unknownIdentifiers": {
"$ref": "#/definitions/UnknownIdentifierModel",
"description": "The unknown identifier."
}
}
},
"UnknownIdentifierModel": {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question about whether we need Model suffix

"description": "Unknown identifier identifier model",
"type": "object",
"properties": {
"id": {
"type": "string",
"description": "The unknown id."
}
}
},
"CommunicationIdentifierModel": {
"description": "Identifies a participant in Azure Communication services. A participant is, for example, a phone number or an Azure communication user. This model is polymorphic: Apart from kind and rawId, at most one further property may be set which must match the kind enum value.",
"type": "object",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,32 @@
},
"paths": {},
"definitions": {
"AcsIncomingCallEventData": {
"description": "Schema of the Data property of an EventGridEvent for an Microsoft.Communication.IncomingCall event",
"type": "object",
"properties": {
"to": {
"description": "The communication identifier of the target user.",
"$ref": "../../../../../communication/data-plane/Common/stable/2022-07-13/common.json#/definitions/CallingCommunicationIdentifierModel"
},
"from": {
"description": "The communication identifier of the user who initiated the call.",
"$ref": "../../../../../communication/data-plane/Common/stable/2022-07-13/common.json#/definitions/CallingCommunicationIdentifierModel"
},
"callerDisplayName": {
"description": "Display name of caller.",
"type": "string"
},
"incomingCallContext": {
"description": "Incoming call context & compact payload.",
"type": "string"
},
"correlationId": {
"description": "CorrelationId (CallId).",
"type": "string"
}
}
},
"AcsUserDisconnectedEventData": {
"description": "Schema of the Data property of an EventGridEvent for an Microsoft.Communication.UserDisconnected event.",
"properties": {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"id": "81fa5460-7d8c-4fb7-bbb7-2d56154e78d9",
"topic": "/subscriptions/{subscription-id}/resourceGroups/{group-name}/providers/Microsoft.Communication/communicationServices/{communication-services-resource-name}",
"subject": "/call/{call-id}",
"data": {
"to": {
"rawId": "8:acs:5354158b-17b7-489c-9380-95d8821ff76b_0000000c-6c47-7dfd-6d70-224822000cfb",
"communicationUser": {
"id": "8:acs:5354158b-17b7-489c-9380-95d8821ff76b_0000000c-6c47-7dfd-6d70-224822000cfb"
}
},
"from": {
"rawId": "8:acs:0a420b29-555c-4f6b-841e-de8059893bb9_0000000c-6c47-7dfd-6d70-224822000cfb",
"communicationUser": {
"id": "8:acs:0a420b29-555c-4f6b-841e-de8059893bb9_0000000c-6c47-7dfd-6d70-224822000cfb"
}
},
"callerDisplayName": "VOIP Caller",
"incomingCallContext": "H4sIAAAAAAAEAMVX+2/bOBL+VwQfcD9cS4sUJUrkwjg4jn3NNa/m0WuL4AKKomw2sqSV6Ee62//9hpbzsnOH4naBKrAicjjffD0iODO/9ZQsitPKmtwoaU1V9sRvvbyp5u6/yXqilwipWiElylgapk",
"correlationId": "correlationId"
},
"eventType": "Microsoft.Communication.IncomingCall",
"dataVersion": "1.0",
"metadataVersion": "1",
"eventTime": "2022-12-30T21:13:45Z"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"id": "81fa5460-7d8c-4fb7-bbb7-2d56154e78d9",
"topic": "/subscriptions/{subscription-id}/resourceGroups/{group-name}/providers/Microsoft.Communication/communicationServices/{communication-services-resource-name}",
"subject": "/call/{call-id}",
"data": {
"to": {
"rawId": "8:acs:5354158b-17b7-489c-9380-95d8821ff76b_0000000c-6c47-7dfd-6d70-224822000cfb",
"communicationUser": {
"id": "8:acs:5354158b-17b7-489c-9380-95d8821ff76b_0000000c-6c47-7dfd-6d70-224822000cfb"
}
},
"from": {
"rawId": "8:acs:0a420b29-555c-4f6b-841e-de8059893bb9_0000000c-6c47-7dfd-6d70-224822000cfb",
"communicationUser": {
"id": "8:acs:0a420b29-555c-4f6b-841e-de8059893bb9_0000000c-6c47-7dfd-6d70-224822000cfb"
}
},
"callerDisplayName": "VOIP Caller",
"incomingCallContext": "H4sIAAAAAAAEAMVX+2/bOBL+VwQfcD9cS4sUJUrkwjg4jn3NNa/m0WuL4AKKomw2sqSV6Ee62//9hpbzsnOH4naBKrAicjjffD0iODO/9ZQsitPKmtwoaU1V9sRvvbyp5u6/yXqilwipWiElylgapk",
"correlationId": "correlationId"
},
"eventType": "Microsoft.Communication.IncomingCall",
"dataVersion": "1.0",
"metadataVersion": "1",
"eventTime": "2022-12-30T21:13:45Z"
}