Conversation
…/2021-08-08 to version 2023-01-01-preview
|
Hi, @meydand Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-2021-08 | package-2021-08(9a28187) | package-2021-08(main) |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/alertsmanagement/resource-manager/readme.md tag: specification/alertsmanagement/resource-manager/readme.md#tag-package-2021-08 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 15 Errors, 0 Warnings failed [Detail]
Tag package-2021-08; Prod region: Deployed
Test run on region: westcentralus; Operation coverage: total: 25, untested: 0, failed: 15, passed: 10
Service API Readiness Test failed. Check pipeline artifact for detail report.
| Rule | Message |
|---|---|
CLIENT_ERROR |
statusCode: 400, errorCode: LocationNotAvailableForResourceType, errorMessage: The provided location 'westcentralus' is not available for resource type 'Microsoft.AlertsManagement/actionRules'. List of available regions for the resource type is 'global'. Source: runtime OperationId: AlertProcessingRules_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.AlertsManagement/actionRules/alertpromp6pek' under resource group 'apiTest-aPaROm-22248' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: AlertProcessingRules_GetByName |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.AlertsManagement/actionRules/alertpromp6pek' under resource group 'apiTest-aPaROm-22248' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: AlertProcessingRules_Update |
CLIENT_ERROR |
statusCode: 400, errorCode: LocationNotAvailableForResourceType, errorMessage: The provided location 'westcentralus' is not available for resource type 'Microsoft.AlertsManagement/prometheusRuleGroups'. List of available regions for the resource type is 'northcentralus,eastus,eastus2,westeurope,westus,westus2,centralus,southcentralus,brazilsouth,southeastasia,centralindia,northeurope,uksouth,eastus2euap'. Source: runtime OperationId: PrometheusRuleGroups_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.AlertsManagement/prometheusRuleGroups/rulegrouxkgdms' under resource group 'apiTest-aPaROm-22248' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: PrometheusRuleGroups_Get |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.AlertsManagement/prometheusRuleGroups/rulegrouxkgdms' under resource group 'apiTest-aPaROm-22248' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: PrometheusRuleGroups_Update |
CLIENT_ERROR |
statusCode: 400, errorCode: ApiVersionNotRegistered, errorMessage: The ApiVersion '2019-05-05-preview' is not registered for ResourceType 'Microsoft.AlertsManagement/alertsMetaData'. Valid Api Versions are: '2019-03-01-preview'. Source: runtime OperationId: Alerts_MetaData |
CLIENT_ERROR |
statusCode: 404, errorCode: InvalidResourceType, errorMessage: The resource type could not be found in the namespace 'Microsoft.AlertsManagement' for api version '2023-01-01-preview'. Source: runtime OperationId: AlertRuleRecommendations_ListByTargetType |
CLIENT_ERROR |
statusCode: 404, errorCode: NotFound, errorMessage: Unable to find the input alert Source: runtime OperationId: Alerts_GetById |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.AlertsManagement/alerts/changestate/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: Alerts_ChangeState |
CLIENT_ERROR |
statusCode: 404, errorCode: NotFound, errorMessage: Unable to find the input alert Source: runtime OperationId: Alerts_GetHistory |
CLIENT_ERROR |
statusCode: 404, errorCode: NotFound, errorMessage: Unable to find the input smart group Source: runtime OperationId: SmartGroups_GetById |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.AlertsManagement/smartGroups/changeState/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: SmartGroups_ChangeState |
CLIENT_ERROR |
statusCode: 404, errorCode: NotFound, errorMessage: Unable to find the input smart group Source: runtime OperationId: SmartGroups_GetHistory |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.AlertsManagement/alertRuleRecommendations/read' over scope '/subscriptions/2f00cc51-6809-498f-9ffc-48c42aff570d/resourcegroups/test/providers/Microsoft.Compute/virtualMachines/testMachineCanBeSafelyDeleted/providers/Microsoft.AlertsManagement' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: AlertRuleRecommendations_ListByResource |
️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
/azp run unifiedPipeline |
|
Hi, @meydand your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
...-manager/Microsoft.AlertsManagement/preview/2023-01-01-preview/AlertRuleRecommendations.json
Show resolved
Hide resolved
...-manager/Microsoft.AlertsManagement/preview/2023-01-01-preview/AlertRuleRecommendations.json
Outdated
Show resolved
Hide resolved
...-manager/Microsoft.AlertsManagement/preview/2023-01-01-preview/AlertRuleRecommendations.json
Show resolved
Hide resolved
...-manager/Microsoft.AlertsManagement/preview/2023-01-01-preview/AlertRuleRecommendations.json
Show resolved
Hide resolved
|
@tadelesh to help confirm GO SDK breaking change.. @fengzhou-msft to help confirm .Net SdK generation failure |
|
The error message: Since it's not introduced by this PR and we can fix it by deduplication, the error can be ignored. |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.