Skip to content

Comments

[Hub Generated] Review request for Microsoft.AlertsManagement to add version preview/2023-01-01-preview#22248

Merged
akning-ms merged 31 commits intomainfrom
yashmuel-alertsmanagement-Microsoft.AlertsManagement-2023-01-01-preview
Jan 30, 2023
Merged

[Hub Generated] Review request for Microsoft.AlertsManagement to add version preview/2023-01-01-preview#22248
akning-ms merged 31 commits intomainfrom
yashmuel-alertsmanagement-Microsoft.AlertsManagement-2023-01-01-preview

Conversation

@meydand
Copy link
Member

@meydand meydand commented Jan 19, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @meydand Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 19, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2021-08 package-2021-08(9a28187) package-2021-08(main)
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/alertsmanagement/resource-manager/readme.md
    tag: specification/alertsmanagement/resource-manager/readme.md#tag-package-2021-08
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 15 Errors, 0 Warnings failed [Detail]

    Tag package-2021-08; Prod region: Deployed

    Test run on region: westcentralus; Operation coverage: total: 25, untested: 0, failed: 15, passed: 10

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Rule Message
    CLIENT_ERROR statusCode: 400,
    errorCode: LocationNotAvailableForResourceType,
    errorMessage: The provided location 'westcentralus' is not available for resource type 'Microsoft.AlertsManagement/actionRules'. List of available regions for the resource type is 'global'.
    Source: runtime
    OperationId: AlertProcessingRules_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.AlertsManagement/actionRules/alertpromp6pek' under resource group 'apiTest-aPaROm-22248' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: AlertProcessingRules_GetByName
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.AlertsManagement/actionRules/alertpromp6pek' under resource group 'apiTest-aPaROm-22248' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: AlertProcessingRules_Update
    CLIENT_ERROR statusCode: 400,
    errorCode: LocationNotAvailableForResourceType,
    errorMessage: The provided location 'westcentralus' is not available for resource type 'Microsoft.AlertsManagement/prometheusRuleGroups'. List of available regions for the resource type is 'northcentralus,eastus,eastus2,westeurope,westus,westus2,centralus,southcentralus,brazilsouth,southeastasia,centralindia,northeurope,uksouth,eastus2euap'.
    Source: runtime
    OperationId: PrometheusRuleGroups_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.AlertsManagement/prometheusRuleGroups/rulegrouxkgdms' under resource group 'apiTest-aPaROm-22248' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: PrometheusRuleGroups_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.AlertsManagement/prometheusRuleGroups/rulegrouxkgdms' under resource group 'apiTest-aPaROm-22248' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: PrometheusRuleGroups_Update
    CLIENT_ERROR statusCode: 400,
    errorCode: ApiVersionNotRegistered,
    errorMessage: The ApiVersion '2019-05-05-preview' is not registered for ResourceType 'Microsoft.AlertsManagement/alertsMetaData'. Valid Api Versions are: '2019-03-01-preview'.
    Source: runtime
    OperationId: Alerts_MetaData
    CLIENT_ERROR statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type could not be found in the namespace 'Microsoft.AlertsManagement' for api version '2023-01-01-preview'.
    Source: runtime
    OperationId: AlertRuleRecommendations_ListByTargetType
    CLIENT_ERROR statusCode: 404,
    errorCode: NotFound,
    errorMessage: Unable to find the input alert
    Source: runtime
    OperationId: Alerts_GetById
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.AlertsManagement/alerts/changestate/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: Alerts_ChangeState
    CLIENT_ERROR statusCode: 404,
    errorCode: NotFound,
    errorMessage: Unable to find the input alert
    Source: runtime
    OperationId: Alerts_GetHistory
    CLIENT_ERROR statusCode: 404,
    errorCode: NotFound,
    errorMessage: Unable to find the input smart group
    Source: runtime
    OperationId: SmartGroups_GetById
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.AlertsManagement/smartGroups/changeState/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: SmartGroups_ChangeState
    CLIENT_ERROR statusCode: 404,
    errorCode: NotFound,
    errorMessage: Unable to find the input smart group
    Source: runtime
    OperationId: SmartGroups_GetHistory
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.AlertsManagement/alertRuleRecommendations/read' over scope '/subscriptions/2f00cc51-6809-498f-9ffc-48c42aff570d/resourcegroups/test/providers/Microsoft.Compute/virtualMachines/testMachineCanBeSafelyDeleted/providers/Microsoft.AlertsManagement' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: AlertRuleRecommendations_ListByResource
    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Alerts Management label Jan 19, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 19, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-go - sdk/resourcemanager/alertsmanagement/armalertsmanagement - 0.8.0
    +	Type of `AlertProperties.Context` has been changed from `interface{}` to `any`
    +	Type of `AlertProperties.EgressConfig` has been changed from `interface{}` to `any`
    +	Type of `AlertsClientChangeStateOptions.Comment` has been changed from `*string` to `*Comments`
    +	Type of `ErrorResponseAutoGenerated.Error` has been changed from `*ErrorResponseBodyAutoGenerated` to `*ErrorDetail`
    +	Type of `ErrorResponseAutoGenerated2.Error` has been changed from `*ErrorResponseBodyAutoGenerated2` to `*ErrorResponseBodyAutoGenerated`
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 90a294f. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:760
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 760 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.AlertsManagement [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 90a294f. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.4.0` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-alertsmanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group AlertRuleRecommendationsOperations
    ️❌ azure-sdk-for-go failed [Detail]
    • Code Generator Failed [Logs]Release - Generate from 90a294f. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      cmderr	[generator automation-v2] [ERROR] total 1 error(s):
      cmderr	[generator automation-v2] [ERROR] json: cannot unmarshal object into Go value of type []map[string]interface {}
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
      warn	Skip package processing as generation is failed
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 90a294f. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️alertsmanagement [View full logs
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 90a294f. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.alertsmanagement [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 19, 2023

    Generated ApiView

    Language Package Name ApiView Link
    swagger Microsoft.AlertsManagement Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Go sdk/resourcemanager/alertsmanagement/armalertsmanagement Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @meydand
    Copy link
    Member Author

    meydand commented Jan 19, 2023

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @meydand
    Copy link
    Member Author

    meydand commented Jan 19, 2023

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @meydand
    Copy link
    Member Author

    meydand commented Jan 19, 2023

    /azp run unifiedPipeline

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 19, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @meydand your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 27, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 27, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 27, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 28, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 28, 2023
    @visingla-ms visingla-ms added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 28, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 28, 2023
    @akning-ms
    Copy link
    Contributor

    @tadelesh to help confirm GO SDK breaking change.. @fengzhou-msft to help confirm .Net SdK generation failure

    @fengzhou-msft
    Copy link
    Member

    The error message: PreCheck/DuplicateSchema | Duplicate Schema named 'Resource' (5 differences) indicates that in the swaggers of the default package-2021-08 tag, a Resource is defined which has the same name but different definition with the one from common types which is also used by some swaggers of the tag.

    Since it's not introduced by this PR and we can fix it by deduplication, the error can be ignored.

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jan 30, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Alerts Management Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    8 participants