Remove GH token from Travis file#2217
Merged
lmazuel merged 1 commit intoAzure:masterfrom Jan 5, 2018
lmazuel:remove_ghtoken
Merged
Remove GH token from Travis file#2217lmazuel merged 1 commit intoAzure:masterfrom lmazuel:remove_ghtoken
lmazuel merged 1 commit intoAzure:masterfrom
lmazuel:remove_ghtoken
Conversation
veronicagg
approved these changes
Jan 5, 2018
Contributor
veronicagg
left a comment
There was a problem hiding this comment.
I'm ok with the change, I see that you added the token in Travis settings already. How does the env var token get consumed?
Member
Author
|
@veronicagg Travis allows two way to passe secure env variables:
This is the same thing, so removing the global.secure section means that now Travis will search for GH_TOKEN in the settings (and it will find it). So no change at all of behavior, we just move the token from one spot to another. From the doc:
https://docs.travis-ci.com/user/environment-variables/#Defining-encrypted-variables-in-.travis.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want to push this token to private when syncing
@salameer @veronicagg @marstr