Add build tags for Go SDK. by jhendrixMSFT · Pull Request #2213 · Azure/azure-rest-api-specs

jhendrixMSFT · 2018-01-04T18:16:52Z

A lot of new config files are missing build tags for the Go SDK.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

A lot of new config files are missing build tags for the Go SDK.

jhendrixMSFT · 2018-01-04T18:17:17Z

Fixes Azure/azure-sdk-for-go#919

vladbarosan · 2018-01-04T18:29:46Z

+Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.
+
+``` yaml $(tag)=='release_1_0' && $(go)
+output-folder: $(go-sdk-folder)/services/cognitiveservices/v1.0/customsearch


Go tags are already added here

vladbarosan · 2018-01-04T18:30:04Z

+Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.
+
+``` yaml $(tag)=='release_1_0' && $(go)
+output-folder: $(go-sdk-folder)/services/cognitiveservices/v1.0/imagesearch


go tags are already added here

vladbarosan · 2018-01-04T18:31:26Z

 openapi-type: arm
 tag: package-2017-07
-output-folder: ./
 csharp-sdks-folder: ./Generated/CSharp


is this intentionally removed ?

Yes, we specify output folders per language.

vladbarosan

Some duplicate Go tags in CS readme's

marstr · 2018-01-04T18:33:25Z

@@ -66,4 +66,4 @@ Please also specify `--go-sdk-folder=<path to the root directory of your azure-s

 ``` yaml $(tag) == 'runtime_2_0' && $(go)
 output-folder: $(go-sdk-folder)/services/cognitiveservices/luis/v2.0/runtime


During yesterday's meeting @joshgav brought up the sloppy appearance of having v2.0 and luis backwards as compared to the other packages. Would now be a good time to clean these things up?

This was intentional, I think we need to include "luis" in the name someplace. If we don't want it under this directory then I suggest we change the package name to "luisruntime".

CC @joshgav

Or we could switch it to /services/cognitiveservices/v2.0/luis/runtime. This might work better actually as there is already a /services/cognitiveservices/v2.0/textanalytics so it would group them under the same v2.0 directory. I will make this change.

azuresdkciprbot · 2018-01-04T19:29:31Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/azsadmin/resource-manager/InfrastructureInsights/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

File: specification/azsadmin/resource-manager/commerce/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/azsadmin/resource-manager/fabric/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

File: specification/batch/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/batchai/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/ComputerVision/readme.md
Before the PR: Warning(s): 0 Error(s): 14
After the PR: Warning(s): 0 Error(s): 14

File: specification/cognitiveservices/data-plane/ContentModerator/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/EntitySearch/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

File: specification/cognitiveservices/data-plane/Face/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/ImageSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/LUIS/Programmatic/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/LUIS/Runtime/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/NewsSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/SpellCheck/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/cognitiveservices/data-plane/TextAnalytics/readme.md
Before the PR: Warning(s): 0 Error(s): 3
After the PR: Warning(s): 0 Error(s): 3

File: specification/cognitiveservices/data-plane/VideoSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

File: specification/cognitiveservices/data-plane/WebSearch/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

File: specification/datacatalog/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/datamigration/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/locationbasedservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/machinelearningcompute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/machinelearningexperimentation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/msi/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/operationalinsights/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/powerbidedicated/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/provisioningservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 4
After the PR: Warning(s): 0 Error(s): 4

File: specification/recoveryservices/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 34
After the PR: Warning(s): 0 Error(s): 34

File: specification/recoveryservicesbackup/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 5
After the PR: Warning(s): 0 Error(s): 5

File: specification/recoveryservicessiterecovery/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 23
After the PR: Warning(s): 0 Error(s): 23

File: specification/reservations/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/search/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

File: specification/subscription/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/timeseriesinsights/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 5
After the PR: Warning(s): 0 Error(s): 5

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-01-04T20:23:28Z