Skip to content

Autorest violations fixes in RecoveryServices.Backup #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alvadb merged 2 commits into from
Jan 19, 2018
Merged

Autorest violations fixes in RecoveryServices.Backup #2208

alvadb merged 2 commits into from
Jan 19, 2018

Conversation

@DheerendraRathor
Copy link
Contributor

@DheerendraRathor DheerendraRathor commented Jan 3, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@DheerendraRathor
Copy link
Contributor Author

DheerendraRathor commented Jan 5, 2018

@alvadb Please review this.

@azuresdkciprbot
Copy link

azuresdkciprbot commented Jan 5, 2018

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/recoveryservicesbackup/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 5
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@alvadb
Copy link

alvadb commented Jan 5, 2018

Working on this. Hope to have it done by tomorrow.

alvadb
alvadb suggested changes Jan 8, 2018
View reviewed changes
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2016-12-01/bms.json
"$ref": "#/definitions/AzureIaaSVMHealthDetails"
}
},
"lastBackupStatus": {
Copy link

@alvadb alvadb Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an enum?

Copy link
Contributor Author

@DheerendraRathor DheerendraRathor Jan 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I've removed misleading description.

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2016-12-01/bms.json
"type": "object",
"properties": {
"hostServerName": {
"description": "Host Os Name in case of Stand Alone and \r\n Cluster Name in case of distributed container.",
Copy link

@alvadb alvadb Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove \r\n from description value.

Copy link
Contributor Author

@DheerendraRathor DheerendraRathor Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2016-12-01/bms.json
"type": "string"
},
"status": {
"description": "Status of this Node.\r\n Failed | Succeeded",
Copy link

@alvadb alvadb Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove \r\n from description.

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2016-12-01/bms.json
"protectedItemType": {
"description": "backup item type.",
"status": {
"description": "Status of protectable item, i.e. InProgress,Succeeded,Failed",
Copy link

@alvadb alvadb Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an enum?

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2017-07-01/bms.json
}
}
},
"BackupStatusResponse": {
Copy link

@alvadb alvadb Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add description to properties.

Copy link
Contributor Author

@DheerendraRathor DheerendraRathor Jan 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2017-07-01/bms.json
}
},
"BackupStatusRequest": {
"description": "BackupStatus request.",
Copy link

@alvadb alvadb Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add description to properties.

Copy link
Contributor Author

@DheerendraRathor DheerendraRathor Jan 9, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2017-07-01/bms.json Outdated
"type": "object",
"properties": {
"entityFriendlyName": {
"descrip
Copy link

@alvadb alvadb Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add description to properties.

Copy link
Contributor Author

@DheerendraRathor DheerendraRathor Jan 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description is already present in this case.

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2017-07-01/bms.json
"type": "object",
"properties": {
"entityFriendlyName": {
"descrip
Copy link

@alvadb alvadb Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add description to properties.

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2017-07-01/bms.json
"type": "object",
"properties": {
"entityFriendlyName": {
"descrip
Copy link

@alvadb alvadb Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add description.

@azuresdkciprbot
Copy link

azuresdkciprbot commented Jan 9, 2018

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/recoveryservicesbackup/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 5
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@DheerendraRathor
Copy link
Contributor Author

DheerendraRathor commented Jan 9, 2018

@alvadb Updated PR.

@azuresdkci azuresdkci assigned jianghaolu and unassigned alvadb Jan 17, 2018
@jianghaolu
Copy link
Contributor

jianghaolu commented Jan 18, 2018

@alvadb this PR looks good to me. Please feel free to merge if all your feedbacks are addressed.

@alvadb alvadb merged commit ee4507d into Azure:master Jan 19, 2018
@AutorestCI
Copy link

AutorestCI commented Jan 19, 2018

Was unable to find SDK Azure/azure-sdk-for-python PR for this closed PR.

@AutorestCI AutorestCI mentioned this pull request Jan 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 19, 2018

Build Status Azure/azure-sdk-for-python#1805

@AutorestCI
Copy link

AutorestCI commented Jan 19, 2018

No modification for AutorestCI/azure-sdk-for-python

@vladbarosan vladbarosan mentioned this pull request Jan 19, 2018
Closed
@DheerendraRathor DheerendraRathor mentioned this pull request Jan 23, 2018
Merged
@DheerendraRathor DheerendraRathor mentioned this pull request Feb 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alvadb alvadb alvadb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jianghaolu jianghaolu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@DheerendraRathor @azuresdkciprbot @alvadb @jianghaolu @AutorestCI @azuresdkci @olydis