Remove duplication section of recoveryservicesiterecover/..../service.json MigrateToAad section#2201
Remove duplication section of recoveryservicesiterecover/..../service.json MigrateToAad section#2201mikekinsman wants to merge 2 commits intoAzure:masterfrom
Conversation
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: 💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡 File: File: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
@mikekinsman why are you referencing the Stable spec within the Preview Spec, for ex:
in the preview files: nager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json |
|
Howdy, thanks for bearing with us here, @mikekinsman. Looking through, it seems like this is a duplicate of #2200 and #2199, is that correct? If so, I think we'll close this out and merge the other two independently to keep history a little bit more clear. Thanks! -Martin |
While it's not a best practice, it is something that happens a lot. Mike didn't introduce that behavior, it was something that was already here. For the sake of mitigating the issues we're running into, I think that we should close this copy of his changes out, and merge #2200 ASAP. |
|
Closing this now that I've merged #2200. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger