Add triggeredAnalyticsRuleRuns API#21977
Merged
dw511214992 merged 18 commits intoAzure:release-Sentinel-2023-02-01-previewfrom Jan 30, 2023
Merged
Add triggeredAnalyticsRuleRuns API#21977dw511214992 merged 18 commits intoAzure:release-Sentinel-2023-02-01-previewfrom
dw511214992 merged 18 commits intoAzure:release-Sentinel-2023-02-01-previewfrom
Conversation
|
Hi, @laithhisham Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-preview-2023-02 | package-preview-2023-02(27e96dc) | package-preview-2023-02(release-Sentinel-2023-02-01-preview) |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌~[Staging] SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @laithhisham your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Generated ApiView
|
|
Hi @laithhisham, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Dec 22, 2022
laithhisham
force-pushed
the
feature/lahisham/onDemandApi
branch
from
4c2e1bf to
a0d1078
Compare
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
raosuhas
added
the
ARMSignedOff
…DemandRun adding post on demand run
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
adding location header
closing headers
fixing warnings
fixing lint warnings pt 2
fixing flatten position
dw511214992
approved these changes
Jan 30, 2023
dw511214992
pushed a commit
that referenced
this pull request
Feb 6, 2023
* Adds base for updating Microsoft.SecurityInsights from version preview/2022-12-01-preview to version 2023-02-01-preview * Updates readme * Updates API version in new specs and examples * add microsoft purview information protection connector kind (#22150) * Add triggeredAnalyticsRuleRuns API (#21977) * Add triggeredAnalyticsRuleRuns API * fix examples path * run prettier * fix lint * fix prettier * Update readme.md * draft * draft * fixing comments * fixing nit and param name * adding requires * fixing idention * Update TriggeredAnalyticsRuleRuns.json adding location header * Update TriggeredAnalyticsRuleRuns.json closing headers * Update TriggeredAnalyticsRuleRuns.json fixing warnings * Update TriggeredAnalyticsRuleRuns.json fixing lint warnings pt 2 * Update TriggeredAnalyticsRuleRuns.json fixing flatten position --------- Co-authored-by: Rotemdvir1 <rotemdvir@microsoft.com> Co-authored-by: Rotemdvir1 <95570648+Rotemdvir1@users.noreply.github.com> * MTP data connector- filter alerts by provider (#22245) * MTP data connector- filter alerts by provider * validations --------- Co-authored-by: Alexander Feldsher <66358192+alfeldsh@users.noreply.github.com> Co-authored-by: Laith Hisham <49263932+laithhisham@users.noreply.github.com> Co-authored-by: Rotemdvir1 <rotemdvir@microsoft.com> Co-authored-by: Rotemdvir1 <95570648+Rotemdvir1@users.noreply.github.com> Co-authored-by: sivanguetta <46525261+sivanguetta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
12/27/2022
12/26/2022
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.