[Hub Generated] Review request for Microsoft.StorageMover to add version stable/2023-03-01

[Squidgy-sup]

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

1. What's the purpose of the update?
   • new service onboarding
   • new API version
   • update existing version for new feature
   • update existing version to fix swagger quality issue in s360
   • Other, please clarify
2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

• I commit to follow the Breaking Change Policy of "no breaking changes"
• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

• Change to data plane APIs
• Adding new properties
• All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

• Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

  • Adding a new service
  • Adding new API(s)
  • Adding a new API version
    -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

• Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

• If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

[openapi-workflow-bot]

Hi, @Squidgy-sup Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

[openapi-pipeline-app]

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
storagemover.json	2023-03-01(ac3e8f0)	2022-07-01-preview(main)

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2023-03	package-2023-03(ac3e8f0)	default(main)

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ ParameterDescription	Parameter should have a description. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L219
⚠️ ParameterDescription	Parameter should have a description. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L267
⚠️ ParameterDescription	Parameter should have a description. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L455
⚠️ ParameterDescription	Parameter should have a description. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L506
⚠️ ParameterDescription	Parameter should have a description. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L697
⚠️ ParameterDescription	Parameter should have a description. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L748
⚠️ ParameterDescription	Parameter should have a description. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L939
⚠️ ParameterDescription	Parameter should have a description. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L990
⚠️ ParameterDescription	Parameter should have a description. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L1190
⚠️ ParameterDescription	Parameter should have a description. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L1244
⚠️ SchemaDescriptionOrTitle	Schema should have a description or title. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L1530
⚠️ SchemaDescriptionOrTitle	Schema should have a description or title. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L1658
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L1827
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L1858
⚠️ SchemaDescriptionOrTitle	Schema should have a description or title. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L1881
⚠️ SchemaDescriptionOrTitle	Schema should have a description or title. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L1908
⚠️ SchemaDescriptionOrTitle	Schema should have a description or title. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L1916
⚠️ SchemaDescriptionOrTitle	Schema should have a description or title. Location: Microsoft.StorageMover/stable/2023-03-01/storagemover.json#L1964

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
❌ API Readiness check failed. Please make sure your service is deployed.	"code: InvalidResourceType, message: The resource type 'Operations' could not be found in the namespace 'Microsoft.StorageMover' for api version '2023-03-01'. The supported api-versions are '2022-07-01-preview'."

️❌~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]

Tag package-2023-03; Prod region: Not deployed; Canary region: Not deployed

️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]

️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account. 

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

• ⚠️Warning [Logs]Release - Generate from 470c544. SDK Automation 14.0.0

  command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
  cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
  command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  cmderr	[automation_generate.sh]
  cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.0
  cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.0>
  cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.4.0` to update!
  cmderr	[automation_generate.sh] npm notice
  warn	No file changes detected after generation
  warn	No package detected after generation

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from 470c544. SDK Automation 14.0.0

  command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
  command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

• ️✔️azure-resourcemanager-storagemover [View full logs]  [Release SDK Changes]
  • pom.xml
  • azure-resourcemanager-storagemover-1.0.0-beta.1.jar
  • azure-resourcemanager-storagemover-1.0.0-beta.1-sources.jar

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from 470c544. SDK Automation 14.0.0

  command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
  command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

• ️✔️sdk/resourcemanager/storagemover/armstoragemover [View full logs]  [Release SDK Changes]

  info	[Changelog] This is a new package
  info	[Changelog]

️❌ azure-sdk-for-js failed [Detail]

• ❌Failed [Logs]Release - Generate from 470c544. SDK Automation 14.0.0

  command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
  warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
  command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  cmderr	[automation_generate.sh] [ERROR] Error:
  cmderr	[automation_generate.sh] [ERROR] An error occurred while run build for readme file: "specification/storagemover/resource-manager/readme.md":
  cmderr	[automation_generate.sh] [ERROR] Err: Error: Command failed: rush build -t @azure/arm-storagemover
  cmderr	[automation_generate.sh] [ERROR] Stderr: "null"
  cmderr	[automation_generate.sh] [ERROR] Stdout: "null"
  cmderr	[automation_generate.sh] [ERROR] ErrorStack: "Error: Command failed: rush build -t @azure/arm-storagemover
  cmderr	[automation_generate.sh] [ERROR]     at checkExecSyncError (node:child_process:861:11)
  cmderr	[automation_generate.sh] [ERROR]     at Object.execSync (node:child_process:932:15)
  cmderr	[automation_generate.sh] [ERROR]     at Object.<anonymous> (/opt/hostedtoolcache/node/16.19.0/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/hlc/generateMgmt.js:87:33)
  cmderr	[automation_generate.sh] [ERROR]     at Generator.next (<anonymous>)
  cmderr	[automation_generate.sh] [ERROR]     at fulfilled (/opt/hostedtoolcache/node/16.19.0/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:112:62)
  cmderr	[automation_generate.sh] [ERROR]     at processTicksAndRejections (node:internal/process/task_queues:96:5)"

• ❌@azure/arm-storagemover [View full logs]  [Release SDK Changes]

  info	[Changelog]
  error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-resource-manager-schemas warning [Detail]

• ⚠️Warning [Logs]Release - Generate from 470c544. Schema Automation 14.0.0

  command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
  cmderr	[initScript.sh]  WARN old lockfile
  cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
  cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
  cmderr	[initScript.sh] npm WARN old lockfile
  cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
  cmderr	[initScript.sh] npm WARN old lockfile
  warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
  command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

• ️✔️storagemover [View full logs]  [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/storagemover/armstoragemover	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java	azure-resourcemanager-storagemover	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

[openapi-workflow-bot]

Hi, @Squidgy-sup your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

[Squidgy-sup]

/azp run unifiedPipeline

[azure-pipelines]

No pipelines are associated with this pull request.

[ghost]

Hi, @Squidgy-sup. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

[ghost]

Hi, @Squidgy-sup. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

[AbhishekKrishna123]

@dw511214992 / ARM review team, Could you please re-open and merge this PR? It has the required approvals. Thanks.

---

Edit: We'll merge this in February, closer to our GA release date. Will leave this one inactive for now.

[johnmic]

@dw511214992, asignee, please merge the PR.

[johnmic]

@dw511214992 please merge the PR, ty