[Compute] Add VmssVM PUT API.#2180
Conversation
There was a problem hiding this comment.
Addition of settable properties to an existing model (VirtualMachineScaleSetVMProfile) of an existing api version is considered as breaking change.
It looks like this model VirtualMachineScaleSetVMProfile is used in VirtualMachineScaleSet model [VirtualMachineScaleSet -> VirtualMachineScaleSetProperties -> VirtualMachineScaleSetVMProfile] which represent payload of already supported VMSS create or update op. that means we are adding settable properties to VMSS create_update payload.
Adding ARM to review this.
|
@ravbhatnagar please take a look |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: 💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡 File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
There was a problem hiding this comment.
Add the final 200 OK response also under "responses".
There was a problem hiding this comment.
This requires an API-version change as a new writable property is getting added.
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
@hyonholee what's the plan here? are we going to bump up the api version based on Gaurav's comment? |
|
@anuchandy I removed the priority part, which Gaurav said requires API version update. Now this PR only contains VMSSVM PUT operation. This is additional operation and does not modify existing API, so does not require API version update. |
|
@anuchandy For priority, I will send a separate PR after we resolve the issue. |
anuchandy
left a comment
There was a problem hiding this comment.
@ravbhatnagar PR looks good to me, can you please sign-off?
|
Signing off! |
|
@anuchandy Please merge this PR. I will send a separate PR for priority right after this PR is merged. Thanks. |
|
Thanks @ravbhatnagar. @hyonholee merging. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger