Skip to content

[Compute] Add VmssVM PUT API.#2180

Merged
anuchandy merged 1 commit intoAzure:masterfrom
hyonholee:vmssvm_put
Jan 9, 2018
Merged

[Compute] Add VmssVM PUT API.#2180
anuchandy merged 1 commit intoAzure:masterfrom
hyonholee:vmssvm_put

Conversation

@hyonholee
Copy link
Copy Markdown
Contributor

@hyonholee hyonholee commented Dec 19, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@anuchandy anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 20, 2017
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition of settable properties to an existing model (VirtualMachineScaleSetVMProfile) of an existing api version is considered as breaking change.

It looks like this model VirtualMachineScaleSetVMProfile is used in VirtualMachineScaleSet model [VirtualMachineScaleSet -> VirtualMachineScaleSetProperties -> VirtualMachineScaleSetVMProfile] which represent payload of already supported VMSS create or update op. that means we are adding settable properties to VMSS create_update payload.

Adding ARM to review this.

@marstr marstr changed the base branch from current to master December 28, 2017 17:52
@anuchandy
Copy link
Copy Markdown
Member

@ravbhatnagar please take a look

@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 32
After the PR: Warning(s): 0 Error(s): 33

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the final 200 OK response also under "responses".

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires an API-version change as a new writable property is getting added.

@hyonholee hyonholee changed the title [Compute] Add VmssVM PUT API and priority property. [Compute] Add VmssVM PUT API. Jan 5, 2018
@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 32
After the PR: Warning(s): 0 Error(s): 32

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@anuchandy
Copy link
Copy Markdown
Member

@hyonholee what's the plan here? are we going to bump up the api version based on Gaurav's comment?

@hyonholee
Copy link
Copy Markdown
Contributor Author

@anuchandy I removed the priority part, which Gaurav said requires API version update. Now this PR only contains VMSSVM PUT operation. This is additional operation and does not modify existing API, so does not require API version update.

@hyonholee
Copy link
Copy Markdown
Contributor Author

@anuchandy For priority, I will send a separate PR after we resolve the issue.

Copy link
Copy Markdown
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravbhatnagar PR looks good to me, can you please sign-off?

@ravbhatnagar
Copy link
Copy Markdown
Contributor

Signing off!

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 9, 2018
@hyonholee
Copy link
Copy Markdown
Contributor Author

@anuchandy Please merge this PR. I will send a separate PR for priority right after this PR is merged. Thanks.

@anuchandy
Copy link
Copy Markdown
Member

Thanks @ravbhatnagar. @hyonholee merging.

@AutorestCI
Copy link
Copy Markdown

@AutorestCI
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants