Draft
Conversation
* Initial commit * formatted * fix appconfig * API management fix * keyvault * Storage * signalR * servicebus * resources * redis * policy insights * eventhub * Iothub * cr * cr-2 * web * maps * healthcare APi * media services * media services * ACS * Eg omdels
|
Hi, @l0lawrence Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
ghost
added
the
johanste
reviewed
Dec 19, 2022
| } | ||
|
|
||
| @doc("Event data for Microsoft.Devices.DeviceCreated event.") | ||
| model IotHubDeviceCreatedEventData extends DeviceLifeCycleEventProperties {} |
Member
There was a problem hiding this comment.
Unless this is done only to reduce changes to generated openapi2 documents, this should be a spread. We want to avoid extends in Azure unless it is a discriminated type relationship...
Swagger Validation Report
|
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| default | default(a19e059) | default(main) |
️❌Avocado: 20 Errors, 0 Warnings failed [Detail]
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 3 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
x-ms-example not found in PublishEventGridEvents. Url: data-plane/typespec/swagger/EventGrid.json#L43:15 |
|
x-ms-example not found in PublishCloudEventEvents. Url: data-plane/typespec/swagger/EventGrid.json#L75:15 |
|
x-ms-example not found in PublishCustomEventEvents. Url: data-plane/typespec/swagger/EventGrid.json#L110:15 |
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️❌SpellCheck: 42 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Unknown word (typespec), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L9:23 |
|
Unknown word (typespec), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L10:23 |
|
Unknown word (typespec), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L11:23 |
|
Unknown word (typespec), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L12:11 |
|
Unknown word (globby), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L185:10 |
|
Unknown word (picocolors), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L191:10 |
|
Unknown word (nodelib), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L242:20 |
|
Unknown word (scandir), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L242:31 |
|
Unknown word (nodelib), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L247:11 |
|
Unknown word (nodelib), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L254:20 |
|
Unknown word (nodelib), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L262:20 |
|
Unknown word (scandir), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L267:22 |
|
Unknown word (fastq), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L268:10 |
|
Unknown word (globby), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L282:10 |
|
Unknown word (picocolors), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L288:10 |
|
Unknown word (cliui), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L479:19 |
|
Unknown word (fastq), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L589:19 |
|
Unknown word (reusify), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L594:10 |
|
Unknown word (domexception), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L612:15 |
|
Unknown word (formdata), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L630:19 |
|
Unknown word (globby), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L660:19 |
|
Unknown word (extglob), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L703:22 |
|
Unknown word (extglob), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L724:13 |
|
Unknown word (kleur), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L759:19 |
|
Unknown word (yallist), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L780:10 |
|
Unknown word (picomatch), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L800:10 |
|
Unknown word (domexception), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L834:24 |
|
Unknown word (formdata), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L859:10 |
|
Unknown word (opencollective), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L865:18 |
|
Unknown word (picocolors), please fix the error or add words to ./custom-words.txt path: eventgrid/data-plane/typespec/package-lock.json#L912:19 |
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️❌CadlValidation: 20 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/ApiManagement.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/AppConfiguration.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/AzureCommunicationServices.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/ContainerRegistry.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/ContainerService.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/EventGrid.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/EventHub.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/HealthcareApis.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/IotHub.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/KeyVault.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/MachineLearningServices.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/Maps.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/MediaServices.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/PolicyInsights.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/RedisCache.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/Resources.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/ServiceBus.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/SignalRService.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/Storage.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
|
"details":"The swagger specification/eventgrid/data-plane/typespec/swagger/Web.json is generated from cadl files, but the cadl project with '@azure-tools/cadl-autorest' emitter is missing in the PR. Please add the missing cadl project or emitter configuration." |
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Member
|
@l0lawrence: Can this be closed as a dup of #23204? |
Member
Author
These are all the system events in EventGrid in typespec, #23204 was the EGv2 preview api! |
Member
So this is another spec that will be added to the repo eventually? If so, please make sure it is passing all the checks (including |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.