Adding Swagger for Domain renewal API by mn263 · Pull Request #2155 · Azure/azure-rest-api-specs

mn263 · 2017-12-15T20:20:05Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

jianghaolu · 2017-12-20T19:20:14Z

+          "204": {
+            "description": "Domain does not exist."
+          },
+          "400": {


All the negative response status code descriptions MUST be defined in the description of the "default" status code (if the intention is for documentation purpose only). Example: "description": "'404' - 'Not found'.\n'400' - 'Bad request'.\n'500': 'Internal Server Error'."'

I'm not sure what you mean. Do you mean just changing the description from something like "Malformed domain renewal request." to "'400' - 'Bad request'." ?

If you list a response code like this it will be treated as a valid response code. Thus you must not list error response codes but put all of them in meaningful descriptions in status code "default". E.g.:

azure-rest-api-specs/specification/provisioningservices/resource-manager/Microsoft.Devices/2017-08-21-preview/iotdps.json

Line 63 in 9ae8eea

"default": {

jianghaolu · 2017-12-20T19:20:49Z

+          "200": {
+            "description": "Domain renewal was successful."
+          },
+          "202": {


Is this a long running operation? Please add "x-ms-long-running-operation": true if so.

jianghaolu · 2017-12-20T19:21:49Z

+        ],
+        "summary": "Renew a domain.",
+        "description": "Renew a domain.",
+        "operationId": "Domains_Renew",


Please add an example to this operation. See https://github.com/Azure/azure-rest-api-specs/blob/current/documentation/x-ms-examples.md

Done with latest commit.

…into current

azuresdkciprbot · 2018-01-09T23:07:38Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/web/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 45
After the PR: Warning(s): 0 Error(s): 45

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

jianghaolu · 2018-01-09T23:29:44Z

+    },
+    "responses": {
+        "200": {
+            "body": {}


Remove "body": {} since the operation doesn't return a body

jianghaolu · 2018-01-09T23:30:01Z

+        "domainName": "example.com"
+    },
+    "responses": {
+        "200": {


Please also add 202 and 204 here

azuresdkciprbot · 2018-01-12T16:34:16Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/web/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 45
After the PR: Warning(s): 0 Error(s): 45

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-01-17T18:16:55Z

Was unable to find SDK Azure/azure-sdk-for-python PR for this closed PR.

AutorestCI · 2018-01-17T23:55:37Z

Was unable to find SDK Azure/azure-sdk-for-python PR for this closed PR.

AutorestCI · 2018-01-18T00:03:36Z

Azure/azure-sdk-for-python#1796

AutorestCI · 2018-01-18T00:03:52Z

Azure/azure-sdk-for-ruby#1240

AutorestCI · 2018-01-18T00:07:48Z

No modification for AutorestCI/azure-sdk-for-python

Adding Swagger for Domain renewal API

ff88822

azuresdkci assigned jianghaolu Dec 15, 2017

jianghaolu suggested changes Dec 20, 2017

View reviewed changes

Adding Swagger for Domain renewal API

1106c89

marstr changed the base branch from current to master December 28, 2017 17:54

Matt added 5 commits January 3, 2018 11:14

Adding Swagger for Domain renewal API

7ee4157

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

d693269

…into current

Adding Swagger for Domain renewal API

f55fda3

Adding Swagger for Domain renewal API

ba2293b

Adding Swagger for Domain renewal API

0f9280c

jianghaolu approved these changes Jan 9, 2018

View reviewed changes

Adding Swagger for Domain renewal API

7be2b5e

mn263 closed this Jan 17, 2018

mn263 reopened this Jan 17, 2018

jianghaolu merged commit a70ffe7 into Azure:master Jan 17, 2018

AutorestCI mentioned this pull request Jan 18, 2018

[Web] Latest Azure/azure-sdk-for-python#1796

Closed

AutorestCI mentioned this pull request Jan 18, 2018

Automatic PR from RestAPI-PR2155 Azure/azure-sdk-for-ruby#1240

Closed

Conversation

mn263 commented Dec 15, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Jan 9, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Jan 12, 2018

Uh oh!

AutorestCI commented Jan 17, 2018

Uh oh!

AutorestCI commented Jan 17, 2018

Uh oh!

AutorestCI commented Jan 18, 2018

Uh oh!

AutorestCI commented Jan 18, 2018

Uh oh!

AutorestCI commented Jan 18, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mn263 commented Dec 15, 2017 •

edited by azuresdkci

Loading