Skip to content

Fix the wrong value of queryId in MariaDB example files#21406

Merged
honghr merged 1 commit intoAzure:mainfrom
Yiyao-MS:yiyao/fix-queryid-mariadb
Nov 4, 2022
Merged

Fix the wrong value of queryId in MariaDB example files#21406
honghr merged 1 commit intoAzure:mainfrom
Yiyao-MS:yiyao/fix-queryid-mariadb

Conversation

@Yiyao-MS
Copy link
Contributor

@Yiyao-MS Yiyao-MS commented Nov 3, 2022

Modified the value of queryId from integer to string in MariaDB example files

To fix the Linter Validation Error

@openapi-workflow-bot
Copy link

openapi-workflow-bot bot commented Nov 3, 2022

Hi, @Yiyao-MS Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 3, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/mariadb/resource-manager/readme.md
    tag: specification/mariadb/resource-manager/readme.md#tag-package-2020-01-01
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand] 
    Validation passes for ServiceAPIReadinessTest.
    ️❌ModelValidation: 20 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L134:22
    ExampleUrl: preview/2018-06-01-privatepreview/examples/ServerUpdate.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L172:22
    ExampleUrl: preview/2018-06-01-privatepreview/examples/ServerDelete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L315:22
    ExampleUrl: preview/2018-06-01-privatepreview/examples/ServerRestart.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L456:22
    ExampleUrl: preview/2018-06-01-privatepreview/examples/FirewallRuleDelete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L669:22
    ExampleUrl: preview/2018-06-01-privatepreview/examples/VirtualNetworkRulesDelete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L818:22
    ExampleUrl: preview/2018-06-01-privatepreview/examples/DatabaseDelete.json
    ❌ INVALID_REQUEST_PARAMETER api-version 2018-06-01-privatepreview is not equal to swagger version
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1271:14
    ExampleUrl: preview/2018-06-01-privatepreview/examples/QueryTextsGet.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2018-06-01-privatepreview is not equal to swagger version
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1310:14
    ExampleUrl: preview/2018-06-01-privatepreview/examples/QueryTextsListByServer.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2018-06-01-privatepreview is not equal to swagger version
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1360:14
    ExampleUrl: preview/2018-06-01-privatepreview/examples/TopQueryStatisticsGet.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2018-06-01-privatepreview is not equal to swagger version
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1399:14
    ExampleUrl: preview/2018-06-01-privatepreview/examples/TopQueryStatisticsListByServer.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2018-06-01-privatepreview is not equal to swagger version
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1447:14
    ExampleUrl: preview/2018-06-01-privatepreview/examples/WaitStatisticsGet.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2018-06-01-privatepreview is not equal to swagger version
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1486:14
    ExampleUrl: preview/2018-06-01-privatepreview/examples/WaitStatisticsListByServer.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2018-06-01-privatepreview is not equal to swagger version
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1534:14
    ExampleUrl: preview/2018-06-01-privatepreview/examples/AdvisorsGet.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2018-06-01-privatepreview is not equal to swagger version
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1573:14
    ExampleUrl: preview/2018-06-01-privatepreview/examples/AdvisorsListByServer.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2018-06-01-privatepreview is not equal to swagger version
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1612:15
    ExampleUrl: preview/2018-06-01-privatepreview/examples/RecommendedActionSessionCreate.json#L2:17
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1647:22
    ExampleUrl: preview/2018-06-01-privatepreview/examples/RecommendedActionSessionCreate.json
    ❌ INVALID_REQUEST_PARAMETER api-version 2018-06-01-privatepreview is not equal to swagger version
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1659:14
    ExampleUrl: preview/2018-06-01-privatepreview/examples/RecommendedActionsGet.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2018-06-01-privatepreview is not equal to swagger version
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1701:14
    ExampleUrl: preview/2018-06-01-privatepreview/examples/RecommendedActionsListByServer.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2018-06-01-privatepreview is not equal to swagger version
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1750:14
    ExampleUrl: preview/2018-06-01-privatepreview/examples/RecommendedActionSessionOperationStatus.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2018-06-01-privatepreview is not equal to swagger version
    Url: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1786:14
    ExampleUrl: preview/2018-06-01-privatepreview/examples/RecommendedActionSessionResult.json#L2:17
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 3, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - sdk/resourcemanager/mariadb/armmariadb - 2.0.0
    +	Struct `CloudError` has been removed


    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4047b23. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.MariaDB [View full logs]  [Release SDK Changes] 
      warn	Skip artifact folder because it doesn't exist: artifacts/packages
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4047b23. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New patch version of npm available! 8.19.2 -> 8.19.3
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.3>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.19.3` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-rdbms [View full logs]  [Release SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4047b23. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4047b23. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/mariadb/armmariadb [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Struct `CloudError` has been removed
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4047b23. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-mariadb [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface Advisor
info	[Changelog]   - Added Interface Configuration
info	[Changelog]   - Added Interface Database
info	[Changelog]   - Added Interface FirewallRule
info	[Changelog]   - Added Interface LogFile
info	[Changelog]   - Added Interface PrivateEndpointConnection
info	[Changelog]   - Added Interface PrivateLinkResource
info	[Changelog]   - Added Interface ProxyResource
info	[Changelog]   - Added Interface QueryStatistic
info	[Changelog]   - Added Interface QueryText
info	[Changelog]   - Added Interface RecommendationAction
info	[Changelog]   - Added Interface RecoverableServerResource
info	[Changelog]   - Added Interface Server
info	[Changelog]   - Added Interface ServerPropertiesForDefaultCreate
info	[Changelog]   - Added Interface ServerPropertiesForGeoRestore
info	[Changelog]   - Added Interface ServerPropertiesForReplica
info	[Changelog]   - Added Interface ServerPropertiesForRestore
info	[Changelog]   - Added Interface ServerSecurityAlertPolicy
info	[Changelog]   - Added Interface TrackedResource
info	[Changelog]   - Added Interface VirtualNetworkRule
info	[Changelog]   - Added Interface WaitStatistic
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4047b23. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️mariadb [View full logs] 
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs]Release - Generate from 4047b23. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.mariadb [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 3, 2022 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/mariadb/armmariadb Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-rdbms Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-mariadb Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @openapi-workflow-bot
    Copy link

    openapi-workflow-bot bot commented Nov 3, 2022

    Hi @Yiyao-MS, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @azure-sdk azure-sdk mentioned this pull request Nov 3, 2022
    Closed
    This was referenced Nov 3, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    @honghr honghr merged commit 4047b23 into Azure:main Nov 4, 2022
    This was referenced Nov 4, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
    @Yiyao-MS @anandanthony
    fixed the queryid from int to string (Azure#21406)
    fcbaad6
    kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
    @Yiyao-MS @kayousef
    fixed the queryid from int to string (Azure#21406)
    09b75dd
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    1 more reviewer

    @honghr honghr honghr approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    @honghr honghr

    Labels

    Approved-ModelValidation CI-BreakingChange-Go CI-FixRequiredOnFailure resource-manager

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @Yiyao-MS @honghr @AzureRestAPISpecReview